From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 75D60385840E for ; Mon, 20 Feb 2023 12:08:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75D60385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676894932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bSuBX/JwvG9voACuoPBcxC5bPCc3xXQX8o8lriA8kjw=; b=IjSK3/ppvunr+xIF2Ii/aQ+xcKuyCOzP/CXEKdTob77izQO/OZw6vUNH2bG/F9C+1wQFIl pc/gqQ2UDN9tiMU8Jm7hAuEEdbj+endE2C6rCIobWmCdjihNtAGfSY05B0vFFdMCXaRmWD /GkofNU9eIxqA6uz1JoipB9NqbfytKw= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-46-mAByytMoMQu-s1MI10lS8g-1; Mon, 20 Feb 2023 07:08:51 -0500 X-MC-Unique: mAByytMoMQu-s1MI10lS8g-1 Received: by mail-lj1-f198.google.com with SMTP id g8-20020a2e9e48000000b002904dcec88eso160158ljk.8 for ; Mon, 20 Feb 2023 04:08:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bSuBX/JwvG9voACuoPBcxC5bPCc3xXQX8o8lriA8kjw=; b=pMW2qwqCNV7JaFYVeHRMq94HN75VeR8C+OQVTAt19/lLqTCpMZ3isw2lkb/TY+QljQ +Iwwagyw6+GGw8c1/bVQLxBKurRDt2tUISUWpyxp2mshmRdCATmTP1rRf7WiNxQLlRvZ fxSjDx7/iaTlOAKCAhu6kasB3ss5NjMPzvjda3QHN5fkwnge2+VOomplxD878LBc+KwV OW1QwlCMd0cg8R8ezt3e2muL1Zxz/+C6hoA77bdnrOFZkogI8DKqJ4xTMF1reqoUghtc pAVBOoVVuXuAlPxevKSrvJKsmt2+5XrUGWLVs2EMuCTiOyDxosxyHRIeniVmg2SNPMd4 E/NA== X-Gm-Message-State: AO0yUKVTz95mlAVBfj2nj+CvrNOq6FZm8znJiX3yEubrYD8If0TEsgbk 0Ises/cJiKyKFR6x++qleL0h+agkLuMbxHqGlPdtSiSmsuDJjoDwEmX155Pp0ZhZED+FcjBnfOm l0VUW//ZN/BeLMV69PuraWCibanRpJokXag== X-Received: by 2002:ac2:48a7:0:b0:4db:173e:812a with SMTP id u7-20020ac248a7000000b004db173e812amr580590lfg.8.1676894929798; Mon, 20 Feb 2023 04:08:49 -0800 (PST) X-Google-Smtp-Source: AK7set/s0SzbY1Q3PxsA7QBlffIIxJTmkiv8NnXWT9Dh4TmLAy/fSGVQKh5e1bmK3Jv7WS2ajpwtDwFZ9LEn6+R3RNk= X-Received: by 2002:ac2:48a7:0:b0:4db:173e:812a with SMTP id u7-20020ac248a7000000b004db173e812amr580582lfg.8.1676894929522; Mon, 20 Feb 2023 04:08:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 20 Feb 2023 12:08:38 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Add missing functions to [PR79700] To: Nathaniel Shead Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 20 Feb 2023 at 11:57, Nathaniel Shead wrote: > > On Mon, Feb 20, 2023 at 10:30 PM Jonathan Wakely wrote: > > > > On Mon, 20 Feb 2023 at 11:23, Nathaniel Shead via Libstdc++ > > wrote: > > > > > > The comments on PR79700 mentioned that it was somewhat ambiguous whether > > > these functions were supposed to exist for C++11 or not. I chose to add > > > them there, since other resources (such as cppreference) seem to think > > > that C++11 should be the standard these functions were introduced, and I > > > don't know of any reason to do otherwise. > > > > > > Tested on x86_64-linux. > > > > Thanks for the patch, but this needs tests for the new declarations > > (which are tedious to write, which is the main reason I haven't > > already pushed my own very similar patch). > > > > Ah OK, fair enough. Where should the tests go? The only tests I could > find for the existing (non -f/l) functions was just tests for their > existence in testsuite/26_numerics/headers/cmath/functions_std_c++17.cc > which I just added the new functions to - I guess I'll add a new file > here and test that all the functions can be called and give the same > results as the relevant overloaded variants? Yeah, that sounds great, thanks!