From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 673893857C6F for ; Wed, 20 Oct 2021 19:22:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 673893857C6F Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-K41Bg_UtN0y_6ITXA0ml7g-1; Wed, 20 Oct 2021 15:22:50 -0400 X-MC-Unique: K41Bg_UtN0y_6ITXA0ml7g-1 Received: by mail-vk1-f199.google.com with SMTP id m133-20020a1fee8b000000b002a4a62429beso5725683vkh.0 for ; Wed, 20 Oct 2021 12:22:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gZ8hO+R45N1D4Flu0UTEdvSrbqU65tAkNw6g3EUCN9Q=; b=Ct6vVGt0D3i4npPbJFwNCXB1rUa29U6CbcPLcZFQQEBVDHXyocE0ZO9QcMV3OjDKAb AHCvyMZnemUE3XpU7wjipHxReCxQYmxyHh/Z1gcO48h7HQp/AkbotmV3f11CkhNqvHny WvkfuTVDvLDCQY3Cuz13ouZnaf/uDRjMjp+RYSNCyM/NidsY5gz4WQT0ctwk6pMwYW1/ +fj9su40KLVQM0NlIbcSRogR/vm89XDt895WZ9Qz76fw7BltuyFROxMLuKok+WnWT4BO 49bM8WbZBaJ6TupX1USUuqeOZ3IxnGNCsvdo2ir2X+pqZ5c8kYH5was4dqS1825P7Osz 3vjA== X-Gm-Message-State: AOAM533tqTtpSe3o7xmSBaUdXia8fEmGnwvLmstY3gPfAGOVKFxhFdru SwYdFEe3SMNgNo/QkLdLVjgJVRhRGhTlf9td7ybxH73O2MWofNBUiKPGYk/yugtYushqu1Tpxj9 ZggCzr55ItIQk4+GNRqgE9r95k1qJYsCRFw== X-Received: by 2002:a67:e0c2:: with SMTP id m2mr1420069vsl.2.1634757770170; Wed, 20 Oct 2021 12:22:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMSx1V++ZQK61mg20hAmHdI29kbc+unxOL6xGlz2RydI/DsUI3nZ88K019AalRya4aa6hoKqOlCdzTxZZF820= X-Received: by 2002:a67:e0c2:: with SMTP id m2mr1420037vsl.2.1634757769926; Wed, 20 Oct 2021 12:22:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 20 Oct 2021 20:22:39 +0100 Message-ID: Subject: [committed] libstdc++: Add missing test for std::optional::transform(F&&) To: Tim Song Cc: "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="0000000000002bc69d05cecdb4c5" X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2021 19:22:54 -0000 --0000000000002bc69d05cecdb4c5 Content-Type: text/plain; charset="UTF-8" On Wed, 20 Oct 2021 at 09:42, Jonathan Wakely wrote: > > On Wed, 20 Oct 2021 at 06:48, Tim Song wrote: > > > > On Tue, Oct 19, 2021 at 9:05 AM Jonathan Wakely via Gcc-patches > > wrote: > > > > > > +constexpr bool > > > +test_copy_elision() > > > +{ > > > + return true; > > > +} > > > + > > > +static_assert( test_copy_elision() ); > > > + > > > > This isn't much of a test :) > > The ultimate copy elision. The copies even get removed from the source code. > > Thanks for spotting it. I meant to check we're constructing directly > into the union member without materializing the temporary early. I'll > add that today. Fixed by the attached patch. Tested x86_64-linux, pushed to trunk. Thanks again! --0000000000002bc69d05cecdb4c5 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kuzwjnx90 Y29tbWl0IDRiYTRiMDUzMTUxYTIwMjYyZDRiNjFlYjQ1MDFhYTFjNDgzMzdhYmIKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBXZWQgT2N0IDIwIDIw OjEyOjI4IDIwMjEKCiAgICBsaWJzdGRjKys6IEFkZCBtaXNzaW5nIHRlc3QgZm9yIHN0ZDo6b3B0 aW9uYWw6OnRyYW5zZm9ybShGJiYpCiAgICAKICAgIFRoZSB0ZXN0X2NvcHlfZWxpc2lvbigpIGZ1 bmN0aW9uIHdhcyBzdXBwb3NlZCB0byBlbnN1cmUgdGhhdCB0aGUgcmVzdWx0CiAgICBpcyBjb25z dHJ1Y3RlZCBkaXJlY3RseSBpbiB0aGUgc3RkOjpvcHRpb25hbCwgd2l0aG91dCBlYXJseSB0ZW1w b3JhcnkKICAgIG1hdGVyaWFsaXphdGlvbi4gQnV0IEkgZm9yZ290IHRvIHdyaXRlIHRoZSB0ZXN0 LgogICAgCiAgICBsaWJzdGRjKystdjMvQ2hhbmdlTG9nOgogICAgCiAgICAgICAgICAgICogdGVz dHN1aXRlLzIwX3V0aWwvb3B0aW9uYWwvbW9uYWRpYy90cmFuc2Zvcm0uY2M6IENoZWNrIHRoYXQK ICAgICAgICAgICAgYW4gcnZhbHVlIHJlc3VsdCBpcyBub3QgbWF0ZXJpYWxpemVkIHRvbyBzb29u LgoKZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC9vcHRpb25hbC9t b25hZGljL3RyYW5zZm9ybS5jYyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC9vcHRp b25hbC9tb25hZGljL3RyYW5zZm9ybS5jYwppbmRleCBkMDFjY2IyZTBmMi4uMTM5NzdiOGJhOGQg MTAwNjQ0Ci0tLSBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC9vcHRpb25hbC9tb25h ZGljL3RyYW5zZm9ybS5jYworKysgYi9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIwX3V0aWwvb3B0 aW9uYWwvbW9uYWRpYy90cmFuc2Zvcm0uY2MKQEAgLTExMCw2ICsxMTAsMjMgQEAgc3RhdGljX2Fz c2VydCggdGVzdF9mb3J3YXJkaW5nKCkgKTsKIGNvbnN0ZXhwciBib29sCiB0ZXN0X2NvcHlfZWxp c2lvbigpCiB7CisgIHN0cnVjdCBpbW1vdmFibGUKKyAgeworICAgIGNvbnN0ZXhwciBpbW1vdmFi bGUoaW50IHApIDogcG93ZXJfbGV2ZWwocCkgeyB9CisgICAgaW1tb3ZhYmxlKGltbW92YWJsZSYm KSA9IGRlbGV0ZTsKKworICAgIGludCBwb3dlcl9sZXZlbDsKKyAgfTsKKworICBzdHJ1Y3QgRm9y Y2UKKyAgeworICAgIGNvbnN0ZXhwciBpbW1vdmFibGUgb3BlcmF0b3IoKShpbnQgaSkgY29uc3Qg eyByZXR1cm4ge2krMX07IH0KKyAgfTsKKworICBzdGQ6Om9wdGlvbmFsPGludD4gaXJyZXNpc3Rp YmxlKDkwMDApOworICBzdGQ6Om9wdGlvbmFsPGltbW92YWJsZT4gb2JqZWN0ID0gaXJyZXNpc3Rp YmxlLnRyYW5zZm9ybShGb3JjZXt9KTsKKyAgVkVSSUZZKCBvYmplY3QtPnBvd2VyX2xldmVsID4g OTAwMCApOworCiAgIHJldHVybiB0cnVlOwogfQogCg== --0000000000002bc69d05cecdb4c5--