From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D94843858D33 for ; Thu, 9 Nov 2023 23:07:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D94843858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D94843858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699571261; cv=none; b=B/R7eZaGigplVm88yBQgAtD/Sx7kpRDYxAksjgN6uV8N+rDuKuyUaW6SfX9+Bq6oZB1eBuk6SWTN/1ZfAFTEhvEE/FptleoL3naJERRpzAyWeO+y0Bm7oDOzIWS8F36gFwS+RkQ13F347TS4Mx7AIO6nbPBfoS2CaDqcPHS6Xjs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699571261; c=relaxed/simple; bh=zUJn1Ql8FAylPZvC8uxZkW90qeELQo1DzgRqaJfLcKM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=d6TihB4KwuY4kB07LlXMNYQa8pRsHQCYvlK2QrQ4F9a+9LnQVBQahLL1vqWfkf/07hNFAHFEF+38naDSQHVLAsmnb0Kvm3FYXMplFt6r/uD4faGOe1NrVYZA+NbpJRwOZpT4rBnT1Qui7u5uoKwYNCd1KurN+tHPf02Uey8qNkE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699571259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=COpQYxenDDMMa3rN8+lNIzCkGaPocMui/FBEbcnYNWM=; b=cBO5NgCkUS0mIX5+P/5bKbi4jGlWq28utEV4rEMd276UoQjiBgjcGxC7maFuukQH7j9ygR ediDfefk1+krXIUBGQKSUZzYD/RZnt3lWpjUWCPhSVkq/zrATIjN+/kWO5xuupwxinsi1X fn7nIe+yDqRL8Vdd/LuVloQglN6af4A= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-2c5WMXSrOsquLJ0ZpNNFZQ-1; Thu, 09 Nov 2023 18:07:38 -0500 X-MC-Unique: 2c5WMXSrOsquLJ0ZpNNFZQ-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-5a7be940fe1so20983237b3.2 for ; Thu, 09 Nov 2023 15:07:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699571258; x=1700176058; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=COpQYxenDDMMa3rN8+lNIzCkGaPocMui/FBEbcnYNWM=; b=fNRY3+N/WUg5UmG+08g/Pg/pdXJBCwzvagfXD2lkRkIlSv0dW6/VXcUrwUMGq+xi4G KdLr5+hjl5JUIAoLBem5vhtaM5FB3e3TzQg5x8Nxi2LoHLZkYkc1O612HjYNEDc7C6X3 mDQ5s2sOwe8xYpo5Yvl+ZWr9GlGa4JeYI+3/CFMgUKT0W4KRfWxEekcpNrF4FwwFZ7ma +KRBpiYLEoXq92tzYhzNmLfWDF/dStaYsmzWqUXBLvVo70+P4L0NlsnvJZm4Y/kuZwTG 5IJsGr5atV9qSPjzIxbyy6EI5aQM0zoKw906Z2Z6x/j5KY0H5Iw9SQRNbETxJVl6UpJh iKVA== X-Gm-Message-State: AOJu0YyFt8Pq66K9I8kyJpMiXzlUA6MpJlb6pZyhKJUw50aSZ58RaQis p08SCKssIbLSo9jr/UWV+yn1R1PLz5R3eLKtn5WG3NAhQHir6SglsnuZ4/7KtkM4/SG758u9diO cdhzii4nHRn0X0rFcKKg33XqQfvVbg8ILOw== X-Received: by 2002:a25:ad14:0:b0:d9b:4f28:4f7a with SMTP id y20-20020a25ad14000000b00d9b4f284f7amr6680900ybi.55.1699571257829; Thu, 09 Nov 2023 15:07:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHk/DNpxhu8P7/qwyTtJCeu1gUOoe6Qn6vmrkjSZRkkkwLMM3TvUbUhwFUaTL33GfxOzsrLRna6D4Cv3Oe2R0U= X-Received: by 2002:a25:ad14:0:b0:d9b:4f28:4f7a with SMTP id y20-20020a25ad14000000b00d9b4f284f7amr6680883ybi.55.1699571257561; Thu, 09 Nov 2023 15:07:37 -0800 (PST) MIME-Version: 1.0 References: <20231109193009.2391070-1-arsen@aarsen.me> In-Reply-To: <20231109193009.2391070-1-arsen@aarsen.me> From: Jonathan Wakely Date: Thu, 9 Nov 2023 23:07:26 +0000 Message-ID: Subject: Re: [PATCH 1/2] libstdc++: declare std::allocator in !HOSTED as an extension To: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 9 Nov 2023 at 19:32, Arsen Arsenovi=C4=87 wrote: > > This allows us to add features to freestanding which allow specifying > non-default allocators (generators, collections, ...) without having to > modify them. > > libstdc++-v3/ChangeLog: > > * include/bits/memoryfwd.h: Remove HOSTED check around allocator > and its specializations. > --- > Evening, > > This patch adds std::allocator as a declaration to freestanding, so that > it doesn't block various other bits of the library (such as collections > or the generators that I intend to send in soon) from being added to > freestanding anymore. > > I don't intend to pull in anything but into freestanding > in this release, though, so, this patch will have little impact for now. > > Testing on x86_64-pc-linux-gnu (the tests are not done yet, but I see no > relevant fails in previous test runs). The follow-up patch also marks a > new test as freestanding (as it was failing). > > OK for trunk? OK > > Have a lovely evening! > > libstdc++-v3/include/bits/memoryfwd.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libstdc++-v3/include/bits/memoryfwd.h b/libstdc++-v3/include= /bits/memoryfwd.h > index 330a6df7f44a..2b79cd8880a1 100644 > --- a/libstdc++-v3/include/bits/memoryfwd.h > +++ b/libstdc++-v3/include/bits/memoryfwd.h > @@ -60,13 +60,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > * @{ > */ > > -#if _GLIBCXX_HOSTED > + // Included in freestanding as a libstdc++ extension. > template > class allocator; > > template<> > class allocator; > -#endif > > #if __cplusplus >=3D 201103L > /// Declare uses_allocator so it can be specialized in `` etc. > -- > 2.42.1 >