From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3B3473858D3C for ; Fri, 2 Jun 2023 12:35:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B3473858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685709314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y+fY+nUOKSpMB33c1ydJ4dy85eYDHdr6GJhNjedZlzo=; b=T+/dKBlVTu3APsY90kF72CfGry4Ww2h7e3ROXkang6eBV+BkT3SqwWKOkfPIjrLbsW6c5W NnG9gsB+1ibVQaaALtn/T6AqaTYIlC2zJ4tJB+XobXpw0caQ0xwrG2BzHj9XCA26hnV20N v8x1lnfLw+wyL2atR7XCz1goJON1kg4= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-5yNNgqenMIeQdnJWE0QVWw-1; Fri, 02 Jun 2023 08:34:36 -0400 X-MC-Unique: 5yNNgqenMIeQdnJWE0QVWw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2b1acd44a31so5254891fa.0 for ; Fri, 02 Jun 2023 05:34:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685709269; x=1688301269; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y+fY+nUOKSpMB33c1ydJ4dy85eYDHdr6GJhNjedZlzo=; b=L3M4e+qD/jvyctZ58ij44m2zTqvc6dkG1AVbUWlQFFAusLKZWC/jYF8x0lVrZnYMdJ GCoNbrSKWjhuXZiFQotXDC+JN2PBWg49vOm7FUseYK30ycljupsm6/FL5yOw7ExV5pyB Lohoy7cYGuIC9EW7L7yiaPDvJ8KXF9yfPhNYeMIWZRo1Mr8qYmBvpf0k8b/K7ghbPGu4 rNoMm/MMGY3ND9H7g86HFmDcsdmMhMRC+cHBs0Cx/Y3kznJ/ETo1M67n1ckvmhpiE95+ UHmnbmzKukr5V9CFW/ThoQzqaqGFWZdBJUVV0wHpkVwVk/iNkGKccryFcmdgWk/zhqXq VWvw== X-Gm-Message-State: AC+VfDyOLWG4zILEqt8aXv1qczkei8+IRi2WVCs1gCF1cL0mIMLeLnyY SXhvSXP0wTo9NCHBMkSkNZ15zCJtLDmM9Arkz6AqnjFceuCSL8ZnuDP6SFIQ2e8R6piC0Z/o+N+ uVW6BuhIsIcJAsOTunjFAIVTjHlSC37OKbg== X-Received: by 2002:a2e:9d03:0:b0:2ac:85d7:342b with SMTP id t3-20020a2e9d03000000b002ac85d7342bmr1546245lji.29.1685709269207; Fri, 02 Jun 2023 05:34:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dnYQbQRiWGt7+7OD5mSazBN3l+oPX7UAdCwXt8TnaFjanoCNykW76CEFLyV5oEx3OHeevpqjtv32sMoK2UQU= X-Received: by 2002:a2e:9d03:0:b0:2ac:85d7:342b with SMTP id t3-20020a2e9d03000000b002ac85d7342bmr1546232lji.29.1685709268931; Fri, 02 Jun 2023 05:34:28 -0700 (PDT) MIME-Version: 1.0 References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> <8f43b613-f185-8e46-8fc6-02bc286125b5@gmail.com> <12cad432-888f-6db7-152a-89c5a17e4ac8@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 2 Jun 2023 13:34:17 +0100 Message-ID: Subject: Re: [PATCH] Move std::search into algobase.h To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , Rainer Orth , Jonathan Wakely via Gcc-patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000002b69f405fd24c621" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002b69f405fd24c621 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2 Jun 2023 at 12:30, Jonathan Wakely wrote: > > > On Fri, 2 Jun 2023 at 10:47, Fran=C3=A7ois Dumont = wrote: > >> Ok, push done. >> > > Thanks. > > >> Even after full rebuild those tests are still UNRESOLVED on my system. >> > What is the error in the log? > > What is your system? How and where did you install "OMP"? > > Does the libgomp directory exist in the GCC build tree, at the same level > as libstdc++-v3? > > e.g. in $objdir/x86_64-pc-linux-gnu/libgomp or equivalent? > > That directory should contain omp.h and .libs/libgomp.* which will be used > by the libstdc++ testsuite for the check-parallel target (see the > libgomp_flags variable which sets the paths to find libgomp in the build > tree). > > But because that test only runs for normal mode (not parallel mode) it > doesn't use libgomp_flags, and so it will only find omp.h if it already > exists in the compiler's default include paths, which will happen if you'= ve > already run "make install" on the GCC built with libgomp enabled. > > If you haven't enabled libgomp, or you haven't installed the new GCC yet, > then the __has_include() should fail, and so the test does nothing > and so should just PASS. If it's UNRESOLVED for you then that implies it's > finding an header, but probably not the one from GCC, so it fails > to compile. I think that's due to how you've installed "OMP" (whatever th= at > means ... I don't think you've installed libgomp and so I don't think you > should have done that ... maybe you installed Clang's libomp headers > instead and GCC is finding those somehow?) > Since we already have dg-require-parallel-mode that is used for most parallel mode tests, I don't think it's worth adding a new "openmp" effective-target just for these three tests. But it would be helpful if I added this comment to them instead: --- a/libstdc++-v3/testsuite/17_intro/headers/c++2014/parallel_mode.cc +++ b/libstdc++-v3/testsuite/17_intro/headers/c++2014/parallel_mode.cc @@ -19,6 +19,12 @@ // { dg-do compile { target c++14 } } // { dg-require-normal-mode "" } +// In order to improve coverage this test is run by the normal 'make check' +// target, not only the infrequently-tested check-parallel target. That means +// the makefile variable $(libgomp_flags) is not used, so the libgomp files +// in the build tree will not be found. The parallel mode headers will only +// be able to include if libgomp has already been installed to the +// $prefix of the GCC being tested, so use __has_include to fail gracefully. #if __has_include() # define _GLIBCXX_PARALLEL 1 # include Or we could just remove those tests and ensure that somebody runs 'make check-parallel' at least once every six months. N.B. running 'make check-parallel' would have found the problem with the missing #include in , even without an installed libgomp. --0000000000002b69f405fd24c621--