From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 130633858C20 for ; Thu, 10 Mar 2022 14:27:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 130633858C20 Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-294-d98qhiJwOYWHUR-L4aLPoQ-1; Thu, 10 Mar 2022 09:27:55 -0500 X-MC-Unique: d98qhiJwOYWHUR-L4aLPoQ-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-2dc58f5a95bso42111217b3.9 for ; Thu, 10 Mar 2022 06:27:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DsXmuG2a01BHU5uyhjXZESIlK3WUOwtsuKPNAjdsTiY=; b=ulbELmpHQWV/p+OtXWZdFG+it2f0abPUCxJWKUYDlBbeBnzz96PLUNmdEXEfKUvkgn fYF12ay+xbMVNfltclgg6BpSX5utZ3lKeOxxoHbnYA60xN9ZMdb2A265v9OBX5bR9eGS vQEJK+rU87Da0f1X//v7Si9U8Hz9vfLv6FukXAkPthNVzkn0ZSzay95KfiTXjYEsAndK 7R1ljkJFojk3s4OvHHTRmMzqczlPejitwrLTucDhbYkRVWyLUrVKlItfCBCREFkZOdJj RAPkyiqmEcTo6YN+l1VYp74yv2GKi2kgEx1MrPSZ1V8x4fxi80MwGnx6PuQdOHnD612v yrtA== X-Gm-Message-State: AOAM532aBj1YNEdNhJWO532eRGlyKlqXA8tcvwqWYwrGs6+bMtTMZbSW LyDVJuqwsKBk1TBtzh/nzY6azxXoncm6BCuCcmkcUeX6lVeWOsrTU59WVEKQnnVQiFei9ydBfaX +fr9eh7lJsUiiZpPTWe+bNU7zaQ36Pc702Q== X-Received: by 2002:a25:7182:0:b0:629:4c53:c56b with SMTP id m124-20020a257182000000b006294c53c56bmr4258337ybc.168.1646922474910; Thu, 10 Mar 2022 06:27:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGi99UGxjYZo3khGhPPCIufVyHj1XKQA5o5hmzzhI0khLBQ+cCze+DhbRcJr7Ci6qM3d1HeOfnTWEeHqj8PxA= X-Received: by 2002:a25:7182:0:b0:629:4c53:c56b with SMTP id m124-20020a257182000000b006294c53c56bmr4258309ybc.168.1646922474614; Thu, 10 Mar 2022 06:27:54 -0800 (PST) MIME-Version: 1.0 References: <20220310115116.1716777-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 10 Mar 2022 14:27:43 +0000 Message-ID: Subject: Re: [committed] libstdc++: Support VAX floats in std::strong_order To: Jonathan Wakely Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000012c32805d9de05ea" X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 14:27:59 -0000 --00000000000012c32805d9de05ea Content-Type: text/plain; charset="UTF-8" On Thu, 10 Mar 2022 at 12:16, Jonathan Wakely wrote: > > On Thu, 10 Mar 2022 at 11:53, Jonathan Wakely via Libstdc++ > wrote: > > > > Tested x86_64-linux, and basic soundness check on vax-dec-netbsdelf. > > But apparently not enough of a soundness check, because > isnan(__builtin_nan("")) is true for VAX, so GCC seems to have a NaN > pattern, despite what I read online about the format. > > Fix on the way ... Here's the fix that adds support for VAX NaN (and works around PR104865 which I discovered while trying to make this work). Tested x86_64-linux, and slightly tested on vax-dec-netbsdelf again. Pushed to trunk. --00000000000012c32805d9de05ea Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0l33tzf0 Y29tbWl0IDczZjNiOGE1M2U2NjY0YzA3OTczMWMyYTE4M2MxNjYyMTQ4MWQwMzkKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBUaHUgTWFyIDEwIDE0 OjE3OjAzIDIwMjIKCiAgICBsaWJzdGRjKys6IEZpeCBzdGQ6OnN0cm9uZ19vcmRlciB0byBoYW5k bGUgTmFOIG9uIFZBWAogICAgCiAgICBJIG1pc3Rha2VubHkgYmVsaWV2ZWQgdGhhdCBWQVggZmxv YXRzIGRvIG5vdCBzdXBwb3J0IE5hTiwgYnV0IHdpdGggR0NDCiAgICBfX2J1aWx0aW5faXNuYW4o X19idWlsdGluX25hbigiIikpIGlzIHRydWUuIFRoYXQgbWVhbnMgbXkgcHJldmlvdXMKICAgIGNo YW5nZSB0byA8Y29tcGFyZT4gaXMgd3JvbmcsIGJlY2F1c2UgaXQgZmFpbHMgdG8gaGFuZGxlIE5h Ti4KICAgIAogICAgV2hlbiBzdGQ6Om51bWVyaWNfbGltaXRzPGZsb2F0aW5nLXBvaW50LXR5cGU+ Ojppc19pZWM1NTkgaXMgZmFsc2UsIGFzIG9uCiAgICBWQVgsIHRoZSBzdGFuZGFyZCBvbmx5IHJl cXVpcmVzIGFuIG9yZGVyaW5nIHRoYXQgaXMgY29uc2lzdGVudCB3aXRoIHRoZQogICAgb3JkZXJp bmcgb2JzZXJ2ZWQgYnkgY29tcGFyaXNvbiBvcGVyYXRvcnMuIFdpdGggdGhpcyBjaGFuZ2UgdGhl IG9yZGVyaW5nCiAgICBpcyAtTmFOIDwgbnVtYmVycyA8ICtOYU4sIGFuZCB0aGVyZSBpcyBubyBz dXBwb3J0IGZvciBkaWZmZXJlbnQgTmFOIGJpdAogICAgcGF0dGVybnMgKGFzIEknbSBub3QgZXZl biBzdXJlIGlmIEdDQyBzdXBwb3J0cyBhbnkgZm9yIFZBWCkuCiAgICAKICAgIGxpYnN0ZGMrKy12 My9DaGFuZ2VMb2c6CiAgICAKICAgICAgICAgICAgKiBsaWJzdXBjKysvY29tcGFyZSAoX1N0cm9u Z19vcmRlcjo6X1NfZnBfY21wKSBbX192YXhfX106CiAgICAgICAgICAgIEhhbmRsZSBOYU4uCgpk aWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL2xpYnN1cGMrKy9jb21wYXJlIGIvbGlic3RkYysrLXYz L2xpYnN1cGMrKy9jb21wYXJlCmluZGV4IDNjMjJkOWFkZGYxLi42ZTFlZDUzZWVlZCAxMDA2NDQK LS0tIGEvbGlic3RkYysrLXYzL2xpYnN1cGMrKy9jb21wYXJlCisrKyBiL2xpYnN0ZGMrKy12My9s aWJzdXBjKysvY29tcGFyZQpAQCAtODQ0LDggKzg0NCwxNiBAQCBuYW1lc3BhY2Ugc3RkCiAJX1Nf ZnBfY21wKF9UcCBfX3gsIF9UcCBfX3kpIG5vZXhjZXB0CiAJewogI2lmZGVmIF9fdmF4X18KLQkg IC8vIFZBWCBmb3JtYXQgaGFzIG5vIE5hTiwgb25seSAiZXhjZXNzIiBmb3IgSW5mLCBzbyB0b3Rh bGx5IG9yZGVyZWQuCi0JICByZXR1cm4gX19idWlsdGluX2JpdF9jYXN0KHN0cm9uZ19vcmRlcmlu ZywgX194IDw9PiBfX3kpOworCSAgaWYgKF9fYnVpbHRpbl9pc25hbihfX3gpIHx8IF9fYnVpbHRp bl9pc25hbihfX3kpKQorCSAgICB7CisJICAgICAgaW50IF9faXggPSAoYm9vbCkgX19idWlsdGlu X2lzbmFuKF9feCk7CisJICAgICAgaW50IF9faXkgPSAoYm9vbCkgX19idWlsdGluX2lzbmFuKF9f eSk7CisJICAgICAgX19peCAqPSBfX2J1aWx0aW5fc2lnbmJpdChfX3gpID8gLTEgOiAxOworCSAg ICAgIF9faXkgKj0gX19idWlsdGluX3NpZ25iaXQoX195KSA/IC0xIDogMTsKKwkgICAgICByZXR1 cm4gX19peCA8PT4gX19peTsKKwkgICAgfQorCSAgZWxzZQorCSAgICByZXR1cm4gX19idWlsdGlu X2JpdF9jYXN0KHN0cm9uZ19vcmRlcmluZywgX194IDw9PiBfX3kpOwogI2VuZGlmCiAKIAkgIGF1 dG8gX19peCA9IF9TX2ZwX2JpdHMoX194KTsK --00000000000012c32805d9de05ea--