From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BD805385AC24 for ; Tue, 6 Sep 2022 11:12:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD805385AC24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662462752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y+ciIfw/b1/T5r1yOy5ao68wJCwb3qMj4S+MPXVLyvU=; b=XMWhelCPvZcfxlYxJCVGfSFQyZR4IJY0UroFooF7AD7rsxocRIG4NugUznEC5Rb4nLufMl Y9zXwNNtVTqnCqx2ZFnicwHEvsIznjMSQ3u1pW1R8+r6KYb05Qnb5AgEabYLsrE9F+7KKE /pQIRXfGZrgoqjsAn7Q+KYcmWMCwRcQ= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-538-rqCJZUrJOfK5ZDo7n09MyA-1; Tue, 06 Sep 2022 07:12:30 -0400 X-MC-Unique: rqCJZUrJOfK5ZDo7n09MyA-1 Received: by mail-qv1-f70.google.com with SMTP id og5-20020a056214428500b00496b5246db5so7530658qvb.10 for ; Tue, 06 Sep 2022 04:12:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=y+ciIfw/b1/T5r1yOy5ao68wJCwb3qMj4S+MPXVLyvU=; b=0nPW77XSMzhhUyHQwX+FWDGA6aXhMkiIfnXEWXSHvolRyMtOq8FsRLjkcFTfpudEYw qw7W66Vb0jEiVtgja9XrsXb4/mYR7GXnN//I3dB4Ao32O0rkveC8MqWE6GC1ZyiTZt4G HHWMB1+coGvhZEcAA/F8IzRPvA80g10YExpvStxEO4IYgti/3320DmIcWyIVk/La3pLQ d81ETP0KoB1bzlDDm52foEM6NuKIe3o0EyZH18CFzhKMnRVSx2jm0O3w37oOGhBmowDj ZANNCNYtqCpbJOoyvYbMvfbdQCTH+zvCWQbx6IdETqZW7uAze6WzZUVw3QYNzKNzNz3Y ypQQ== X-Gm-Message-State: ACgBeo01wrSQgcMW7AOe3i+7RDr4GLgU7kmAHVQlLC5sdMc6BJMtXhVI CZVC8LuvzXRpzF8EGSw0BcxMkN38LY7Rnnc0NCzYPlqi6qK/dNgSH0eg2w/hbOLQEOsTg8WJ+uY UQ0xCLJ7LTJuzDCwzvoLHikVBxQhwKyyp3Q== X-Received: by 2002:a05:6214:2a84:b0:476:feb2:f436 with SMTP id jr4-20020a0562142a8400b00476feb2f436mr43789179qvb.43.1662462749716; Tue, 06 Sep 2022 04:12:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR5gEOV+/4V4dYNtr/pJXXBBNAP8QZhs0/xQQgX7nDhAwQnxflk07UZw1lR/hDR36NxkCMcuNI2+KUyQlmGXlvY= X-Received: by 2002:a05:6214:2a84:b0:476:feb2:f436 with SMTP id jr4-20020a0562142a8400b00476feb2f436mr43789158qvb.43.1662462749453; Tue, 06 Sep 2022 04:12:29 -0700 (PDT) MIME-Version: 1.0 References: <20220904184735.177348-1-fent@in.tum.de> In-Reply-To: From: Jonathan Wakely Date: Tue, 6 Sep 2022 12:12:18 +0100 Message-ID: Subject: Re: [PATCH 1/2] libstdc++: Fix pretty printer tests of tuple indexes To: Will Hawkins Cc: Philipp Fent , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 6 Sept 2022 at 02:07, Will Hawkins wrote: > > Confirming that patch 1 of 2 *does* fix the failing tests here (x86-64). > > Will > > PS: Please tell me if emails like this are helpful or not. Just trying to help! Thanks. I wasn't even seeing the failing tests, due to errors from GDB: Dwarf Error: wrong version in compilation unit header (is 5, should be 2, 3, or 4) [in module /home/jwakely/build/powerpc64le-unknown-linux-gnu/lib stdc++-v3/testsuite/cxx11.exe This meant they were UNSUPPORTED on my test machine. I've pushed Philipp's [PATCH 1/2] now. Thank you both. > > On Sun, Sep 4, 2022 at 2:48 PM Philipp Fent via Libstdc++ > wrote: > > > > Signed-off-by: Philipp Fent > > --- > > libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc | 2 +- > > libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc b/libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc > > index cc91803e247..af335d0d3c7 100644 > > --- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc > > +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc > > @@ -29,7 +29,7 @@ main() > > // { dg-final { note-test t1 {empty std::tuple} } } > > > > std::tuple> t2{ "Johnny", 5, {} }; > > -// { dg-final { regexp-test t2 {std::tuple containing = {\[1\] = "Johnny", \[2\] = 5, \[3\] = empty std::tuple}} } } > > +// { dg-final { regexp-test t2 {std::tuple containing = {\[0\] = "Johnny", \[1\] = 5, \[2\] = empty std::tuple}} } } > > > > std::cout << "\n"; > > return 0; // Mark SPOT > > diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc > > index f97640a0189..bc5978ee69d 100644 > > --- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc > > +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc > > @@ -166,9 +166,9 @@ main() > > // { dg-final { note-test runiq_ptr {std::unique_ptr = {get() = 0x0}} } } > > > > ExTuple tpl(6,7); > > -// { dg-final { note-test tpl {std::tuple containing = {[1] = 6, [2] = 7}} } } > > +// { dg-final { note-test tpl {std::tuple containing = {[0] = 6, [1] = 7}} } } > > ExTuple &rtpl = tpl; > > -// { dg-final { note-test rtpl {std::tuple containing = {[1] = 6, [2] = 7}} } } > > +// { dg-final { note-test rtpl {std::tuple containing = {[0] = 6, [1] = 7}} } } > > > > std::error_code e0; > > // { dg-final { note-test e0 {std::error_code = { }} } } > > -- > > 2.37.3 > > >