From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2C746385841E for ; Tue, 21 Mar 2023 16:42:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C746385841E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679416971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zYXIMCSb1v+8vgjkp2eiGjbalbJ3Fa5IJpmoLJ3hLBo=; b=HmM/q3KcjlmCby7eifdVJqlT6LKN0v5Wnp54B8SasVHlWLHkkOVJbefY0W9Rk/NZenRJAr Sr3kL4i5twTOhveXsxZ1U/DbGZL5m/k4fexVyqi9Z460ePskyfpV+g4/NH1IB8gPGnSJU0 bU+0fTJENYkA2zgQHvFsC2ehIplUlLI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-MoISZfAcPN6eu7M36Bcs8A-1; Tue, 21 Mar 2023 12:42:50 -0400 X-MC-Unique: MoISZfAcPN6eu7M36Bcs8A-1 Received: by mail-lj1-f199.google.com with SMTP id be36-20020a05651c172400b00295aa1d0db6so4286040ljb.21 for ; Tue, 21 Mar 2023 09:42:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679416969; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zYXIMCSb1v+8vgjkp2eiGjbalbJ3Fa5IJpmoLJ3hLBo=; b=aTaf4kFuUshOsd82RRymmPxmlLmllpWRCNFhejZBHt9rZalRYUSe6VpBLlMlJ6KiNt PvCok+xD3f2PqBMxe2GSyf7aL0r4yLBL4nmirwbfjYmB6tUiagsEV2xsjReSz43Xfcw7 PvPWbRwmtZL6pM9NIYo2E3PuErDb16vHI61rEKoZpUvvC5BTbgMSuuoIcWFcKeIVwt3x sN2aJzA/aHqRpIhNiGVqyESgzvj3NWgFcg1rqQqgNhMgpi79RTlqIICnxMECBsYtrYqQ zzc2GWVNcnZYmIDi24Ao40AtUvpOJnTFQL94sINwS7oK8qf97HUfLCTybCmxjkeDCxTh UW1g== X-Gm-Message-State: AO0yUKVCApRvobVICwfArArR3JDUCnaTlmXctifbvHy6gSnjwN3o6HlE 4BRl2w9k59RDGUNPcVQm6TGRbllHQxnUIUu9BVhQmCQrUXjpihSM/mHxaKFzStfqVkc5MsAwBe1 0aChthhSRy2s87QpIrpHoy/nSTWOmoVfcAw== X-Received: by 2002:a2e:9402:0:b0:298:8ac5:da28 with SMTP id i2-20020a2e9402000000b002988ac5da28mr1043878ljh.9.1679416969065; Tue, 21 Mar 2023 09:42:49 -0700 (PDT) X-Google-Smtp-Source: AK7set8KZLsTfteplUkA+2QYYl8cL4G+TwAatfGP5S5N5B9tM8uAPqGemuhaWKjdlt9SBDaPipChgLQbnokJUhxFVHw= X-Received: by 2002:a2e:9402:0:b0:298:8ac5:da28 with SMTP id i2-20020a2e9402000000b002988ac5da28mr1043867ljh.9.1679416968701; Tue, 21 Mar 2023 09:42:48 -0700 (PDT) MIME-Version: 1.0 References: <20230321163949.1950-1-kmatsui@cs.washington.edu> In-Reply-To: <20230321163949.1950-1-kmatsui@cs.washington.edu> From: Jonathan Wakely Date: Tue, 21 Mar 2023 16:42:37 +0000 Message-ID: Subject: Re: [PATCH 1/2] c++: implement __is_unsigned built-in trait To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, ppalka@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000d9785205f76bbbb6" X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d9785205f76bbbb6 Content-Type: text/plain; charset="UTF-8" On Tue, 21 Mar 2023 at 16:40, Ken Matsui via Libstdc++ < libstdc++@gcc.gnu.org> wrote: > This patch implements built-in trait for std::is_unsigned. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_unsigned. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_UNSIGNED. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_unsigned. > * g++.dg/ext/is_unsigned.C: New test. > --- > gcc/cp/constraint.cc | 3 ++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 +++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++ > gcc/testsuite/g++.dg/ext/is_unsigned.C | 46 ++++++++++++++++++++++++ > 5 files changed, 57 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_unsigned.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 273d15ab097..bc4c3d3ec57 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3747,6 +3747,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_UNION: > inform (loc, " %qT is not a union", t1); > break; > + case CPTK_IS_UNSIGNED: > + inform (loc, " %qT is not an unsigned type", t1); > + break; > case CPTK_IS_AGGREGATE: > inform (loc, " %qT is not an aggregate", t1); > break; > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index bac593c0094..9f1fff9043e 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, > "__is_trivially_assignable", 2) > DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, > "__is_trivially_constructible", -1) > DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) > DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > +DEFTRAIT_EXPR (IS_UNSIGNED, "__is_unsigned", 1) > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, > "__reference_constructs_from_temporary", 2) > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, > "__reference_converts_from_temporary", 2) > /* FIXME Added space to avoid direct usage in GCC 13. */ > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 87c2e8a7111..d43e2543490 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12031,6 +12031,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, > tree type2) > case CPTK_IS_UNION: > return type_code1 == UNION_TYPE; > > + case CPTK_IS_UNSIGNED: > + return TYPE_UNSIGNED (type1); > + > case CPTK_IS_ASSIGNABLE: > return is_xible (MODIFY_EXPR, type1, type2); > > @@ -12200,6 +12203,7 @@ finish_trait_expr (location_t loc, cp_trait_kind > kind, tree type1, tree type2) > case CPTK_IS_ENUM: > case CPTK_IS_UNION: > case CPTK_IS_SAME: > + case CPTK_IS_UNSIGNED: > break; > > case CPTK_IS_LAYOUT_COMPATIBLE: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index f343e153e56..20bf8e6cad5 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -146,3 +146,6 @@ > #if !__has_builtin (__remove_cvref) > # error "__has_builtin (__remove_cvref) failed" > #endif > +#if !__has_builtin (__is_unsigned) > +# error "__has_builtin (__is_unsigned) failed" > +#endif > diff --git a/gcc/testsuite/g++.dg/ext/is_unsigned.C > b/gcc/testsuite/g++.dg/ext/is_unsigned.C > new file mode 100644 > index 00000000000..02ab9f4d5f2 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_unsigned.C > @@ -0,0 +1,46 @@ > +// { dg-do compile { target c++11 } } > + > +#include > + > +using namespace __gnu_test; > + > +#define SA(X) static_assert((X),#X) > +#define SA_TEST_CATEGORY(TRAIT, X, expect) \ > + SA(TRAIT(X) == expect); \ > + SA(TRAIT(const X) == expect); \ > + SA(TRAIT(volatile X) == expect); \ > + SA(TRAIT(const volatile X) == expect) > + > +SA_TEST_CATEGORY(__is_unsigned, void, false); > + > +SA_TEST_CATEGORY(__is_unsigned, char, (char(-1) > char(0))); > +SA_TEST_CATEGORY(__is_unsigned, signed char, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned char, true); > +SA_TEST_CATEGORY(__is_unsigned, wchar_t, (wchar_t(-1) > wchar_t(0))); > +SA_TEST_CATEGORY(__is_unsigned, short, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned short, true); > +SA_TEST_CATEGORY(__is_unsigned, int, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned int, true); > +SA_TEST_CATEGORY(__is_unsigned, long, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned long, true); > +SA_TEST_CATEGORY(__is_unsigned, long long, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned long long, true); > Please add a check with bool. > + > +SA_TEST_CATEGORY(__is_unsigned, float, false); > +SA_TEST_CATEGORY(__is_unsigned, double, false); > +SA_TEST_CATEGORY(__is_unsigned, long double, false); > + > +#ifndef __STRICT_ANSI__ > +// GNU Extensions. > +#ifdef __SIZEOF_INT128__ > +SA_TEST_CATEGORY(__is_unsigned, unsigned __int128, true); > +SA_TEST_CATEGORY(__is_unsigned, __int128, false); > +#endif > + > +#ifdef _GLIBCXX_USE_FLOAT128 > +SA_TEST_CATEGORY(__is_unsigned, __float128, false); > +#endif > +#endif > + > +// Sanity check. > +SA_TEST_CATEGORY(__is_unsigned, ClassType, false); > -- > 2.40.0 > > --000000000000d9785205f76bbbb6--