public inbox for
 help / color / mirror / Atom feed
From: Jonathan Wakely <>
To: "Charles-François Natali" <>
Subject: Re: [PING 2] [PATCH] libstdc++: basic_filebuf: don't flush more often than necessary.
Date: Thu, 6 Oct 2022 17:55:53 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 6 Oct 2022 at 17:33, Charles-François Natali
<> wrote:
> On Thu, Oct 6, 2022, 14:29 Jonathan Wakely <> wrote:
>> Sorry for the lack of review. I've been trying to remember (and find)
>> some previous discussions related to this topic, but haven't managed
>> to find it yet.
> No worries!
>> The patch does look sensible (and is the same as the one attached to
>> PR 63746) so I'll make sure to review it in time for the GCC 13
>> cut-off.
>> I noticed that you contributed your test case with a FSF copyright
>> assignment header. Do you actually have a copyright assignment for GCC
>> contributions? If not, you would either need to complete that
>> paperwork with the FSF, or alternatively just contribute under the DCO
>> terms instead:
> I actually just copy-pasted the header from another test, would it be simpler if i just removed it?

Yes, that's probably the simplest solution, and then add a
Signed-off-by: tag in your patch email, to state you're contributing
it under the DCO terms (assuming of course that you are willing and
able to certify those terms).

  reply	other threads:[~2022-10-06 16:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05 22:50 Charles-Francois Natali
2022-09-22 16:51 ` [PING] " Charles-François Natali
2022-10-06 13:23   ` [PING 2] " Charles-François Natali
2022-10-06 13:29     ` Jonathan Wakely
2022-10-06 16:33       ` Charles-François Natali
2022-10-06 16:55         ` Jonathan Wakely [this message]
2022-10-11  7:15           ` Charles-François Natali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).