From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3C45E3858C2D for ; Tue, 21 Mar 2023 16:44:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C45E3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679417080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=faSAnZSYrVlTy7nm8o7JBY9WKmuleSQeI/KCc8zeHro=; b=Hl6YHFQeadrUyLCzmAtH9Nel0CpTfOwu6+rUPiePGr5sRFoiFLdzhxkJZR2v8n2siRin5d dPq6gTyCqb7opToX8Lp+BGM5HULbDQHL8rv3VPwbRNf6oWn4pxgNfC8nUYocWFhWaTfaT6 2+DZdH1VcUgpZ7WFyighj9Lx5hbkX3U= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-xBCGT-DKM3ejVGaF1lE25Q-1; Tue, 21 Mar 2023 12:44:39 -0400 X-MC-Unique: xBCGT-DKM3ejVGaF1lE25Q-1 Received: by mail-lf1-f72.google.com with SMTP id k7-20020ac257c7000000b004db20d1cf7fso5723061lfo.18 for ; Tue, 21 Mar 2023 09:44:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679417077; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=faSAnZSYrVlTy7nm8o7JBY9WKmuleSQeI/KCc8zeHro=; b=AAtfo0Sn75iv63TjiCKhtnoAlaPyNFoLTcq23BHt1SjsX26sJfwd5j5GwurKjCOOTQ lARlwOwd3W9K75/JimPGjuYrYzeoxGUxJFfIBfMcZWGq6lK2ycMMGbfy0SVTrvyq5dLy pKax+CNSiDx4R/1HZxOzfG0YyR+UbHNPtyJ+kTB6Re/OSI/7cDiEiDatyv67fBwcDi82 AO7VY2JfHLaPtWRpaAZae9TY9/+xLoawcceAQw37gATxPt8fQiA/VSr0jGZM+IUYzDG+ V4kwCj41tYxeabUsrhBx9H9Lt45dOUK8hbTWd9+L30Jg3ELyPD9SjoSxdTsartUaPvDt tAZQ== X-Gm-Message-State: AO0yUKVEcTvW010YHw+zhVRFLi0Ijk1EugB70VowAMBSXsBdNTAZhkGK RtZ20mSyTjW6SgC2g34HgGLDo8XOAd7UfS8z1ab2deMyvaAZX2Co5ETPix2O6vM0V7AaFlRjwA3 Jj/LomeYycoz3RJZSxHpTAvvHI+/qYnxsdA== X-Received: by 2002:a05:6512:905:b0:4d5:ca32:6ed8 with SMTP id e5-20020a056512090500b004d5ca326ed8mr1166236lft.6.1679417077715; Tue, 21 Mar 2023 09:44:37 -0700 (PDT) X-Google-Smtp-Source: AK7set9n7172trCq0dznQLUmPDmhVpvAImRSeVJ2OBy9WdW/9vZc/x6wtCct1iASvigEDD/iSkaYurYhV8dMsLbmcPA= X-Received: by 2002:a05:6512:905:b0:4d5:ca32:6ed8 with SMTP id e5-20020a056512090500b004d5ca326ed8mr1166225lft.6.1679417077430; Tue, 21 Mar 2023 09:44:37 -0700 (PDT) MIME-Version: 1.0 References: <20230321163949.1950-1-kmatsui@cs.washington.edu> <20230321163949.1950-2-kmatsui@cs.washington.edu> In-Reply-To: <20230321163949.1950-2-kmatsui@cs.washington.edu> From: Jonathan Wakely Date: Tue, 21 Mar 2023 16:44:26 +0000 Message-ID: Subject: Re: [PATCH 2/2] libstdc++: use new built-in trait __is_unsigned To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, ppalka@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000054904305f76bc265" X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000054904305f76bc265 Content-Type: text/plain; charset="UTF-8" On Tue, 21 Mar 2023 at 16:41, Ken Matsui via Libstdc++ < libstdc++@gcc.gnu.org> wrote: > This patch lets libstdc++ use new built-in trait __is_unsigned. > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_unsigned): Use __is_unsigned > built-in trait. > Please wrap the ChangeLog entry to less than 80 columns (including 8 for the leading tab). > --- > libstdc++-v3/include/std/type_traits | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/libstdc++-v3/include/std/type_traits > b/libstdc++-v3/include/std/type_traits > index 2bd607a8b8f..8d5a05cd0a6 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -884,10 +884,17 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > { }; > > /// is_unsigned > +#if __has_builtin(__is_unsigned) > + template > + struct is_unsigned > + : public __bool_constant<__is_unsigned(_Tp)> > + { }; > +#else > template > struct is_unsigned > : public __and_, __not_>>::type > { }; > +#endif > Thanks, I expect this trait to make a much bigger difference than add_const, so I'm very happy to see this one! > > /// @cond undocumented > template > -- > 2.40.0 > > --00000000000054904305f76bc265--