From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E86673857C50 for ; Fri, 16 Feb 2024 15:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E86673857C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E86673857C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708096544; cv=none; b=Z7Pk1vXhY21aiXGCYWAoRSjmLWxf4YB1cnTrGFbcJnHlkt+FqDva8UrJK5zMPYSFK1H1B3hA/tVtY8ywX7Ac/m6opcF0gptvgq26WsHiUQD3vVazXbnMd6uh+XTP7DAfAaVKVqD05eGnsErlN3eOqcJUqPrS6E3nW2tmUc6Pb4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708096544; c=relaxed/simple; bh=J8hG02ek9301XdlKCvuyyWy/G6fxg8RuxLvMuoN7hPc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=PHIGfRAhPv6klv/tNcZe+yvCs/mk4/1wlxMVvZlMOPlgYsR76Oo4WejE9ltCG1NQ1m3vqvme53liavSLKt4u0xMtp6niEf+tKiv0OvqOeJQGUvj99RIE3sgREz8/62g/hk4I1GucWceg6+1R7FbfuOoN6WePBdoO8opD0PHjPnU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708096542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J8hG02ek9301XdlKCvuyyWy/G6fxg8RuxLvMuoN7hPc=; b=iCilLI3OwZSwET8Xp765RTC+538hUjojptRo3AiCTRFb7Uefq/Enk/c4S/J3bGCyde4dNF 6DSvGK9JXdyUhwa4qnjIRh/eI8jFxiFFV92Ydh1Xyi6+SQUwa9QEwIAlQ2jJxmDQ0mZG+B YfgjwfGn24S+5WHM1WjACa9KTwR0kU4= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120-s10AxYcSM92lsng7SRBw5g-1; Fri, 16 Feb 2024 10:15:41 -0500 X-MC-Unique: s10AxYcSM92lsng7SRBw5g-1 Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-36424431577so7164835ab.3 for ; Fri, 16 Feb 2024 07:15:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708096540; x=1708701340; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J8hG02ek9301XdlKCvuyyWy/G6fxg8RuxLvMuoN7hPc=; b=oYrLsUry69t/Ptq+pxamVC+5Z7um3vH5uMPOlC6i6AobS3ixr5ZpIsZoR7cD7W2cb5 0IZ9/K11pAzsLlolGlgMv7n5UyI3FRlTn724ISczPS8kol9fruov+Uw2MS+bwqYR9UZG miCl5J+kltOirn7jSNqaR+UvF0tOccYuOP0DvQu3YO8YZCEM0bovnIqWkxlgvq4KOz+9 31XZ4S0KRBFhdL48pTh0V/8VEb6edBdQMzJ9D/YdjYPl5NRQX9lmUycTsQK5qNcfLzAs 1Pd1wWi+9uEDh/DEmyOrLo2E3M3yI32yeHNpDE3VErphDq5NVoR9P9ssnu0oEny5ESnl mU7Q== X-Forwarded-Encrypted: i=1; AJvYcCWypxHmR7NpQhhk9V/DhSZCyVm4q4sTf4Rr3s6hveegH3rxxM9pDNxyJQB6YFCRBi3sRjFkxPGoa9S14RFcZadtUV2bbUQMKg== X-Gm-Message-State: AOJu0YyD9Hkbsf4sIAtUw4nasFpHfAmv44gVfwjv4oOU64gSOrlYGLB0 wSM0o36PlPTl6t9qw6p3Yx1/MtctyMmDioOI2kLsnbk1EsM3nPBtmDtXZZF18NtxWzYjYoq7PlE 23cIyTzzp4HFdPqwtqcT9iKgxLMCQoU0WJjq+TBW+hfpJZ2zd2YV4mnfURHMGjzFudgWaXUyAU0 SOdDPyy3+UkhEs+9pITU4APquYKlnGMg== X-Received: by 2002:a92:cb02:0:b0:363:bde2:152f with SMTP id s2-20020a92cb02000000b00363bde2152fmr5058737ilo.24.1708096540671; Fri, 16 Feb 2024 07:15:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3wo1vIcDWDA9860pWI31t9DdbE4RqyZ31ahm++FWG7HxQyKCvdbhm9MVDLybxnLxN5m+HCXTjsRLUM9t/T8Y= X-Received: by 2002:a92:cb02:0:b0:363:bde2:152f with SMTP id s2-20020a92cb02000000b00363bde2152fmr5058717ilo.24.1708096540408; Fri, 16 Feb 2024 07:15:40 -0800 (PST) MIME-Version: 1.0 References: <9f2bdd3a973d98199bb5b322baa575ab2fba8a58.camel@xry111.site> In-Reply-To: From: Jonathan Wakely Date: Fri, 16 Feb 2024 15:15:24 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: atomic: Add missing clear_padding in __atomic_float constructor To: Jakub Jelinek Cc: xndcn , Xi Ruoyao , "H.J. Lu" , GCC Patches , libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-15.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 16 Feb 2024 at 14:10, Jakub Jelinek wrote: > > On Fri, Feb 16, 2024 at 01:51:54PM +0000, Jonathan Wakely wrote: > > Ah, although __atomic_compare_exchange only takes pointers, the > > compiler replaces that with a call to __atomic_compare_exchange_n > > which takes the newval by value, which presumably uses an 80-bit FP > > register and so the padding bits become indeterminate again. > > __atomic_compare_exchange_n only works with integers, so I guess > it is doing VIEW_CONVERT_EXPR (aka union-style type punning) on the > argument. > > Do you have preprocessed source for the testcase? Sent offlist.