From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 494B53858407 for ; Tue, 4 Oct 2022 11:38:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 494B53858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664883491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hNYKid4BWFSp0bM5SLqe8eSjRp5TVknJwvPnh0+cs9U=; b=M15pyKyYDNzSHV+bG2XpfHwJe23SlCiNmmRnOnZJNZjxYJ5wRHg6QZT/ncqHAZHvFHYZHd NjcqeKSoD+BqzPGME/gVvOj9phYbq2gKhuWoC4sj69nuBcLJxB7kwbNW1coAoMTUkyGjtg RrcQ0Pw02lj174cI9mhKY0VkwrLTp4Q= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-182-52S2aAdZP-SsnKSON8O-rw-1; Tue, 04 Oct 2022 07:38:10 -0400 X-MC-Unique: 52S2aAdZP-SsnKSON8O-rw-1 Received: by mail-qt1-f198.google.com with SMTP id n16-20020ac85b50000000b0035ce9e26eb1so9023947qtw.8 for ; Tue, 04 Oct 2022 04:38:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=hNYKid4BWFSp0bM5SLqe8eSjRp5TVknJwvPnh0+cs9U=; b=zjhZand/oJcFin6GT2Rhi8o/MGphzZAQ3SHyYrAvcTuRNTHpf6dZ+HfwD5QDR3GFs3 L7vIR87b/qCtReKFnoWC/Sphaw3s9wejo7Y3NIfNs/pTX31fAV5rygtOB2NNUPJ9TMwv CjXqjqFdfZz1JRKeH+hK2rBVR7ic7Bs5xnQctLo6kcAIZwM8BtgDOS+U3ApwoPZCM/tf FppOjXVaZYZkU7Rl2B3Sx+SjngbC9yKSsBNfkCsLG47k3J+E301oSoQSya0J1Fzwy6xy ed6R9Lm8ZL8NxwZw1usyR0LDebxdT9NWSeFEDCVuvaV1rx/kOJ8QS3DzFwdgNNSv6E59 zVzw== X-Gm-Message-State: ACrzQf1iFXWaKaPpJuPYAfWvBobBgipwAGmOqFDY7GSqXyKkaDbpI9Qq LLT6lQxsxzUHLLWUc6EkIXE0rqCleRJegQLZKaUawUkelJs3iCZeFh22sXP0dEPdMq+1GkjHRzJ jhfqMm4PtheoUwrTu8FZzA57oOngIJ1guMw== X-Received: by 2002:a05:620a:4483:b0:6ce:8e57:254b with SMTP id x3-20020a05620a448300b006ce8e57254bmr16301731qkp.540.1664883489631; Tue, 04 Oct 2022 04:38:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4lETraZyLP/Tp+ESoeZ9gpGUFfHH32iHadmGGbmy6CKq4jTBHBb3uqmAHHPOj8eOUg9TelaSGnoFdvoa2YnnY= X-Received: by 2002:a05:620a:4483:b0:6ce:8e57:254b with SMTP id x3-20020a05620a448300b006ce8e57254bmr16301721qkp.540.1664883489423; Tue, 04 Oct 2022 04:38:09 -0700 (PDT) MIME-Version: 1.0 References: <20221004011115.2009591-1-ppalka@redhat.com> In-Reply-To: <20221004011115.2009591-1-ppalka@redhat.com> From: Jonathan Wakely Date: Tue, 4 Oct 2022 12:37:58 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Implement ranges::join_with_view from P2441R2 To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 4 Oct 2022 at 02:11, Patrick Palka via Libstdc++ wrote: > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? FWIW using OK, thanks. > variant<_PatternIter, _InnerIter> in the implementation means we need to > include from , which increases the preprocessed size > of by 3% (51.5k vs 53k). I suppose that's an acceptable cost? Yeah, I don't think we want to reimplement a lightweight std::variant, because that would just add even more code. As I mentioned on IRC, maybe we could optimize the compilation time for some of the visitation using P2637R0, but that can be done later.