public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
	libstdc++ <libstdc++@gcc.gnu.org>,
	gcc-patches@gcc.gnu.org, nathan@acm.org
Subject: Re: [PATCH] testsuite: Windows paths use \ and not /
Date: Fri, 30 Sep 2022 19:07:11 +0100	[thread overview]
Message-ID: <CACb0b4kU_tM7CyGqqMNytN5kjyw+_x-joHQLUT-xgS65xmaPfw@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4=eT-4Ks0uAZHOxZSeeSahy6rXnBsWVz9b5EEN05XYwzQ@mail.gmail.com>

On Fri, 30 Sept 2022 at 19:04, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On Fri, 30 Sept 2022 at 18:55, Jakub Jelinek <jakub@redhat.com> wrote:
> >
> > On Fri, Sep 30, 2022 at 06:47:07PM +0100, Jonathan Wakely via Gcc-patches wrote:
> > > On Fri, 30 Sept 2022 at 17:26, Jonathan Wakely wrote:
> > > >
> > > > On Fri, 30 Sept 2022 at 17:04, Torbjörn SVENSSON
> > > > <torbjorn.svensson@foss.st.com> wrote:
> > > > >
> > > > > libstdc++-v3/testsuite:
> > > > >
> > > > >         * 20_util/bind/ref_neg.cc: Prune Windows paths too.
> > > >
> > > > Please CC the libstdc++ for libstdc++ patches.
> > > >
> > > > OK for trunk, thanks.
> > >
> > > I'm seeing errors now on x86_64-linux:
> > >
> > > ERROR: 20_util/bind/ref_neg.cc: unknown dg option: /\\ for "
> > > dg-prune-output 53 "[/\\](functional|bits/invoke.h):" "
> > >
> > > ERROR: 20_util/bind/ref_neg.cc: unknown dg option: /\\ for "
> > > dg-prune-output 53 "[/\\](functional|bits/invoke.h):" "
> >
> > Bet it should be
> > // { dg-prune-output "\[/\\](functional|bits\[/\\]invoke.h):" }
> > or so.  Completely untested.
>
> That fixes the error, but now the regex doesn't match so there are
> still excess errors. It needs to be:
>
> // { dg-prune-output ".*\[/\\](functional|bits\[/\\]invoke.h):.*" }
>
> Without any regex special characters, there's an implicit .* before
> and after the pattern. But when you use any regex special characters
> in the pattern, it stops working. I can't remember why. I figured it
> out once.

It looks like just adding .* at the start is enough:

// { dg-prune-output ".*\[/\\](functional|bits\[/\\]invoke.h):" }

But that's so ugly, I'm tempted to replace that prune with something different.


  reply	other threads:[~2022-09-30 18:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30 15:38 Torbjörn SVENSSON
2022-09-30 16:26 ` Jonathan Wakely
2022-09-30 17:47   ` Jonathan Wakely
2022-09-30 17:55     ` Jakub Jelinek
2022-09-30 18:04       ` Jonathan Wakely
2022-09-30 18:07         ` Jonathan Wakely [this message]
2022-09-30 18:12           ` Jonathan Wakely
2022-09-30 21:07             ` Jonathan Wakely
2022-10-01 11:02               ` Torbjorn SVENSSON
2022-09-30 18:23         ` Andreas Schwab
2022-10-25 15:15 Torbjörn SVENSSON

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACb0b4kU_tM7CyGqqMNytN5kjyw+_x-joHQLUT-xgS65xmaPfw@mail.gmail.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=nathan@acm.org \
    --cc=torbjorn.svensson@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).