From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 296293858031 for ; Fri, 1 Sep 2023 11:16:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 296293858031 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693567016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tOPuVg2c61ubfiqlCWEFWY1J9rRrlallPuZw/IEh9oM=; b=dkciv5sKSIjUhH9AFX1IYma6d3seTv5BrAAPWfEmnMkvpZzhS+AG1Ktv8RRlvPwMWhWOA8 QSjBcWcH9oTbcAOGOM5d44qUcHk6e4pUdK8K3oqIts6EVtWBZ8e6x5d1W0UCSW/NXBaKLm vmPCDE8+QbYcv5O7ulhgWcA6SyhUp4s= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-fE66TlfdPEOauuFxJjz7ew-1; Fri, 01 Sep 2023 07:16:53 -0400 X-MC-Unique: fE66TlfdPEOauuFxJjz7ew-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2bcfdad9d56so12975071fa.0 for ; Fri, 01 Sep 2023 04:16:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693567012; x=1694171812; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tOPuVg2c61ubfiqlCWEFWY1J9rRrlallPuZw/IEh9oM=; b=AxVc9eiqXMzDfBkT66wbC/w6W9hZslO0/i58jIPxU+8K58QHstap9vpkN79Lzn2gfG zb1w40uxnH+IsXQdV6UgMe8uYfgnGTo5lK/ov3zD9rzOowKwq+vnitsN54wIMK8rjQ8u N3BUeLZrBFEm9FDMIRTVMxr86D8p6OIq+S0F9QsmAkQPjHSLMLl0WPG99/PSLpAH0Zw9 8/aq1wINa2I8QklkLLLsfCCQKa/A06SId+bhG8OPyVOhCbGjr4ajefPyCJb0UktJZBb8 FniG21TOjcJJz18vjomGJ6Jy+bgFs1/2w0ntaFdGt2gXNjLBWQVF3/5XJ1P6Z8uHTDur PY4w== X-Gm-Message-State: AOJu0YywT2iyWUuhfN9HzpdUh0n9I/elsXM89iG9gho/naJxsBLRJbMQ fcHUmUrJO/FZkIqmPaKOpgJXVlaCr5ziExQV0PRduFjrOehZrlbD6HExvNOloKCk6fJTcgin1ya EK1CaLu10jp4scHPCsDVXrtMYtgVqM/NmxQ== X-Received: by 2002:a2e:a606:0:b0:2bb:7710:f08 with SMTP id v6-20020a2ea606000000b002bb77100f08mr1879370ljp.3.1693567012254; Fri, 01 Sep 2023 04:16:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwpi2DSOG03GtnMkTL9I64JeQPciKdmVebkbjiiRD4fpX78lzEsWIBP0PZKMZ7u/NUW1fa1aSggJyBYd92JYM= X-Received: by 2002:a2e:a606:0:b0:2bb:7710:f08 with SMTP id v6-20020a2ea606000000b002bb77100f08mr1879360ljp.3.1693567011952; Fri, 01 Sep 2023 04:16:51 -0700 (PDT) MIME-Version: 1.0 References: <20230823160322.237140-1-jwakely@redhat.com> In-Reply-To: <20230823160322.237140-1-jwakely@redhat.com> From: Jonathan Wakely Date: Fri, 1 Sep 2023 12:16:40 +0100 Message-ID: Subject: Re: [RFC] libstdc++: Make --enable-libstdcxx-backtrace=auto default to yes To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 23 Aug 2023 at 17:03, Jonathan Wakely via Libstdc++ wrote: > > Any objections to this? It's a C++23 feture, so should be enabled by > default. I've pushed this to trunk, so let's see what breaks! > > -- >8 -- > > This causes libstdc++_libbacktrace.a to be built by default. This might > fail on some targets, in which case we can make the 'auto' choice expand > to either 'yes' or 'no' depending on the target. > > libstdc++-v3/ChangeLog: > > * acinclude.m4 (GLIBCXX_ENABLE_BACKTRACE): Default to yes. > * configure: Regenerate. > --- > libstdc++-v3/acinclude.m4 | 2 +- > libstdc++-v3/configure | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 > index b25378eaace..50c808c6b2d 100644 > --- a/libstdc++-v3/acinclude.m4 > +++ b/libstdc++-v3/acinclude.m4 > @@ -5481,7 +5481,7 @@ BACKTRACE_CPPFLAGS="$BACKTRACE_CPPFLAGS -DBACKTRACE_ELF_SIZE=$elfsize" > > AC_MSG_CHECKING([whether to build libbacktrace support]) > if test "$enable_libstdcxx_backtrace" = "auto"; then > - enable_libstdcxx_backtrace=no > + enable_libstdcxx_backtrace=yes > fi > AC_MSG_RESULT($enable_libstdcxx_backtrace) > if test "$enable_libstdcxx_backtrace" = "yes"; then >