From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A54413858D28 for ; Wed, 12 Apr 2023 15:04:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A54413858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681311867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dfZWkALz4HioMsR3zY8cF0FHIeKgQrYskFn14GFpE28=; b=WtfqQaz1OFeBh8Wkkah84XZp6utVwXWZser1HmDalhzETYtwFp7cQ0+UuM+mO2KbQXc6lB wfOw9aYRE+huQAD8Qv9MKlAmvL6PEmvtFpUevwLZ3vPD4JTFARs84oa74nkySyItSbtsz1 RZPlvcBDdxOdgFqm7B/dmghYZzekkCo= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-_WLJRAuKM3-VlMuAQ0USqQ-1; Wed, 12 Apr 2023 11:04:25 -0400 X-MC-Unique: _WLJRAuKM3-VlMuAQ0USqQ-1 Received: by mail-lf1-f69.google.com with SMTP id t20-20020a199114000000b004e9609a300cso4708352lfd.2 for ; Wed, 12 Apr 2023 08:04:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681311859; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dfZWkALz4HioMsR3zY8cF0FHIeKgQrYskFn14GFpE28=; b=3DHGn5sO4dAB3RJp82xdAFNjOZgl12V4SqIbIC/Yftf3tkuqyD/Ed8mVKpsqIwo+o/ LKqs8DCU+c9FvuhiEbZ6xKSMCF9S7hB55lYx+L9hu2iCzb2zJeJn7Rr4D+VgIqwKqDyM 98qs7UGdP1iBXWGPV0/4yLsKRR9hUOABhmPmYMNTimdqK3ahya/g8Hte8WScgg+cFZk/ EsZH2CJTg8HhPZBUBcugyQKjI9mEDqDBm9hs6rEIVYY+0JtUiFw3pcy0AXld7WWueUFP JNzT3IxQMh+YtLRV1zdBUU4RlayjzpH6KBoJ1xdm0UHJobORXr29KhKqKQvEwN2YoY5X cARA== X-Gm-Message-State: AAQBX9dCGJkK5PPnhxxpDTFsAr9t7PH2/KgF4K29I/sneeLjAkelcPBz PPWX7yII2f3RCH1GTAuBlFpS9jdxIn59ied+0daQ/yrROYuqKaJeRHQSxbdULgULggp/fK2Mx1/ asfnkxi0o7VonvmGCF6SFY36IPuUkrC2k0g== X-Received: by 2002:ac2:4d15:0:b0:4e9:d7b3:97a6 with SMTP id r21-20020ac24d15000000b004e9d7b397a6mr4262391lfi.8.1681311859565; Wed, 12 Apr 2023 08:04:19 -0700 (PDT) X-Google-Smtp-Source: AKy350YhNeSe5M5UpUuIh79Nonr+OdVX1c+QgUgez3T9VzSoylyTqZfj0VjWs/XXoVLDw9yHFR2XohuE2n1Po5pxXlA= X-Received: by 2002:ac2:4d15:0:b0:4e9:d7b3:97a6 with SMTP id r21-20020ac24d15000000b004e9d7b397a6mr4262381lfi.8.1681311859168; Wed, 12 Apr 2023 08:04:19 -0700 (PDT) MIME-Version: 1.0 References: <20230412134502.3147419-1-ppalka@redhat.com> In-Reply-To: <20230412134502.3147419-1-ppalka@redhat.com> From: Jonathan Wakely Date: Wed, 12 Apr 2023 16:04:11 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Ensure headers used by fast_float are included To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 12 Apr 2023 at 14:45, Patrick Palka via Libstdc++ wrote: > > This makes floating_from_chars.cc explicitly include all headers > that are used by the original fast_float amalgamation according to > r12-6647-gf5c8b82512f9d3, except: > > 1. since fast_float doesn't seem to use anything from it > 2. since fast_float doesn't seem to use anything directly > from it (as opposed to from ) > 3. since std::errc is naturally already available > from > > This avoids potential build failures on platforms for which some > required headers (namely ) end up not getting transitively > included from elsewhere. > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/12? Yes for both, thanks. > > libstdc++-v3/ChangeLog: > > * src/c++17/floating_from_chars.cc: Include , > , and . > --- > libstdc++-v3/src/c++17/floating_from_chars.cc | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libstdc++-v3/src/c++17/floating_from_chars.cc b/libstdc++-v3/src/c++17/floating_from_chars.cc > index 5d18ca32dbb..3a411cf546a 100644 > --- a/libstdc++-v3/src/c++17/floating_from_chars.cc > +++ b/libstdc++-v3/src/c++17/floating_from_chars.cc > @@ -30,14 +30,18 @@ > // Prefer to use std::pmr::string if possible, which requires the cxx11 ABI. > #define _GLIBCXX_USE_CXX11_ABI 1 > > +#include > #include > #include > #include > +#include > +#include > #include > #include > #include > #include > #include > +#include > #include > #include > #include > -- > 2.40.0.315.g0607f793cb >