From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5CDF93855141 for ; Mon, 28 Nov 2022 10:11:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5CDF93855141 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669630280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bqltcwiijo0WpkgPukbcgmczoCWsGn8MUGWeF1el1KM=; b=NnE2m/YEnVWtEEqFYqgePNdKUvNxO+xqCSbHvBRfFxUVZGMLd8NlTB7UyVmGt+O+7uoa6p Q2af5ERAWVfHlBX+iQ2aU4iJ7GDjM+Jx3Gnabu/bmCyO6a+XLUGvCGyjUulGipEvPaOZhZ /S0udCJWVoy0cX9lV/gk7ue3vnv2J8k= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-661-YcOOJB7ZMU6fcAixIYKiJA-1; Mon, 28 Nov 2022 05:11:09 -0500 X-MC-Unique: YcOOJB7ZMU6fcAixIYKiJA-1 Received: by mail-ej1-f71.google.com with SMTP id qa14-20020a170907868e00b007ae24f77742so4033809ejc.8 for ; Mon, 28 Nov 2022 02:11:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bqltcwiijo0WpkgPukbcgmczoCWsGn8MUGWeF1el1KM=; b=VGSRuqnzPiV+KVLrif00CrPSXcLpIyCwbK+N3rpeyGS0iCGzkS1UeGuVM93McF1l/a 1tEkpnT9uOQQI3ST4knFhsdoit6Oohv0XMe+TXTahFWlf9ky65xC/30dR9iG6ILLYdE8 rv/zHwdhIgMczIPLD+FhxP5d0HywDGQdfrUxdz7aYeAozzFaWujz1JW7YS+v+ftuU579 NqqTlegCm3Jtz0Gf24vvqZJVT/7SnuhxLMWPlq3Mos3D7N0MGw4ImO35xEP7EIAjIOn5 7ca2AjU/IHDe5cg1ALNmPwlxOpDkxKvnN2Zgvfj+iLga15Q1lpNG1Fxidtyn9funisL4 dgoQ== X-Gm-Message-State: ANoB5pmo77NHWOJY27nCSceQLdf/ErhfI/ceQoeTLzpQEke17GPNxGCM laUpzyepMMUGqxRB63b4h9Sl+RVUACUjTyfr0Zhm7CH+bo4NNVnno7dA/yIq4AT+wQ1oueNxtBO f/vQBcrPQKfABpEoEC/7ZYmVu+ZDn8ugXaQ== X-Received: by 2002:a17:906:5f85:b0:7bc:6bb7:41c1 with SMTP id a5-20020a1709065f8500b007bc6bb741c1mr13447997eju.353.1669630268786; Mon, 28 Nov 2022 02:11:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf6IWJhXZZBzwuPORRr/nxP+bB49mCBQopsJyfrYOukWVLL3Z0Wc382uLAnw1oxFhVhO5VYMhiVvT40PnXV7lkg= X-Received: by 2002:a17:906:5f85:b0:7bc:6bb7:41c1 with SMTP id a5-20020a1709065f8500b007bc6bb741c1mr13447990eju.353.1669630268652; Mon, 28 Nov 2022 02:11:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 28 Nov 2022 10:10:58 +0000 Message-ID: Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Adapt to_chars/from_chars symbols To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000011d26d05ee8517bd" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000011d26d05ee8517bd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 28 Nov 2022 at 06:07, Fran=C3=A7ois Dumont via Libstdc++ < libstdc++@gcc.gnu.org> wrote: > This patch is fixing those tests: > > 20_util/to_chars/float128_c++23.cc > std/format/formatter/requirements.cc > std/format/functions/format.cc > std/format/functions/format_to_n.cc > std/format/functions/size.cc > std/format/functions/vformat_to.cc > std/format/string.cc > > Note that symbols used in for __ibm128 and __iee128 are untested. > > I even wonder if the normal mode ones are because I cannot find the > symbols used in gnu.ver. > > > libstdc++: [_GLIBCXX_INLINE_VERSION] Add to_chars/from_chars > symbols export > > libstdc++-v3/ChangeLog > > * include/std/format [_GLIBCXX_INLINE_VERSION](to_chars): > Adapt __asm symbol > specifications. > * config/abi/pre/gnu-versioned-namespace.ver: Add > to_chars/from_chars symbols > export. > > Ok to commit ? > > Why are changes needed to the linker script? Those functions should already match the general wildcard: # Names inside the 'extern' block are demangled names. extern "C++" { std::*; std::__8::*; }; --00000000000011d26d05ee8517bd--