From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9B2213858D32 for ; Fri, 3 Nov 2023 09:13:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B2213858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B2213858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699002788; cv=none; b=nGMqgXkBFw8UWbuAYcq5axwNS+8oRzjKJ00/lBPrgkRQNzzGq3rTynpDorJGmI+ttwdOFpMywUScocf5MFghTV2YSudPkxCZ4g6TAGwG2bFmkNQVlpVIRZevlzH6692/MW8rHcdjKyGjmd1kQ0CjUowitMMfwqNpDlozb0SNM74= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699002788; c=relaxed/simple; bh=y0aY24hqV7xrPFq1X4wQePkavlSGlRJuasFVp5lFJbY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=txJCPiHukba4gpln+o0qTMuhUZbaPrfq9XpyFgdIpSlSEtJuEnmr42fTh8oxc3UGcBGyqs1cUcbnY7LmOqU8BoZduMVKfgO8RkRtWNCZTXxcJJSpwwFGJKcL0FDOz4SQ2EqUDOFB32rCZ/PbRZ4YR3FHigjoeu3uNS3TyhyJV3Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699002787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gISuTdzOB5dTAgPFTSMXQJEw1g+bQVhPpcdbM49GfNA=; b=Yb1DdQb15LH/l36u4gCq+7XSTDxb7azTBSx4GQuSiheX0njKIMhhlFU15f06G0suZ50SjB qTFoNvQJ7oNeJNHM0eQ7T6hX5N2SvRIb8ezQjTWUimkwzP8DcKnVrPyyB2I59U2Vgw8wsf cwCbSHi6MzZogDwkq1vQ5ugk3mYgAdk= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-8UbLr79jNFCkqI6ohccWSg-1; Fri, 03 Nov 2023 05:13:05 -0400 X-MC-Unique: 8UbLr79jNFCkqI6ohccWSg-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5a7c97d5d5aso26285667b3.3 for ; Fri, 03 Nov 2023 02:13:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699002785; x=1699607585; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gISuTdzOB5dTAgPFTSMXQJEw1g+bQVhPpcdbM49GfNA=; b=Xn0IZr9OsKz6v7fVdDtbxkoXSgedWd2POVZMrra4cgUcj1AB8qmJwf0DOIGNpmHofQ F0TQ5jn00KzT92VZSOffR0rJMH9LYNxX0zZmPyGGALOnjz7KQlGoYg5sQALUmb663U1u n+TE/BPbWXlERQrAD9VL5EC56B8b/WXE68kSOYtwoFRzSjZfC4wYIFxBgn9TPAEgyNMu w+tpB2c5U5a/0zZD16T+gIeRaYMLF0CBjg0DXddV719SdCk81CEy1OY8vGm/QbalYBoS 6DB8RT9hw3VdsoR2cy9xxvNJUGXCBz/aCZHyh/pXh265G/4pOQP6MlKRuJXrWjoGm3fy hJ/w== X-Gm-Message-State: AOJu0YyDafXIF0097K6pmZMzK41o2XtoJ5JFP2f/EQutMnzQn14yzaBU asU0/xD52cFhhJRqpBamh4Ly88ZYczmFtiR1urm+K7dBVEqc0cIyAvKx1wMKBjTde3nB6dx9IlJ exDEbcBkVbd22/sNgooNi5KbQQEkbspoHiQ== X-Received: by 2002:a0d:e8c3:0:b0:59b:14ca:4316 with SMTP id r186-20020a0de8c3000000b0059b14ca4316mr2264699ywe.43.1699002785355; Fri, 03 Nov 2023 02:13:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEYS7x30l7eFWPrrOT93gisInFWIvnrtwku4GwrG2uJ+sAnKckF9pOCgnuMkjXv3xWzXMyDRJg/LVHmOJjiQA= X-Received: by 2002:a0d:e8c3:0:b0:59b:14ca:4316 with SMTP id r186-20020a0de8c3000000b0059b14ca4316mr2264691ywe.43.1699002785124; Fri, 03 Nov 2023 02:13:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Fri, 3 Nov 2023 09:12:54 +0000 Message-ID: Subject: Re: libstdc++ patch RFA: Fix dl_iterate_phdr configury for libbacktrace To: Ian Lance Taylor Cc: gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 3 Nov 2023 at 03:04, Ian Lance Taylor wrote: > > The libbacktrace sources, as used by libstdc++-v3, fail to correctly > determine whether the system supports dl_iterate_phdr. The issue is > that the libbacktrace configure assumes that _GNU_SOURCE is defined > during compilation, but the libstdc++-v3 configure does not do that. > This configury failure is the cause of PR 112263. > > This patch fixes the problem. OK for mainline? Thanks for figuring this one out, I forget toabout _GNU_SOURCE often, because g++ defines it automatically. OK for mainline and gcc-13 and gcc-12, thanks! > > Ian > > PR libbacktrace/112263 > * acinclude.m4: Set -D_GNU_SOURCE in BACKTRACE_CPPFLAGS and when > grepping link.h for dl_iterate_phdr. > * configure: Regenerate.