From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C81483856633 for ; Wed, 7 Jun 2023 15:55:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C81483856633 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686153351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qi9ilzOXHaZhmLWRx4FC24eZBVTex3p5fLJ8aF6+V/k=; b=Q/9jzWFJDdm/ljcGfkNXIIV1BPVdVTPEI2v4yGXXnPJZzNAUHAC0zV130K+72AvxgCcCDU 21inWgp8jBpeBVMB3J397/nPjHhXq1GLTX1+hVW4V1TQvoYutKQ9xvSpaMpaCYR7UrKBVH ZwFAcAS2M7Sfq0RguPFmz6300IHYB04= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-50-nEBcsNDXPfG3L7LoWVbZzw-1; Wed, 07 Jun 2023 11:55:48 -0400 X-MC-Unique: nEBcsNDXPfG3L7LoWVbZzw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4edc5526c5fso4819037e87.2 for ; Wed, 07 Jun 2023 08:55:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686153346; x=1688745346; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qi9ilzOXHaZhmLWRx4FC24eZBVTex3p5fLJ8aF6+V/k=; b=NWvTn3+NVOfaVMmbCQ6+d9OKziUO5NkfpqUwBwEvohKkprdHD1UOA9ZeYX5Y4X+J6D nIcXRc2H+NOVjJp2YpSWEKvGVhFaICHNhjydsOO7f4/TW90CPUSdwh/RgkhYPNiU7QxF fLrAMWgV2wE5ru1E7k4y5dnz9apk+hlEX7CFpfuLpTEBlvztwSsOHjK0Sb+itCp7V8ec L/76lokCeN6t1EVJgfIHsqSsQ7jJAa9gHZwcQeSjAGZK6P8O1OBZ4eAPMC6W3JSQ3Vv9 eJyqkWi4RHzllhDFO0eRwd8SmjHwd5YAkhZsG39m+0vfLAnzwI1OjRxudPYcvGRWDui2 iytA== X-Gm-Message-State: AC+VfDw1wFxxal8doY82ZlotTTAGNCppmHjRNQrU4RYaAa5vjp3tI/FC h8uuPvoANsobHimmOkQSqIlxpPOdxI5XRqJcZ8qXcaE/LUnPvrWmINLS7Cpg9bLmUE2te0K8jCw alUVEmNFQSZYrqD+8uQOmzFfR2F5j73oheg== X-Received: by 2002:ac2:596e:0:b0:4f4:b3eb:80f8 with SMTP id h14-20020ac2596e000000b004f4b3eb80f8mr2470740lfp.3.1686153346679; Wed, 07 Jun 2023 08:55:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ611arqgm5RGwGXOMid7Ud5NlVhDfYTvIYCkug6TsCzAz9wH7heRzTCNOOb3R+ah/upAvadmuQ6QNTv1J/IaOo= X-Received: by 2002:ac2:596e:0:b0:4f4:b3eb:80f8 with SMTP id h14-20020ac2596e000000b004f4b3eb80f8mr2470733lfp.3.1686153346366; Wed, 07 Jun 2023 08:55:46 -0700 (PDT) MIME-Version: 1.0 References: <20230606155947.1242056-1-jwakely@redhat.com> <9fe98c5b-0013-2364-9b79-3c5f92dcf117@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 7 Jun 2023 16:55:34 +0100 Message-ID: Subject: Re: [committed] libstdc++: Update list of known symbol versions for abi-check To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000003f593705fd8c2bd0" X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003f593705fd8c2bd0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 7 Jun 2023 at 09:06, Jonathan Wakely wrote: > On Wed, 7 Jun 2023 at 05:43, Fran=C3=A7ois Dumont wrote: > >> >> On 06/06/2023 17:59, Jonathan Wakely via Libstdc++ wrote: >> > Tested x86_64-linux and powerpc64le-linux. Pushed to trunk. >> > >> > -- >8 -- >> > >> > Add the recently added CXXABI_1.3.15 version. Also remove two "frozen" >> > versions from the latestp list, as no more symbols should be added to >> > those now. >> > >> > libstdc++-v3/ChangeLog: >> > >> > * testsuite/util/testsuite_abi.cc (check_version): Add >> > CXXABI_1.3.15 symver and make it the latestp. Remove >> > GLIBCXX_IEEE128_3.4.31 and GLIBCXX_LDBL_3.4.31 from latestp. >> > --- >> > libstdc++-v3/testsuite/util/testsuite_abi.cc | 7 ++----- >> > 1 file changed, 2 insertions(+), 5 deletions(-) >> > >> > diff --git a/libstdc++-v3/testsuite/util/testsuite_abi.cc >> b/libstdc++-v3/testsuite/util/testsuite_abi.cc >> > index cea6c217433..59615dd701e 100644 >> > --- a/libstdc++-v3/testsuite/util/testsuite_abi.cc >> > +++ b/libstdc++-v3/testsuite/util/testsuite_abi.cc >> > @@ -233,7 +233,7 @@ check_version(symbol& test, bool added) >> > known_versions.push_back("CXXABI_1.3.11"); >> > known_versions.push_back("CXXABI_1.3.12"); >> > known_versions.push_back("CXXABI_1.3.13"); >> > - known_versions.push_back("CXXABI_1.3.14"); >> > + known_versions.push_back("CXXABI_1.3.15"); >> >> Did you really want to remove CXXABI_1.3.14 here ? ChangeLog says you >> just add CXXABI_1.3.15. >> > > Oops, yes! Thanks for spotting that. I'll fix it today. > > Fixed at r14-1613-gb6235dbcfc3143, thanks again. The abi-check test didn't fail because all symbols in the CXXABI_1.3.14 version are already in the baseline_symbols.txt file, so none of them is compared to the list of known_versions. That meant it didn't matter that CXXABI_1.3.14 wasn't in the known versions. --0000000000003f593705fd8c2bd0--