From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E260F3858429 for ; Wed, 20 Mar 2024 09:03:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E260F3858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E260F3858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710925410; cv=none; b=WwggASeBS7ko+p1N5j6sQlcuUfyZTa6/MV/t1w/mb3enbi4PZOuiaRSnCPXRBMayhwAFKWI8h+zVyGHtFZ/YAifTi2RFrs1z+QIlHLOszruIRqgitSr4UQK2LLCU3KRADL5v7KJuPv82kiRgt3clqE+aXcdsVQhyS+t5goNmmBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710925410; c=relaxed/simple; bh=r8wOrCUMgDj34SvIzoIwqsIlnvRe1PhQjzfzNGpeMyU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=SbhPtjycdbmC+jtXV/qe0SWIazJryP0++WGcGIC2hcCUduLYwKdayUqAoNbVBS2evbnm0WLKzJZ9eiloc8FUKgJBz9lM0U3tdn+9i0gcqHT9EKrWUvR9Mt185ZPbhAtU6mW+jo8GA14rdRRu47nEeD+bWSLpIgL5nTr1BEeNvEQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710925399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wzGRdiTS+rcJjez2/7+5F2Z7l5kOLYjfMsfpWTypqgM=; b=iahSDH/3cyvy6ZL84MNrUMjmi5kd6386xQJz51xORH3nxr/s3/p4ohYmQtPqlV+YKouItn 6O4m5yNb6FhXjZr9B+gmbBqK/a6+taPEXoqBOTztwtUdQK2i6t77jyjoZzALIlleSY7Tb9 ztkoXsLyDK+5N7aet8npHwilKzfJG/o= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-YeWwd8okNJWknqzvAsGfwA-1; Wed, 20 Mar 2024 05:02:48 -0400 X-MC-Unique: YeWwd8okNJWknqzvAsGfwA-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-60a20c33f06so101789967b3.2 for ; Wed, 20 Mar 2024 02:02:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710925368; x=1711530168; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wzGRdiTS+rcJjez2/7+5F2Z7l5kOLYjfMsfpWTypqgM=; b=nVowLZqhtj6sENkitlNEiMvdPqt/uj2MVqgg/VToWD2HUnyktXs6lRp0fonoumQo7W YIIEVwcCJttksJ8y+QD1eLPhm+q71Dz0v7Lu7G2Iipdu9tYkVZ9U57++URYFMwZ3q0Yl XyAhf2Ibxs9sX4S2o0rERz9S9cn8dmq1CpEQc2wVgemccRG3SuTodJZD5AoSl5fz5qQW /ZU3Hw5Sjm0Y6dt8xZUoIxAUEAcZkfEnHh5C+dkQAbYrCPAtnw1zgBffRraoKsmBJpod BjUAxClUlbys38AjYR6OOvWmbG/2U+8Y6ArXOLrwcdDRwmOpDmX6f1MUSQXT8pfOf+eB UTKA== X-Forwarded-Encrypted: i=1; AJvYcCWND2o3rOhjyO8FlNwhddBgkvzJZTsBpqVVX7c4XrGlZVWX1P2QhnOeJKP+g5ox8SGnYwujr8jp12bMAXSulwi0fGu2JDt3hA== X-Gm-Message-State: AOJu0Yw5bco0NlN0mfOv9r3E3/wwqcz6hvVijaU+vqiiGrlIo0DdXyD9 mFgLQTJkqwJcWi2ssUBh74bZjlimSkRjMTVHqPMHoKVeZcapADg1fAhCKovab/Mz65LmEyac7Km 82R22LqQKw3BVhuZsjJysL9VNigyQG2nTVa6HiEDgkFS/UV/8xcgc/kjMd8zTTbitYwG/DzODeX nLC2Kg6KkvHK1+1HZBzGklnDi2V0zGHg== X-Received: by 2002:a0d:f086:0:b0:608:b7d6:753f with SMTP id z128-20020a0df086000000b00608b7d6753fmr17631582ywe.33.1710925368069; Wed, 20 Mar 2024 02:02:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyz/Q9i1Ieuw8pLW9iDr+bDR2nTQgteB6gDzFtyp0/xRnfzZ/lVI8Xgz4O0NHP3rEl6EM+5NZuzlC50pLa8Dc= X-Received: by 2002:a0d:f086:0:b0:608:b7d6:753f with SMTP id z128-20020a0df086000000b00608b7d6753fmr17631579ywe.33.1710925367840; Wed, 20 Mar 2024 02:02:47 -0700 (PDT) MIME-Version: 1.0 References: <73AC0523-2237-46FD-9885-7AE3F8663DF2@gmail.com> <28CE4FD1-FFB0-4300-81CA-C3CB07E436A6@gmail.com> <19f5939a-9341-4237-90d9-4f1279f03a88@gmail.com> <2f29d2f2-a21b-42bb-997f-3918935d0dba@gmail.com> <4374668e-f7e9-4912-a8e6-a50710999d4b@gmail.com> <114c9cc7-6990-48be-87b9-b8ac02015531@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 20 Mar 2024 09:02:31 +0000 Message-ID: Subject: Re: _LIBCXX_DEBUG value initialized singular iterators assert failures in std algorithms [PR104316] To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 20 Mar 2024 at 05:59, Fran=C3=A7ois Dumont wrote: > > Thanks to you doc: > > libstdc++: [_GLIBCXX_DEBUG] Define __[glibcxx,cpp_lib]_null_iterator= s > > _GLIBCXX_DEBUG has now fully N3344 compliant iterator checks, we > can define > __glibcxx_null_iterators and __cpp_lib_null_iterators macros like > the normal > mode. > > libstdc++-v3/ChangeLog: > > * version.def (null_iterators): Remove extra_cond. > * version.h: Regenerate. > > Ok to commit ? Please don't bother talking about __glibcxx_null_iterators in the commit message, that's an implementation detail that always mirrors the standard-defined __cpp_lib_null_iterators one. The first line of the commit will be much easier to read without that. OK with that change, thanks. > I already noticed that GCC 13 has no version.h file so no backport questi= on. It has no version.h but it still has the macros: include/std/iterator:# define __cpp_lib_null_iterators 201304L include/std/version:# define __cpp_lib_null_iterators 201304L Those definitions can be made to not depend on _GLIBCXX_DEBUG.