From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 994693858D35 for ; Mon, 11 Oct 2021 21:04:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 994693858D35 Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-fvrN-eu7PO2echedXuidgw-1; Mon, 11 Oct 2021 17:04:14 -0400 X-MC-Unique: fvrN-eu7PO2echedXuidgw-1 Received: by mail-vk1-f200.google.com with SMTP id 199-20020a1f02d0000000b002a303be5f5eso4023759vkc.8 for ; Mon, 11 Oct 2021 14:04:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BgxUCnqHg2eK50CWNtFvZ8T/mUmAL7fFbaQ0KL9dcnE=; b=qmLXKS5/Sjn/PBLlz6wYWZz7A7KP8eEmwYTrESQfs2+FAnfzarO5THAy9fP2u1+4GF mcUQjHJJzL889q6yTdbbzFO3Fa9fR70clVo/0k3FLZD9aGZ182+6adsEIHbwcCyLgxP1 yeZmPgmBLCvqpwCiwXw2U+N9dhVG/BJHt+wRLJYe0Vf+LosdEVXPWrtsFpma7hh7KYpf hb9/l5u6kJqpq4tgGZOcDvJ3pVV6kzLYcM04jKnN36N7UdeTad8MU6hy81h5OFtfyCw+ yud0r4mBJ0A73qOtvp3GnKmKrfUIDnBhed2dh1zZnARiN89pRIvgDmBGCgUgFflzfGlK zIpQ== X-Gm-Message-State: AOAM532/aVyz50YqhSllDi9HICYpZ93YtS9+jCi2H0x3kcK5B4v22rlL qBX3TEpzPVbstgomPxjOSMPscqVecW/DsM7U9Ljods71mt/IJZ0NM1xjAO1dcFN0ZQ+Z4b8z3/U 2sxEReHFHcr8qWxAhssxPNrlkad6QE7Tceg== X-Received: by 2002:ab0:5bdc:: with SMTP id z28mr17539133uae.35.1633986254415; Mon, 11 Oct 2021 14:04:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYG787IBX8Rs3oz3moV7zNHy2U1yOjFcUsmDoeySsRrzhJNWqKQi25DnbaWQWBpuVGMRP24OTfQ3DGiBty/1o= X-Received: by 2002:ab0:5bdc:: with SMTP id z28mr17539109uae.35.1633986254212; Mon, 11 Oct 2021 14:04:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 11 Oct 2021 22:04:03 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Fix compare_three_way for constexpr and Clang To: Paul Keir Cc: "gcc-patches@gcc.gnu.org" , "libstdc++@gcc.gnu.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2021 21:04:18 -0000 On Mon, 11 Oct 2021 at 20:48, Jonathan Wakely wrote: > > On Fri, 20 Aug 2021 at 21:19, Paul Keir wrote: > > > > Hi, > > > > The current compare_three_way implementation makes provision for consta= nt evaluation contexts (avoiding reinterpret_cast etc.), but the approach f= ails with Clang; when it compares two const volatile void pointers: "compar= ison between unequal pointers to void has unspecified result". I include a = fix and test. > > > > Could someone commit the attached patch for me? > > Sorry for dropping the ball on this again. I've applied the patch > locally and I'm testing it now. Unless I'm mistaken, you do not have a > copyright assignment on file with the FSF, is that right? Are you able > to certify that you have the right to submit this to GCC, as described > at https://gcc.gnu.org/dco.html ? P.S. patches should not touch the ChangeLog file. It was always wrong, because it usually makes the patch fail to apply. Since we moved to Git the ChangeLog files are automatically generated from the Git commits anyway, so are never touched as part of the commit. The changelog entry is still needed, but should be in the Git commit message not as a patch against the actual ChangeLog file. > > Also, if GCC is failing to diagnose the invalid comparisons here then > that should be reported to bugzilla as a c++ "accepts-invalid" bug.