From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 500E43858D20 for ; Fri, 1 Sep 2023 16:10:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 500E43858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693584623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3tO7X3/MUWb+mvDLIaIeS38TZW9Kn75OiwwDT+dqeXI=; b=bKoOfCtwiNqYMPoniDKwo0R8BWyYrfSp+6Fd2Q0ZMwLpvrHIV8jfsz2L3fdUfMgRhiK1AI tCoZd4q77pTPmJ5lnCdY9jyMuZEzW5fSgWID7nF04PgFsGNGIcaqOBwzP+BjTZUwTkDLME kolu30UYZt7bnZInwSQQQ064CK3k1ww= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-_aDc7ATKO9icZ_AF51zY5Q-1; Fri, 01 Sep 2023 12:10:21 -0400 X-MC-Unique: _aDc7ATKO9icZ_AF51zY5Q-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2bcc1e0dfe5so26043871fa.1 for ; Fri, 01 Sep 2023 09:10:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693584620; x=1694189420; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3tO7X3/MUWb+mvDLIaIeS38TZW9Kn75OiwwDT+dqeXI=; b=Fh/5Mo6xMX2YZByvYM9Eaei8uoDTe4LMoeapwLo0pYBg7BkcIMPiWgtfCMTztS8SYx JYj1FtKNk7ZmTBKKIPxXrgu3dNZjvsLPnDKIxTqnU8vd5j6d58u3c5ri3K6hf5YzxOFu SCKLwV5jAS//CMT+HeCOgXUVziv25in3M5+JIAUhzCVhk73u25TWkiCplOQ55dMiWKbo zNnrIZ2y8ZObtq+8Q3kcrIv5si3a46l52SR30M5aVFs7JfHUAw+n1owbjorlbhu4FiUb VmnM72O+4EGZ+Ylhy/9nL9A2H/8p2FHfbKkovfpNJcb2q/IoG5V7eHBDS60bFkyc++sZ H69A== X-Gm-Message-State: AOJu0Yx2kkHWABT64pgvCeWgpjJSs0G5mWOEWC4Ef7+Nxv8O9ln0y7GM LELgJ4Kmbi0WziN1qB+X+umZrW6qtbUTVPMQBcfAijYbFN72+FBhToFAIQ+vBzetzRLbwcUiSRt CuDkqbtiLGw0uTlYMfzKwVoTcQUeQnuw4Og== X-Received: by 2002:a05:651c:201:b0:2bd:bc9:30aa with SMTP id y1-20020a05651c020100b002bd0bc930aamr2165188ljn.23.1693584620039; Fri, 01 Sep 2023 09:10:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1nmyFfRUuLm7PvaJIXbC3p62C20LzNQVzvMcnqaceTpocySc/bw2ghmvleit+NrMbUOU3vc+np25sCAwT6Hw= X-Received: by 2002:a05:651c:201:b0:2bd:bc9:30aa with SMTP id y1-20020a05651c020100b002bd0bc930aamr2165177ljn.23.1693584619746; Fri, 01 Sep 2023 09:10:19 -0700 (PDT) MIME-Version: 1.0 References: <20230823160322.237140-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 1 Sep 2023 17:10:08 +0100 Message-ID: Subject: Re: [RFC] libstdc++: Make --enable-libstdcxx-backtrace=auto default to yes To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 1 Sept 2023 at 12:16, Jonathan Wakely wrote: > > On Wed, 23 Aug 2023 at 17:03, Jonathan Wakely via Libstdc++ > wrote: > > > > Any objections to this? It's a C++23 feture, so should be enabled by > > default. > > I've pushed this to trunk, so let's see what breaks! This modules header broke on aarch64, of course: FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors) > > > > > > -- >8 -- > > > > This causes libstdc++_libbacktrace.a to be built by default. This might > > fail on some targets, in which case we can make the 'auto' choice expand > > to either 'yes' or 'no' depending on the target. > > > > libstdc++-v3/ChangeLog: > > > > * acinclude.m4 (GLIBCXX_ENABLE_BACKTRACE): Default to yes. > > * configure: Regenerate. > > --- > > libstdc++-v3/acinclude.m4 | 2 +- > > libstdc++-v3/configure | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 > > index b25378eaace..50c808c6b2d 100644 > > --- a/libstdc++-v3/acinclude.m4 > > +++ b/libstdc++-v3/acinclude.m4 > > @@ -5481,7 +5481,7 @@ BACKTRACE_CPPFLAGS="$BACKTRACE_CPPFLAGS -DBACKTRACE_ELF_SIZE=$elfsize" > > > > AC_MSG_CHECKING([whether to build libbacktrace support]) > > if test "$enable_libstdcxx_backtrace" = "auto"; then > > - enable_libstdcxx_backtrace=no > > + enable_libstdcxx_backtrace=yes > > fi > > AC_MSG_RESULT($enable_libstdcxx_backtrace) > > if test "$enable_libstdcxx_backtrace" = "yes"; then > >