From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5F25A385829F for ; Mon, 17 Oct 2022 08:48:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F25A385829F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665996534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cDkQlLZBRn2Nh9CSWD1XAshJJ5siZGj2Zpc94xv+5XM=; b=ADClICHGYAHOCkjdSYAcsmlylRaA2mIZFOD3g8g4u3CpfpX0NmzEF4PZEtGNP/BCx/ZY7+ aFDlY1ouHzU7uRfDbcSOx+ShhEPLhqHwuEGMTkqB/eS4W1qadi/hpb/3UyloxAAYXn/ULG Zc9GmC1YhxcspLRguXf+ygZ6Y/Vj/QA= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-321-WXYc-25DNa21BgqKrJw9YA-1; Mon, 17 Oct 2022 04:48:53 -0400 X-MC-Unique: WXYc-25DNa21BgqKrJw9YA-1 Received: by mail-qt1-f199.google.com with SMTP id s14-20020a05622a1a8e00b00397eacd9c1aso8093365qtc.21 for ; Mon, 17 Oct 2022 01:48:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sHDEEae0Lc2JZtRu03WxdXLKRkcStDgfuKnH+65V17I=; b=7h2B5puLeWu9n02qaH2Nzmp/pNXy6xi0lkCz83F4hbwPbRG3lTDCfUPH/lIh2/+X0v MBTiq3g4RM8U1oULHigbtjXhwxokt3ugO4+jNVguWMCsFGnhDCUXwkD8UewohRVHXFnV VNDv2hWiOa8Z4uo3nKr7l0oWKQKDH6BJS9Khpfj+xZfhRmds2Wc1w4uA6ug7gNl3xA56 ePuURHinVreTuoNiRts0KSqlio67TcJUsRFFbliVKp8MRCpny3WYQzUU+rmBguw3LEmf aY+zTJmxeFAnVufE3rTHpn4IYneD+3XGFbs1QlTK5TB664Cye7sF9FD8iL0qz0YXdL6O Y/3Q== X-Gm-Message-State: ACrzQf1Mi2mUoLvekYEIJR/C9k0BRGeOHWASapdZREPpP08x3KbrpcJF MdJqbB7RCn7J5O9HItAuY4133fPEkevvB7bo1qNMSsGaGiszIYy9ly+nYshXd9qflW/gFYXeXek 4X8mW+CTSUh5gGjwEmBNNWXvQIpvqkDKJXQ== X-Received: by 2002:a05:622a:19a0:b0:39c:ba70:e475 with SMTP id u32-20020a05622a19a000b0039cba70e475mr7722063qtc.50.1665996533019; Mon, 17 Oct 2022 01:48:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Vycao1gj9HC9XXYeQEf/yko/oWoCCIIvjwTakSL8DSEGbjs8Sd4mrwJQBDLZRBid+qZr4h6Pp5cNDAmri3UI= X-Received: by 2002:a05:622a:19a0:b0:39c:ba70:e475 with SMTP id u32-20020a05622a19a000b0039cba70e475mr7722055qtc.50.1665996532842; Mon, 17 Oct 2022 01:48:52 -0700 (PDT) MIME-Version: 1.0 References: <20221015202518.2687700-1-jwakely@redhat.com> In-Reply-To: <20221015202518.2687700-1-jwakely@redhat.com> From: Jonathan Wakely Date: Mon, 17 Oct 2022 09:48:41 +0100 Message-ID: Subject: Re: [committed] libstdc++: Implement constexpr std::to_chars for C++23 (P2291R3) To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000089fbec05eb370bb3" X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000089fbec05eb370bb3 Content-Type: text/plain; charset="UTF-8" On Sat, 15 Oct 2022 at 21:26, Jonathan Wakely via Libstdc++ wrote: > > libstdc++-v3/ChangeLog: > > * include/bits/charconv.h (__to_chars_10_impl): Add constexpr > for C++23. Remove 'static' from array. > * include/std/charconv (__cpp_lib_constexpr_charconv): Define. I managed to define the feature test macro with the wrong value. Fixed by the attached patch, pushed to trunk. --00000000000089fbec05eb370bb3 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l9cjb2hn0 Y29tbWl0IDBmNDgxNTUwMmQ4ZGFjMDc1NzlkYzdhNWE0MGM1OTdhMTgyOTFiNGMKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBNb24gT2N0IDE3IDA5 OjM4OjAyIDIwMjIKCiAgICBsaWJzdGRjKys6IEZpeCB2YWx1ZSBvZiBfX2NwcF9saWJfY29uc3Rl eHByX2NoYXJjb252CiAgICAKICAgIGxpYnN0ZGMrKy12My9DaGFuZ2VMb2c6CiAgICAKICAgICAg ICAgICAgKiBpbmNsdWRlL3N0ZC9jaGFyY29udiAoX19jcHBfbGliX2NvbnN0ZXhwcl9jaGFyY29u dik6IERlZmluZSB0bwogICAgICAgICAgICBjb3JyZWN0IHZhbHVlLgogICAgICAgICAgICAqIGlu Y2x1ZGUvc3RkL3ZlcnNpb24gKF9fY3BwX2xpYl9jb25zdGV4cHJfY2hhcmNvbnYpOiBMaWtld2lz ZS4KICAgICAgICAgICAgKiB0ZXN0c3VpdGUvMjBfdXRpbC90b19jaGFycy9jb25zdGV4cHIuY2M6 IENoZWNrIGNvcnJlY3QgdmFsdWUuCiAgICAgICAgICAgICogdGVzdHN1aXRlLzIwX3V0aWwvdG9f Y2hhcnMvdmVyc2lvbi5jYzogTGlrZXdpc2UuCgpkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL2lu Y2x1ZGUvc3RkL2NoYXJjb252IGIvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL2NoYXJjb252Cmlu ZGV4IDRiNmNjODNhNTY3Li43YWVmZGQzMjk4YyAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYzL2lu Y2x1ZGUvc3RkL2NoYXJjb252CisrKyBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9jaGFyY29u dgpAQCAtNTEsNyArNTEsNyBAQAogI2VuZGlmCiAKICNpZiBfX2NwbHVzcGx1cyA+IDIwMjAwMkwK LSMgZGVmaW5lIF9fY3BwX2xpYl9jb25zdGV4cHJfY2hhcmNvbnYgMjAyMjAyTAorIyBkZWZpbmUg X19jcHBfbGliX2NvbnN0ZXhwcl9jaGFyY29udiAyMDIyMDdMCiAjZW5kaWYKIAogbmFtZXNwYWNl IHN0ZCBfR0xJQkNYWF9WSVNJQklMSVRZKGRlZmF1bHQpCmRpZmYgLS1naXQgYS9saWJzdGRjKyst djMvaW5jbHVkZS9zdGQvdmVyc2lvbiBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC92ZXJzaW9u CmluZGV4IGJlYzllN2FhNzkyLi4zYzdjNDQwYmQ4MCAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYz L2luY2x1ZGUvc3RkL3ZlcnNpb24KKysrIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL3ZlcnNp b24KQEAgLTMwMiw3ICszMDIsNyBAQAogI2lmIF9fY3BsdXNwbHVzID4gMjAyMDAyTAogLy8gYysr MjMKICNkZWZpbmUgX19jcHBfbGliX2J5dGVzd2FwIDIwMjExMEwKLSNkZWZpbmUgX19jcHBfbGli X2NvbnN0ZXhwcl9jaGFyY29udiAyMDIyMDJMCisjZGVmaW5lIF9fY3BwX2xpYl9jb25zdGV4cHJf Y2hhcmNvbnYgMjAyMjA3TAogI2RlZmluZSBfX2NwcF9saWJfY29uc3RleHByX3R5cGVpbmZvIDIw MjEwNkwKICNpZiBfX2NwcF9jb25jZXB0cyA+PSAyMDIwMDJMCiAjIGRlZmluZSBfX2NwcF9saWJf ZXhwZWN0ZWQgMjAyMjAyTApkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMF91 dGlsL3RvX2NoYXJzL2NvbnN0ZXhwci5jYyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRp bC90b19jaGFycy9jb25zdGV4cHIuY2MKaW5kZXggMzBjNTkxNjU5ZWUuLjEwODU1YjczN2M3IDEw MDY0NAotLS0gYS9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIwX3V0aWwvdG9fY2hhcnMvY29uc3Rl eHByLmNjCisrKyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC90b19jaGFycy9jb25z dGV4cHIuY2MKQEAgLTUsNyArNSw3IEBACiAKICNpZm5kZWYgX19jcHBfbGliX2NvbnN0ZXhwcl9j aGFyY29udgogIyBlcnJvciAiRmVhdHVyZS10ZXN0IG1hY3JvIGZvciBjb25zdGV4cHIgY2hhcmNv bnYgbWlzc2luZyBpbiA8Y2hhcmNvbnY+IgotI2VsaWYgX19jcHBfbGliX2NvbnN0ZXhwcl9jaGFy Y29udiAhPSAyMDIyMDJMCisjZWxpZiBfX2NwcF9saWJfY29uc3RleHByX2NoYXJjb252ICE9IDIw MjIwN0wKICMgZXJyb3IgIkZlYXR1cmUtdGVzdCBtYWNybyBmb3IgY29uc3RleHByIGNoYXJjb252 IGhhcyB3cm9uZyB2YWx1ZSBpbiA8Y2hhcmNvbnY+IgogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL2xp YnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC90b19jaGFycy92ZXJzaW9uLmNjIGIvbGlic3Rk YysrLXYzL3Rlc3RzdWl0ZS8yMF91dGlsL3RvX2NoYXJzL3ZlcnNpb24uY2MKaW5kZXggYWYwNmUx YmYwNTQuLjI1YjFlMDAzNmU4IDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIw X3V0aWwvdG9fY2hhcnMvdmVyc2lvbi5jYworKysgYi9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIw X3V0aWwvdG9fY2hhcnMvdmVyc2lvbi5jYwpAQCAtMTEsNiArMTEsNiBAQAogCiAjaWZuZGVmIF9f Y3BwX2xpYl9jb25zdGV4cHJfY2hhcmNvbnYKICMgZXJyb3IgIkZlYXR1cmUtdGVzdCBtYWNybyBm b3IgY29uc3RleHByIGNoYXJjb252IG1pc3NpbmcgaW4gPHZlcnNpb24+IgotI2VsaWYgX19jcHBf bGliX2NvbnN0ZXhwcl9jaGFyY29udiAhPSAyMDIyMDJMCisjZWxpZiBfX2NwcF9saWJfY29uc3Rl eHByX2NoYXJjb252ICE9IDIwMjIwN0wKICMgZXJyb3IgIkZlYXR1cmUtdGVzdCBtYWNybyBmb3Ig Y29uc3RleHByIGNoYXJjb252IGhhcyB3cm9uZyB2YWx1ZSBpbiA8dmVyc2lvbj4iCiAjZW5kaWYK --00000000000089fbec05eb370bb3--