From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 487273857705 for ; Tue, 8 Aug 2023 20:23:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 487273857705 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691526214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q2oKKkd8lwgC58eYMakPzgjtXmX5UmFjUrucyLYzghs=; b=FjVIZE6QdshwKIiMZvAp5Mm4Y/r6EJjE0uk8SkuZZH2BPTSQQNjulR7tHUew5JJKHdc15S y+UqEnNUzQACRqRiPcEAGE3l3RCz7ww3S3u28BsfzPYRhe/3YIBuf8t7soHUCg/UGFWnei ELRr8F/nsEZq8ljj5XB1YxkYsVz2TBY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-sZA1xRVXNrePO6Jj_vaIhg-1; Tue, 08 Aug 2023 16:23:32 -0400 X-MC-Unique: sZA1xRVXNrePO6Jj_vaIhg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b980182002so1137951fa.1 for ; Tue, 08 Aug 2023 13:23:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691526211; x=1692131011; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q2oKKkd8lwgC58eYMakPzgjtXmX5UmFjUrucyLYzghs=; b=cSqWifBHDdGvdSZcZeZNfnhCg6Cr9iR04RhO0/uyzQjOZALqD2J6kaD+onCgE8UGnF CXtFJnB2dSMLqyXcCQ36eKWS4rnANCIQ7ajOabBTX0tRodeSgbVQEby+tvD7arE51fcQ xS0xwyhAfBeJvqchts8wrQ/9Zq4VEfsb23mI1XbjMLLFDBdAD/1w+nvA/DGBQ5WIHH9l wYgHUSYK3uF6GvPSbacMup+3DbKfVAYQyKUSTfEfIMA+LloBVSz4I89zcmXYINYA/L4R mx4ZRam1aDDnaGaueM2F+DatTJ0TaqDLLLdky8ofJNRBoaDvUxKSwTE5GeHL6cp+JXIw cKvQ== X-Gm-Message-State: AOJu0Yyp4V08zkVQo2jCSVxRFJrJ+ZeHFz8iLA2bnzl5Hj95B/qg9HQc YfwHd2TyU4xZYFXM+0hDLzjhC0+PwLe0EaDQyTBoX/mVZxQSVbV/UV9hlPw00IaxWGHWMGR1hiy Biha0wkyCsMxJvpB9f5xEGLUZ9Bf2dMW8mw== X-Received: by 2002:a2e:874d:0:b0:2b6:c3f9:b86b with SMTP id q13-20020a2e874d000000b002b6c3f9b86bmr296064ljj.15.1691526210997; Tue, 08 Aug 2023 13:23:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErSPMv1oHPCG6in+UzM//LZoVlPyKG5/nv63UKhI42EUhvom9Sd3iBXmst4M9yz2I0gMdVnJdFTpYGambrZfo= X-Received: by 2002:a2e:874d:0:b0:2b6:c3f9:b86b with SMTP id q13-20020a2e874d000000b002b6c3f9b86bmr296056ljj.15.1691526210726; Tue, 08 Aug 2023 13:23:30 -0700 (PDT) MIME-Version: 1.0 References: <20230718223233.15328-1-kmatsui@gcc.gnu.org> <20230719193242.59472-1-kmatsui@gcc.gnu.org> In-Reply-To: <20230719193242.59472-1-kmatsui@gcc.gnu.org> From: Jonathan Wakely Date: Tue, 8 Aug 2023 21:23:19 +0100 Message-ID: Subject: Re: [PATCH v2] libstdc++: Define _GLIBCXX_HAS_BUILTIN_TRAIT To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000eb4b6806026f2249" X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000eb4b6806026f2249 Content-Type: text/plain; charset="UTF-8" On Wed, 19 Jul 2023 at 20:33, Ken Matsui via Libstdc++ < libstdc++@gcc.gnu.org> wrote: > This patch defines _GLIBCXX_HAS_BUILTIN_TRAIT macro, which will be used > as a flag to toggle the use of built-in traits in the type_traits header > through _GLIBCXX_NO_BUILTIN_TRAITS macro, without needing to modify the > source code. > > libstdc++-v3/ChangeLog: > > * include/bits/c++config (_GLIBCXX_HAS_BUILTIN_TRAIT): Define. > (_GLIBCXX_HAS_BUILTIN): Keep defined. > I think this would be a little better as: * include/bits/c++config (_GLIBCXX_HAS_BUILTIN): Do not undef. (_GLIBCXX_HAS_BUILTIN_TRAIT): Define. OK for trunk with that change, thanks. > > Signed-off-by: Ken Matsui > --- > libstdc++-v3/include/bits/c++config | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libstdc++-v3/include/bits/c++config > b/libstdc++-v3/include/bits/c++config > index dd47f274d5f..984985d6fff 100644 > --- a/libstdc++-v3/include/bits/c++config > +++ b/libstdc++-v3/include/bits/c++config > @@ -854,7 +854,15 @@ namespace __gnu_cxx > # define _GLIBCXX_HAVE_BUILTIN_LAUNDER 1 > #endif > > -#undef _GLIBCXX_HAS_BUILTIN > +// Returns 1 if _GLIBCXX_NO_BUILTIN_TRAITS is not defined and the compiler > +// has a corresponding built-in type trait, 0 otherwise. > +// _GLIBCXX_NO_BUILTIN_TRAITS can be defined to disable the use of > built-in > +// traits. > +#ifndef _GLIBCXX_NO_BUILTIN_TRAITS > +# define _GLIBCXX_HAS_BUILTIN_TRAIT(BT) _GLIBCXX_HAS_BUILTIN(BT) > +#else > +# define _GLIBCXX_HAS_BUILTIN_TRAIT(BT) 0 > +#endif > > // Mark code that should be ignored by the compiler, but seen by Doxygen. > #define _GLIBCXX_DOXYGEN_ONLY(X) > -- > 2.41.0 > > --000000000000eb4b6806026f2249--