From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0EA93388206F for ; Fri, 14 Jun 2024 13:23:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EA93388206F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0EA93388206F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718371417; cv=none; b=IM8nYYRvJZ8FdzPfmRaFmpm4Jzbsd686j7JSLsXcNVaDwLDfL/rYRp0Jq7F7XUNMfPVtzNoBAacsqrfBAu0ofE7/u77nYm60KpYMVAmAjyFwVI8qbfDftH66NzQSbB1Hz7ccpx/mqvkKxCbFN7+XBQdlp5sE5M/SxF8OAkbD2T0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718371417; c=relaxed/simple; bh=Xb0H4sPmIECHMR+MlbXVTEdCHtWTbewzpbIIAI7E4cQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=R73apeZwCmdpgRJj3DM74SPjWCByYfjOi7A2rWVMCnRNEeLXHsZxS+SmQ7icZN/u5DYJHYHUX29d01fusDVuIPlFbZncDbbBokpcnJAxX2DtLaVThfTXw4mUj2R2C57RDNbf9BNHBvKnxDPmmyrBINZkUcSwhACrTl9jxKdhWTQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718371414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pg5dLm7Fo7HgUCHQdbwQs15ElooATKxNQRCeefQkJr4=; b=OfJvcPlIM7JxEKdybwtafPI1oRhCti1R/dOl1XGS42sPFexolDaLmhs8ivA56zhuFllKgO nL8DTjfGWBpja46Nuyn3jv3RkH9tZpe91InS2OdvWFnJxX9sqp8pUjXRUrBssBvfw2FpW/ xSM176VSIC/LLXdR1KyzGnxafEwNHCs= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-enQLgIpOPM6je4_7d_4CPQ-1; Fri, 14 Jun 2024 09:23:30 -0400 X-MC-Unique: enQLgIpOPM6je4_7d_4CPQ-1 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-df796aaa57dso3091227276.1 for ; Fri, 14 Jun 2024 06:23:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718371410; x=1718976210; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pg5dLm7Fo7HgUCHQdbwQs15ElooATKxNQRCeefQkJr4=; b=i9BR/d3ipdnxwZ1pxAVH+evPN+YYGrfxAz2vaLGvYNDYWZTgIHm+GLd4s6YSxkjtYt BilLJM/pCcaFG9aREAZD+9Bz3iwPOtz9O802wkRsDZN2Fcd4mEuiEE740jqpNd9HjXwH G80kJ99sgm/1c5ZDiuYklGutbwN24oVAQsN27Pf+x2+v7I2Q5MuzlOrGZeAXOFaFMqVd M7QootstSzJGYREhaDbNng1FYkQVQIZscLOl1EbamEcC9z99vIDyWgWLMWnJHbxNw7WF LNKhnzNzQm3Bi91YtN5I8Vn7WbAD2m0Yjdf8FjMB90ukGhgmUCTnUEYg6o/9nyE0QGzZ ncXg== X-Forwarded-Encrypted: i=1; AJvYcCXwygYGXnxsaz3tEzkp8hcDfYQmO3PLyB/ps6t6+2MaZeZgczGT1Ei93/E3cLcexzD9HhImDju8zuyt7ciIA5JTGHouW6Jryg== X-Gm-Message-State: AOJu0Yx05HUUIAONtF1FanAWWIJcGOYgbXlfY61PetqbFXqLtdMZghIG SG6j3szSkpONSsioBHeYv8XyMIYUDkwgjuFpI79CXoCVsVmCN1iWych3wHzBYUf5s2f8gz8Y5ml Ukug3YX34Cle7VlDchq4j+zi6ebF+BdGiByY0sHSTTTDuBIvuWp6whKPUS5NaIWiXRK6kmfsK2i RgwWMLHkU+UP0SgfWGi3Is5UicslHCnA== X-Received: by 2002:a05:6902:1023:b0:dfa:f7ef:207c with SMTP id 3f1490d57ef6-dff1548f7c7mr2701738276.41.1718371409948; Fri, 14 Jun 2024 06:23:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHg60ohrpTXtYX5ureYzKVLvoa8QEl8WGmivxmzXs7ctPDH5ddOtRuAB1s9DXx82HixQcfeM/KG1WrWZjmyVl0= X-Received: by 2002:a05:6902:1023:b0:dfa:f7ef:207c with SMTP id 3f1490d57ef6-dff1548f7c7mr2701711276.41.1718371409586; Fri, 14 Jun 2024 06:23:29 -0700 (PDT) MIME-Version: 1.0 References: <3DAB006A-ACE2-4BEC-AA01-87625DBEE259@exactcode.de> <20240612.123343.1340522057045758230.rene@exactcode.de> <20240612.124242.1291436266291405210.rene@exactcode.de> <7osn6951-s8n4-7q7r-q872-11pr63q5202n@fhfr.qr> <98ac79fc-6c97-4028-b43b-abbcfcd36adc@web.de> <62232acd-de32-4a33-9561-affaaa4f0630@web.de> In-Reply-To: <62232acd-de32-4a33-9561-affaaa4f0630@web.de> From: Jonathan Wakely Date: Fri, 14 Jun 2024 14:23:13 +0100 Message-ID: Subject: Re: [PATCH 2/3] Enabled LRA for ia64. To: Frank Scheiner Cc: jeffreyalaw@gmail.com, Richard Biener , gcc-patches@gcc.gnu.org, Rene Rebe X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 14 Jun 2024 at 14:07, Frank Scheiner wrote: > > On 14.06.24 14:53, Jonathan Wakely wrote: > > On Fri, 14 Jun 2024 at 12:07, Frank Scheiner wrote: > >> ...point to two headers which are part of glibc 2.39 (w/ia64 support > >> re-added): > >> > >> * /usr/include/bits/sigcontext.h:32-38: > >> ``` > >> 32 struct __ia64_fpreg > >> 33 { > >> 34 union > >> 35 { > >> 36 unsigned long bits[2]; > >> 37 } u; > >> 38 } __attribute__ ((__aligned__ (16))); > >> ``` > >> > >> * /usr/include/sys/ucontext.h:39-45: > >> ``` > >> 39 struct __ia64_fpreg_mcontext > >> 40 { > >> 41 union > >> 42 { > >> 43 unsigned long __ctx(bits)[2]; > >> 44 } __ctx(u); > >> 45 } __attribute__ ((__aligned__ (16))); > >> ``` > > > > This is an ia64-specific glibc bug, because it means the following > > valid C program is rejected: > > > > #define _GNU_SOURCE > > #define bits 111 > > #define u no u > > #include > > int main() { } > > Ok, I see. Should this then be "worked around" like in [1] with > something like: > > ``` > #if defined (__linux__) && defined (__ia64__) > // defines __ia64_fpreg_mcontext::u > #undef u > #endif > ``` > > ...in `libstdc++-v3/testsuite/17_intro/names.cc` or should we fix it in > glibc instead? Both, ideally. The libstdc++ test should definitely be fixed because it fails with released versions of glibc already in the wild. But glibc should also be fixed because it's a standards conformance issue. > > [1]: > https://gcc.gnu.org/git/?p=gcc.git;a=patch;h=cf5f7791056b3ed993bc8024be767a86157514a9 > > Cheers, > Frank >