From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C00B6385842C for ; Wed, 7 Jun 2023 14:56:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C00B6385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686149819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZFI+X6cqsRwU4j0n3vpbbk+rxm3hMpSnaZvm4jIlgLw=; b=bsDsToN5LCqvB0sNwmXNX9LlmfdLmWGqd+M8c+e+WCP6jaSmowNcZeSe35A9MPy7gQ0jsm wH+4lPEL1UVs+jnHU0n81qrYL9CDexFIrA/1eLLmJQ0spp63EL4ftoCumk0KUu/DJOP4Ow 9JeeCnpuMqj3wNuu0VvyLZ5tWmMuiMU= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-xy2KWQhtOxK5CLtTiq0vRw-1; Wed, 07 Jun 2023 10:56:57 -0400 X-MC-Unique: xy2KWQhtOxK5CLtTiq0vRw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4f5847463baso2407248e87.3 for ; Wed, 07 Jun 2023 07:56:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686149816; x=1688741816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZFI+X6cqsRwU4j0n3vpbbk+rxm3hMpSnaZvm4jIlgLw=; b=Ehj0SFWbbdgpU9QPm9+ZM6Mg8e6pEYYvSpZsUNKEvOiOVW/ybqgkPz0mDO6Iyr6Bzk IhSTUbcSzoex9BMLFyryZNi+sqwHuyqjBinEJEwCHsGG7wwengt85QpF7AMQaxncx813 qcEudWy+QPD3H99q1vHCMzP+HOcVqnucFVZUZ7DbsaLwO8DGElW+EjMfOMDUz2JQxlYZ iAy+7RlyV/Y6+xzfLy/xVdh/TFzmh57jJuA5KK7GvV7muR5hqZqSs+U41fq6qlChyq3u KaIYEPkTJxNIXQxLdoyYZ0BC8FePSB8BpFcdryAqCeDwrjDKCohH/e1YTjSqvOq7+mOq zDbg== X-Gm-Message-State: AC+VfDyP08uN0qubzvfHJAcvWplEK/ICrMqyLGjy34QKaLRiGpOWPx8T QoD/IHxWEb2eRXghLxB99ArpHtRjcf357DRfcN99StSZFuoVmak9oitHRTv5wiqPN591oJHWgZZ WJFZ0uj8DcPvBwUtiQWhhieyLRLOzXigG3Q== X-Received: by 2002:ac2:4c86:0:b0:4f2:769a:120e with SMTP id d6-20020ac24c86000000b004f2769a120emr2196326lfl.2.1686149816327; Wed, 07 Jun 2023 07:56:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7wD2BxjNML7MzIP0q9GrDaNyhT462vJGqYQXtqlrMDdkPXyb4K8j9F9wzE5n1MeB0sf+CgQjxaajGRyPimubk= X-Received: by 2002:ac2:4c86:0:b0:4f2:769a:120e with SMTP id d6-20020ac24c86000000b004f2769a120emr2196318lfl.2.1686149816020; Wed, 07 Jun 2023 07:56:56 -0700 (PDT) MIME-Version: 1.0 References: <20230601155856.305565-1-jwakely@redhat.com> <20230607144244.A0DC120420@pchp3.se.axis.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 7 Jun 2023 15:56:44 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Use AS_IF in configure.ac To: Hans-Peter Nilsson Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000d28b6b05fd8b580b" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d28b6b05fd8b580b Content-Type: text/plain; charset="UTF-8" On Wed, 7 Jun 2023 at 15:54, Jonathan Wakely wrote: > > > On Wed, 7 Jun 2023 at 15:42, Hans-Peter Nilsson wrote: > >> > Date: Tue, 6 Jun 2023 16:30:12 +0100 >> > From: Jonathan Wakely via Gcc-patches >> >> > On Thu, 1 Jun 2023 at 16:59, Jonathan Wakely via Libstdc++ < >> > libstdc++@gcc.gnu.org> wrote: >> > >> > > Tested x86_64-linux. I'd appreciate a second set of eyeballs on this >> > > before I push it. >> > > >> > >> > Pushed to trunk now. >> >> ...as r14-1581-g97a5e8a2a48d16, after which (apparently) >> *all* linking libstdc++ tests for cris-elf (a "newlib >> target") get (for example): >> >> FAIL: 17_intro/freestanding.cc (test for excess errors) >> Excess errors: >> /x/cris-elf/pre/cris-elf/bin/ld: cannot find -liconv: No such file or >> directory >> >> (deduced from libstdc++.log and the commits in the range >> ce2188e4320c..585c660f041c where 4144 regressions in >> libstdc++ were introduced for cris-elf) >> > > Gah. I tested building cris-elf but didn't run any tests. > > I *thought* I compared the configure results before and after the patch > too, but I guess I missed something, or it didn't show up where I looked. > > > >> From the generated configure and a brief RTFM for AS_IF, it >> looks almost like AS_IF was "miscompiled" and behaving >> literally AS_IF (!) in that the condition TEST1 (here >> [$GLIBCXX_IS_NATIVE] seems to be emitted *after* the >> RUN-IF-TRUE1 clause (the next 31 lines). Not obvious what >> went wrong. I even tried regenerating configure. HTH. >> >> > Let's just revert it then. The manual says we should use AS_IF, but what > we had previously was working well enough. I'll figure out what happened > here later. > Reverted as r14-1607-g000f8b9a6a0ec7 --000000000000d28b6b05fd8b580b--