From: Jonathan Wakely <jwakely@redhat.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [committed] libstdc++: Implement C++23 <print> header [PR107760]
Date: Sun, 17 Dec 2023 00:04:16 +0000 [thread overview]
Message-ID: <CACb0b4mCvr-fL6shmA24djYRHMP2y=TwGARqRniar0HTjQc8vQ@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4kENCLyEsxfA11M0JoW8OyPVER4b9W75PCe7H2+TkF7hg@mail.gmail.com>
On Sun, 17 Dec 2023 at 00:02, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On Sat, 16 Dec 2023 at 23:06, David Edelsohn <dje.gcc@gmail.com> wrote:
> >
> > On Sat, Dec 16, 2023 at 4:44 PM Jakub Jelinek <jakub@redhat.com> wrote:
> >>
> >> On Sat, Dec 16, 2023 at 04:24:13PM -0500, David Edelsohn wrote:
> >> > AIX stdio.h defines fileno as a macro although there is a symbol in libc.
> >> >
> >> > I think that print.cc at least needs to
> >> >
> >> >
> >> > #undef fileno
> >> >
> >> >
> >> > before the usage.
> >>
> >> Or (::fileno)(f) ?
> >
> >
> > Yes, that also avoids the error.
>
> Yup, I've just tested it. I'll push that change in the morning.
Actually I just pushed it now. The functions in that file are only
actually used on Windows, so if they build on linux and AIX, that's
good enough.
next prev parent reply other threads:[~2023-12-17 0:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 21:24 David Edelsohn
2023-12-16 21:44 ` Jakub Jelinek
2023-12-16 23:06 ` David Edelsohn
2023-12-17 0:02 ` Jonathan Wakely
2023-12-17 0:04 ` Jonathan Wakely [this message]
2023-12-17 0:15 ` David Edelsohn
-- strict thread matches above, loose matches on Subject: below --
2023-12-15 0:02 Jonathan Wakely
2023-12-15 1:16 ` Tim Song
2023-12-15 10:42 ` Jonathan Wakely
2023-12-15 14:48 ` Tim Song
2023-12-16 9:10 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4mCvr-fL6shmA24djYRHMP2y=TwGARqRniar0HTjQc8vQ@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).