From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 712A5386C5B8 for ; Sun, 17 Dec 2023 00:04:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 712A5386C5B8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 712A5386C5B8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702771475; cv=none; b=qFZW3OmLHVgv/eRtYyM5nx6emoc7TCPohhAXIUk+DCs5VFBjZ+kO+SZUsR7XXKeoq4rJFBAGpJyjKSdMdLGi+v65R3kwW09x6Vlo53vsSwtutouofsw4kQw3xF87QG03IKkT/2r1tLPxoWrDANjyXE7Seqm1atwKHJwaLgdnEpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702771475; c=relaxed/simple; bh=lOiq+Rvv/Bi9V4uoE8EJv0UvJ4odr5rcKLQF1E3h12k=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ELyCAoXRGwd8MNOAg4fKLEprzCPtkEmQtHpnM4ixMeyrZVGx6FzgOlpBwbWNVIwrqdWx6r2/UL2e84sUQeS1u+PO/wqNDtLc+pvebU2RkQlVBQlZEELX41+52Qt7FBMAy4+N8bPZ/ojO3q8senROTa1ZX5weZz3FkqXxz7pelm8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702771474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lOiq+Rvv/Bi9V4uoE8EJv0UvJ4odr5rcKLQF1E3h12k=; b=WrMJVXEiimzG3aicmpt+C7Isd+vuw1LPEy1s9WmDvfCzT15UGloQ8RNHtKlTJX1m0f6m3a u+eBRx+rn+QZWgXwEOFlNizbEBQXUBHUrQvG6NrVP6eCr+W6a9bx0C+Qh6pAAnBUgko9Gd 1qJM1REhP+g6TfFco5+cKmaKeeWn7hY= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-5RXi9qt4PyC4SNOEMkcZHg-1; Sat, 16 Dec 2023 19:04:32 -0500 X-MC-Unique: 5RXi9qt4PyC4SNOEMkcZHg-1 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-dbcc50d7dd3so1638512276.2 for ; Sat, 16 Dec 2023 16:04:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702771472; x=1703376272; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lOiq+Rvv/Bi9V4uoE8EJv0UvJ4odr5rcKLQF1E3h12k=; b=Hob5qIfEdx/z5MLoZLMX+SdlQ62BRqO94iC+hjbLJOtjK6XxwBXPkw5V9SpQCKtU1l 42/MPXIreZP0RIXyB6j5ewlP14phTMjbuBvge/rBoDVwUAQhpj8RNwgMGx11f3MDTKsj R9PuA+s3Q8U/ei9EchbQrkgsofoe5pN03uXI/urvt9NBkGu7IjWp9YJAZgmEvks6+vIr Z07v6yw798hfMd0OI8RcGl/1vDMmi7qvEQJTNKsY3R+EhkJny0rvtI6Pju49+UM4A4PQ elMsWM8GAerePJRcR8V03MSa6rEV7Rudv+8utPLJ0t3TszLAj5Yxlxa/H0QOcKeUlrTx VTMA== X-Gm-Message-State: AOJu0YwwWBibmZObu5j32k5Afzcv/yH8uqvboEszL9+zVW2ONWvyWkXn 1O2LeNT30k5o3Ky9N8njAMAVC5EPKacBWqTn+zPynKiq0dDQ+uIHxQfK9xyK3Uox7h++1JuwHjF nMXzfxJF/Xd525OwSxHHOf9CPzZz3nNaACzePIALH3g== X-Received: by 2002:a0d:f603:0:b0:5d7:60ed:6a93 with SMTP id g3-20020a0df603000000b005d760ed6a93mr12185415ywf.54.1702771472230; Sat, 16 Dec 2023 16:04:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtd0pCGU+qTJ5sbVaglsDPrjOokRib0JvleuDfHRam2XASkpg7Keadfgkkcec8VwatwMxW8fmANT3GVzLKVJs= X-Received: by 2002:a0d:f603:0:b0:5d7:60ed:6a93 with SMTP id g3-20020a0df603000000b005d760ed6a93mr12185401ywf.54.1702771472032; Sat, 16 Dec 2023 16:04:32 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Sun, 17 Dec 2023 00:04:16 +0000 Message-ID: Subject: Re: [committed] libstdc++: Implement C++23 header [PR107760] To: David Edelsohn Cc: Jakub Jelinek , GCC Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 17 Dec 2023 at 00:02, Jonathan Wakely wrote: > > On Sat, 16 Dec 2023 at 23:06, David Edelsohn wrote: > > > > On Sat, Dec 16, 2023 at 4:44=E2=80=AFPM Jakub Jelinek wrote: > >> > >> On Sat, Dec 16, 2023 at 04:24:13PM -0500, David Edelsohn wrote: > >> > AIX stdio.h defines fileno as a macro although there is a symbol in = libc. > >> > > >> > I think that print.cc at least needs to > >> > > >> > > >> > #undef fileno > >> > > >> > > >> > before the usage. > >> > >> Or (::fileno)(f) ? > > > > > > Yes, that also avoids the error. > > Yup, I've just tested it. I'll push that change in the morning. Actually I just pushed it now. The functions in that file are only actually used on Windows, so if they build on linux and AIX, that's good enough.