From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0A33D3858C53 for ; Fri, 2 Jun 2023 07:43:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A33D3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685691830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YJ07P+dWXClnhkUpN2MCkYtR6kKmc7PLFnL+jZga/2Q=; b=fjgzlxrEcpEwi5PjiyVGb9ujiZZkoprmZmYNjV1Cc6ziEeEt8tVVnpS8+UOST3KofDb5k0 DgGq5TG04A3eXcWm6B/DkoRrBICM/WX30RLDP/ydnYvfbiiJjIeYD4igmSXmdVTD8dZFLF gr4npEzSpkeBudjKU7ha59/PGsVYFQg= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-oEcTquzQPK6Dqe1QXFlQbw-1; Fri, 02 Jun 2023 03:43:49 -0400 X-MC-Unique: oEcTquzQPK6Dqe1QXFlQbw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b1b44bec2bso51721fa.2 for ; Fri, 02 Jun 2023 00:43:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685691827; x=1688283827; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YJ07P+dWXClnhkUpN2MCkYtR6kKmc7PLFnL+jZga/2Q=; b=fNqUmuwen4Yjf/v4pkiS7LRTo+Zaont/ZEGLCfOEUED8Cw59USyOspdUJhgMExsc31 2YLxRtxATYzXaDQwVnhsU4YNbNoMFhYzXYFhHT+7feaPRHY816CC/KLEfU6WwlzLPl9M bA0bCuHXWCR3eP2CzTVnNll1XL9nQ411WXg4EbmQI0cas1pbt/d1VNP8U9HI/efoxUiq /u9lSYTG4hIlyt92W4U9Brn41eEbdGXPwPAk6EI1u8FGF/isOTSSrG8jBIg/LlhBCBlw cvni5bXZ+xjtcGSTQLwhtbzCme3MSs/qAMNoPvoaL3VVjaunwqlZ4/Fa/7jhERUD2YiF zRDA== X-Gm-Message-State: AC+VfDy6nK84HLDJOGl2s8I8P7cRM+CUaRCw7w05+XYHgOqZEZOUK2iI 34H7UaKRkbLgTeARVj+/HMDilNVoVu3+2/NFNFqQmDE9fQLz0TdRlBwP6LeMwHm8t9agHmaVNaR e1a6QTFkISL+WnxBjjykgV9o8B0Da9Q+f8g== X-Received: by 2002:a2e:8755:0:b0:2ae:d39c:4c36 with SMTP id q21-20020a2e8755000000b002aed39c4c36mr1089901ljj.7.1685691827709; Fri, 02 Jun 2023 00:43:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5a6pF1M4BGDwdSEY5D454hW79H5UKWFj7KOhXl7lq1C/4pXKOQBWNUVLxam20WrVs3axV3qeSgY2zUhC3Wo30= X-Received: by 2002:a2e:8755:0:b0:2ae:d39c:4c36 with SMTP id q21-20020a2e8755000000b002aed39c4c36mr1089895ljj.7.1685691827412; Fri, 02 Jun 2023 00:43:47 -0700 (PDT) MIME-Version: 1.0 References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> <8f43b613-f185-8e46-8fc6-02bc286125b5@gmail.com> In-Reply-To: <8f43b613-f185-8e46-8fc6-02bc286125b5@gmail.com> From: Jonathan Wakely Date: Fri, 2 Jun 2023 08:43:35 +0100 Message-ID: Subject: Re: [PATCH] Move std::search into algobase.h To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , Rainer Orth , Jonathan Wakely via Gcc-patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000092f67e05fd20b68b" X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000092f67e05fd20b68b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2 Jun 2023 at 08:33, Fran=C3=A7ois Dumont wrote: > I haven't been able to reproduce so far. > > Here is however a patch that I think will fix the problem. At least > failing tests are UNRESOLVED on my system. > > libstdc++: Fix broken _GLIBCXX_PARALLEL mode > > Add missing include in . > This fixes the broken parallel mode. > > Detect availability of in tests needing it to make them > UNSUPPORTED > rather than PASS when header is missing. > > libstdc++-v3/ChangeLog: > > * include/parallel/algobase.h: Include . > * testsuite/lib/libstdc++.exp (check_effective_target_omp): > New. > * testsuite/17_intro/headers/c++2011/parallel_mode.cc: > Add { dg-require-effective-target omp }. > * testsuite/17_intro/headers/c++2014/parallel_mode.cc: > Likewise. > * testsuite/17_intro/headers/c++2017/parallel_mode.cc: > Likewise. > > Ok to commit ? > Please just add the #include to parallel/algobase.h for now. The effective-target keyword seems reasonable, but "omp" is not a good name. And if we add that dg-require-effective-target to those tests then they don't need to repeat the check in the test itself: #if __has_include() So please just add the #include and then we can revisit the effective-target separately. > > On 01/06/2023 23:57, Jonathan Wakely wrote: > > On Thu, 1 Jun 2023, 21:37 Fran=C3=A7ois Dumont via Libstdc++, < > libstdc++@gcc.gnu.org> wrote: > >> Now I've install OMP and try to rebuild lib to reproduce the failure. >> > > You shouldn't need to install anything, just build gcc and don't configure > it with --disable-libgomp > > I haven't used --disable-libgomp. But maybe when I run configure the 1st > time it tried to detect OMP install and failed to find it as I just > installed it. > I don't know what you mean, because GCC doesn't depend on "OMP". GCC includes its own OpenMP implementation, and installs its own libgomp runtime library to support the -fopenmp flag. It doesn't depend on anything else. Which OS are you testing on? --00000000000092f67e05fd20b68b--