From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8FD4A3858413 for ; Wed, 12 Jul 2023 10:20:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FD4A3858413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689157238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bf1HXzF9kWjw3oPvyZHgdZ0/isnsn7vr1dqKX0jfX50=; b=ACcXNiOLKbWrtsJoQyqofJS0fJu/sNXuPsD58rNch0O402lJDB1hUPMEv4V131Yk76CcpQ wm8gqHr8xyVVqUL31HU3credDCEHGx/zBSeEaRFIG2IILT34qG58sQj3L3iZJ3/8dXfePF s0yIObUg/D2llwZRBfPLdU+IsPgwJ4Q= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-5tYtdPqLNe2au7qYOcitCg-1; Wed, 12 Jul 2023 06:20:35 -0400 X-MC-Unique: 5tYtdPqLNe2au7qYOcitCg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b6ad424a46so65817081fa.3 for ; Wed, 12 Jul 2023 03:20:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689157233; x=1691749233; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bf1HXzF9kWjw3oPvyZHgdZ0/isnsn7vr1dqKX0jfX50=; b=OSdSgyoC1GH72Or3tGQSAJxZbyO7zzXMc0oEtcd6MDQ+/WKgc1JboAbhJEvEvaffOY n9yCKRXQqFNzydofAiZ/0Z+Qx0TYybVQtCq/ZYz7wazOSI3L7zQtoNHG6wpgiA+N+PMd tNTt+WYmNX9nTz+UTNc9ZVDIpdjqdN7KnixnazdpViZKTuaR1BiixV5wXuDPlgfTHCOz y2MCouhUuusVJUcGffH/ZAmkmNCndNiz79flVwEgQnRR0yt4WJ85z8k8KvroWH2daxSy EaKwX+minXtyxBDNRT6bflG9LXydrIGj0yMVG9/33ldqBA4nz9TQBLr+eRBR2scQQJgP wyhA== X-Gm-Message-State: ABy/qLaoPrtFcp5BHjEwJdan6MO+PRttXKK6mXurSk6RSrCWp3YStLlQ GwEr96OSFqHJ9FziNC7uanrfpRikezIl5ua6+GEvLdv7kUYb3eqo+MXyFrb93p9ckqOa/UXgGpk ki4FsLkXQneDYPinzytAMD1+xET0n5B6okUz+aZX8qQ== X-Received: by 2002:a2e:98c7:0:b0:2b7:7c:d5a1 with SMTP id s7-20020a2e98c7000000b002b7007cd5a1mr15555274ljj.23.1689157233671; Wed, 12 Jul 2023 03:20:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGFvaGD8uiZW1ZxblskC2DdQnwYFwjvkV8Ztc5Mv8pofzx37aGSfxytSck9iBJ57JSDd0qgLnhskSzxuS8/Y0k= X-Received: by 2002:a2e:98c7:0:b0:2b7:7c:d5a1 with SMTP id s7-20020a2e98c7000000b002b7007cd5a1mr15555268ljj.23.1689157233523; Wed, 12 Jul 2023 03:20:33 -0700 (PDT) MIME-Version: 1.0 References: <20230624101210.57519-1-kmatsui@cs.washington.edu> <20230708052928.67485-1-kmatsui@gcc.gnu.org> <20230708052928.67485-2-kmatsui@gcc.gnu.org> In-Reply-To: <20230708052928.67485-2-kmatsui@gcc.gnu.org> From: Jonathan Wakely Date: Wed, 12 Jul 2023 11:20:22 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] libstdc++: use new built-in trait __remove_pointer To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 8 Jul 2023 at 06:31, Ken Matsui via Libstdc++ wrote: > > This patch lets libstdc++ use new built-in trait __remove_pointer. > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (remove_pointer): Use __remove_pointer built-in trait. > > Signed-off-by: Ken Matsui OK for trunk after the front-end __remove_pointer is committed. > --- > libstdc++-v3/include/std/type_traits | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 0e7a9c9c7f3..81497e2f3e1 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -2023,6 +2023,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > // Pointer modifications. > > + /// remove_pointer > +#if __has_builtin(__remove_pointer) > + template > + struct remove_pointer > + { using type = __remove_pointer(_Tp); }; > +#else > template > struct __remove_pointer_helper > { using type = _Tp; }; > @@ -2031,11 +2037,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > struct __remove_pointer_helper<_Tp, _Up*> > { using type = _Up; }; > > - /// remove_pointer > template > struct remove_pointer > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> > { }; > +#endif > > template > struct __add_pointer_helper > -- > 2.41.0 >