public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>,
	libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [committed] libstdc++: Fix aligned formatting of stacktrace_entry and thread::id [PR112564]
Date: Mon, 20 Nov 2023 16:50:04 +0000	[thread overview]
Message-ID: <CACb0b4mJByRk+VYMdonb5Z_jkW=vOTZdPsRymya7LM72=8Vx2g@mail.gmail.com> (raw)
In-Reply-To: <20231120161842.B4ED32043D@pchp3.se.axis.com>

On Mon, 20 Nov 2023 at 16:18, Hans-Peter Nilsson <hp@axis.com> wrote:
>
> > From: Jonathan Wakely <jwakely.gcc@gmail.com>
> > Date: Mon, 20 Nov 2023 11:55:22 +0000
>
> > The changelog entry does say "Change compile test to run."
>
> Wow, it's right there.  The doh:est of doh:s on me.  Sorry
> for wasting your time on that.

Heh, no real time wasted, it was useful to mark PR 112541 as affecting
more than just armv8.

>
> > > PS. Sorry, I have no idea why regarding the underlying multi-target problem
> >
> > I have some vague speculation in PR 112541.
>
> From comment #1:
> "It appears that __stacktrace_impl::_S_current returns an
> empty sequence of frames.
>
> It's possible that all the lambda frames are inlined, or
> skip+2 in stacktrace.cc causes us to skip real frames that
> we should keep, or maybe libbacktrace just doesn't work on
> this target."
>
> All more or less likely, with libbacktrace not working for
> three targets maybe less likely.  Or more.
>
> Anyway, if I haven't found time to look at this myself
> within...say two months, I think I'll xfail it for cris-elf.

I hope to have some time to look into the libbacktrace behaviour
myself. I wasn't seeing it on any of the targets I can test myself,
but I recently did a bootstrap+regtest on sparc-sub-solaris-2.11 and
it fails there too. So maybe I'll be able to debug it soon.


      reply	other threads:[~2023-11-20 16:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 17:20 Jonathan Wakely
2023-11-20  2:12 ` Hans-Peter Nilsson
2023-11-20 11:55   ` Jonathan Wakely
2023-11-20 16:18     ` Hans-Peter Nilsson
2023-11-20 16:50       ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACb0b4mJByRk+VYMdonb5Z_jkW=vOTZdPsRymya7LM72=8Vx2g@mail.gmail.com' \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hp@axis.com \
    --cc=jwakely.gcc@gmail.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).