From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 244EE3858C54 for ; Wed, 5 Apr 2023 12:07:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 244EE3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680696471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2i6y5eVQ97jHgpW1h2X+sFd5eEudtGNTqQ5azm7vvEs=; b=AB5ef7R3BmNeuMLOg0zi08JfIgffYYuIkwIUwM9b1IT+RCQas2jjAY0ZZMGaSnFZ1DejQ0 PvBrJNLltqvXbLzw+8Wt+d3W3nGrciJp3xE0MQS0RpUqR5PW71HBFrokt0GxB/+mO7kaol RwxCst6VEIkAfRbRAejHbDTCzm+bXpI= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-8disYuizMkS-mtjaG0WAew-1; Wed, 05 Apr 2023 08:07:50 -0400 X-MC-Unique: 8disYuizMkS-mtjaG0WAew-1 Received: by mail-lf1-f70.google.com with SMTP id t15-20020a192d4f000000b004eb3fa146c4so3706710lft.15 for ; Wed, 05 Apr 2023 05:07:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680696469; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2i6y5eVQ97jHgpW1h2X+sFd5eEudtGNTqQ5azm7vvEs=; b=T9k6H/waQgsR1ReJPcprB2NXKTLtU+7+9l5sn1uhJ1hWQQL2QUV+ci2fH56wfKsadG /WqPQCNpMYqS2L64sh1dY31umGrwZ5nBFuhiEW9yjtAYs/Lp7NhyEDcz900ooXZsgffn PVlBFRV6fFKcNqYUCkKm8DFAIrVhyhgUUs7EhXqgV8SyBU5+56lq2LdYl2oBIkk1aQfZ 6ojC01+qsXgRr8uwYWJ4FNCQrEtVP4o6M2XISrnW16zgVvQlmjmFevGtOKnbd93CosZw 3x08be9RmnJqbxY7Jm/En01vsuofHgUw8mi4Dhbcf8NFeM/K7suke+1XTsZEhoOl2Kd/ SvAQ== X-Gm-Message-State: AAQBX9e49mmJBPG2+0qOeF7dgWGfKWtpV8+jdNU3enEZCeoh53EWwp1c ad8U5VGXzNYhbPlxyWcoWMeE6eHnGQPnu3087I0iN/hHynoF/uS+rEPPJgNMo2c6EfN8aD95eAQ 29XbnUbO4ZW5VTnfZ2W6Sbou+uuHEoIVk9g== X-Received: by 2002:a05:6512:12d4:b0:4e8:3ee1:db14 with SMTP id p20-20020a05651212d400b004e83ee1db14mr1301826lfg.6.1680696469372; Wed, 05 Apr 2023 05:07:49 -0700 (PDT) X-Google-Smtp-Source: AKy350aPe9f4RX+lLklX5NCVOTj8sXdESDiJLU8zOLBiVKl5GGnJDluhpCiIopKWZkcy8U1tXG+2qaaQjtVfdCe/PmE= X-Received: by 2002:a05:6512:12d4:b0:4e8:3ee1:db14 with SMTP id p20-20020a05651212d400b004e83ee1db14mr1301813lfg.6.1680696469079; Wed, 05 Apr 2023 05:07:49 -0700 (PDT) MIME-Version: 1.0 References: <20230404230950.158556-1-arsen@aarsen.me> <20230404230950.158556-2-arsen@aarsen.me> <86v8iaa7ir.fsf@aarsen.me> <865yaaa789.fsf@aarsen.me> In-Reply-To: <865yaaa789.fsf@aarsen.me> From: Jonathan Wakely Date: Wed, 5 Apr 2023 13:07:37 +0100 Message-ID: Subject: Re: [PATCH 2/4] libstdc++: Add a test for FTM redefinitions To: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 5 Apr 2023 at 12:39, Arsen Arsenovi=C4=87 wrote: > > > Arsen Arsenovi=C4=87 via Libstdc++ writes: > > > Good idea. Both the positive and negative cases work when implemented > > like this: > > > > From 98d302bab9a87d3f2daecf9d54d62f33ba216673 Mon Sep 17 00:00:00 2001 > > From: =3D?UTF-8?q?Arsen=3D20Arsenovi=3DC4=3D87?=3D > > Date: Wed, 8 Mar 2023 17:01:24 +0100 > > Subject: [PATCH 2/4] libstdc++: Add a test for FTM redefiniti= ons > > > > This test detects redefinitions by compiling stdc++.h with > > -Wsystem-headers. Thanks Patrick Palka for the suggestion. > > > > libstdc++-v3/ChangeLog: > > > > * testsuite/17_intro/versionconflict.cc: New test. > > I've forgotten to reword this after changing the logic. New message: > > commit dcd7bed33cc274e8f3565ad02fb1fbc04bc845fb > Author: Arsen Arsenovi=C4=87 > Date: Wed Mar 8 17:01:24 2023 +0100 > > libstdc++: Add a test for FTM redefinitions > > This test detects redefinitions by compiling stdc++.h and , > by disabling the system_header pragma on the latter, to allow > warnings in it. Thanks Patrick Palka for the suggestion. > > libstdc++-v3/ChangeLog: > > * testsuite/17_intro/versionconflict.cc: New test. OK for trunk, thanks.