From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 677163857B82 for ; Tue, 9 Jan 2024 22:01:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 677163857B82 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 677163857B82 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704837700; cv=none; b=G/Sxny/51JGMP7RAG9Ft35gBgsYT/Jut3Ib8OfiUXS7bKq5bkwC7S8M8Iwm6rusCMgxuP4rpLIV/YM3q4kGhQ3I0OuNE7r+iBF2CEPzmcdtM52XAPIhKr9Vjiav51RKebM09GsWXKOKN8H6zmqrNfAfcgn0prRKsZD7iZLeXk4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704837700; c=relaxed/simple; bh=LN6V/8Cg0xJ4x5d+W9WjukrtodUpIxE58E/1olBBVsI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=d+s86BzljS2X34PlA+oZHXqZGvJHZTXiaRF0OzAjNkOZ4aOCwkqGSqKVD0dQk2l20VkYypubGNxkaEwW/pq6417qpSVqeJzsp3sq7IZlkk6yHTXKha4QZIDv22b1OtO/Ksptg0tPKnzPjJ4HJiBTkc3/NHchjGX/x3CsVyjMEP0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704837698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+kP6drqxVSL2qXTV99Kuy3qoGHNF7DuzKMgCCH9L/xA=; b=LM6/9X+k4i5IBEaGcrEC5qtfBCRmbvhWQ59X+tL+IkcvLEHx5mc8sqsypjzhK96fknt3G3 7y0NsqaBCNKRwKet4dcqMqrh1NWNvzu0IDwVngRBOuJveLhNI09noVqleng3o61dqvlZpQ gh6MFFdad+/AlzAcLXngfe7NFUg7BUo= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-deC4rlwOPquHebHobqxrLA-1; Tue, 09 Jan 2024 17:01:36 -0500 X-MC-Unique: deC4rlwOPquHebHobqxrLA-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5f69158f32eso47194447b3.2 for ; Tue, 09 Jan 2024 14:01:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704837696; x=1705442496; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+kP6drqxVSL2qXTV99Kuy3qoGHNF7DuzKMgCCH9L/xA=; b=KPp4dv7oM788LKv0iWFzuDNms5seO7KxL+ElswLWujAKRNrvwmtpCGdVAE1tKY8gGf q8kTlYE3wTySK35O+za1yWt0PYdNrfcnwQJmHX7uM80KuZQlXjh6jiVRTYY6i37/zGKN 7SA8ppzcXh1cBtgOF0i7x2x/cDO+VdL8PR4W8omHi5H2G1LETcPKSXgurCBXLNlJksLY 9YLym0vEF0iIJJKnIMOJkhCFgLB+LvjN4TF/Pjvzgk/04HmuKkg2YzzTvwquGe5V0OX8 EgcologLhhKANzBm14/n8t83K4eS4AnjqCR5zxX5S2R2n+FHEICA+ItlDGHUmi/8WWvF 6WTQ== X-Gm-Message-State: AOJu0YwvEMEvaAHSdl5o73TfkaN65FmJhI/ofH4X74Su1NjKVMDjYv8Q JBhbJWXqWZVeKWFW7opgDzWTOAkcNtfBKMZdXIQ+QoKF6wV+hTUGTlSKI24MDcLH14E2iu81/zC /47oJ0TfHTQKS5/fLWdbasab0fTB5mhTGxG6sCRijH6isaESmGw== X-Received: by 2002:a5b:8cb:0:b0:dbe:35ee:7514 with SMTP id w11-20020a5b08cb000000b00dbe35ee7514mr45471ybq.59.1704837696168; Tue, 09 Jan 2024 14:01:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPv4cTDT6T1mJcseOzVLTHfYeW+u+lnRIpZ8+urw20Te0EO8iYuN5A3V2CcbZWWPI2FT7tVNXfpaT8inxqwEA= X-Received: by 2002:a5b:8cb:0:b0:dbe:35ee:7514 with SMTP id w11-20020a5b08cb000000b00dbe35ee7514mr45460ybq.59.1704837695816; Tue, 09 Jan 2024 14:01:35 -0800 (PST) MIME-Version: 1.0 References: <87plyauqmd.fsf@igel.home> In-Reply-To: <87plyauqmd.fsf@igel.home> From: Jonathan Wakely Date: Tue, 9 Jan 2024 22:01:19 +0000 Message-ID: Subject: Re: [PATCH] Fix spurious match in extract_symvers To: Andreas Schwab Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 9 Jan 2024 at 21:47, Andreas Schwab wrote: > > Tighten the regex to find the start of the .dynsym symtab in the readelf > output to avoid matching the section symbol in the normal symtab. OK, thanks. > > libstdc++-v3: > * scripts/extract_symvers.in: Require final colon to only match > .dsynsym in the header of the dynamic symtab. > --- > libstdc++-v3/scripts/extract_symvers.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libstdc++-v3/scripts/extract_symvers.in b/libstdc++-v3/scripts/extract_symvers.in > index 17f0d31bd1c..6bb951c7145 100755 > --- a/libstdc++-v3/scripts/extract_symvers.in > +++ b/libstdc++-v3/scripts/extract_symvers.in > @@ -52,7 +52,7 @@ SunOS) > # Omit _DYNAMIC etc. for consistency with extract_symvers.pl, only > # present on Solaris. > ${readelf} ${lib} |\ > - sed -e 's/ \[: [A-Fa-f0-9]*\] //' -e '/\.dynsym/,/^$/p;d' |\ > + sed -e 's/ \[: [A-Fa-f0-9]*\] //' -e '/\.dynsym.*:$/,/^$/p;d' |\ > sed -e 's/ \[: [0-9]*\] //' |\ > grep -E -v ' (LOCAL|UND) ' |\ > grep -E -v ' (_DYNAMIC|_GLOBAL_OFFSET_TABLE_|_PROCEDURE_LINKAGE_TABLE_|_edata|_end|_etext)$' |\ > -- > 2.43.0 > > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different." >