From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E425F3858D37 for ; Fri, 3 Mar 2023 18:09:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E425F3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677866957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+ijHpSEEjB/E+84KJfxbWrhr+iaCnBtdSA8evHrGOLA=; b=DRPNz2n6oagziK8Esg/bVsLi2hlh8cL2aCZDjOoqdGNYJX5kgMRUCVDTLXubn2KzULvdEI 3LalRFqCe6sxg4tThEif26oQWoCOtg/oR4K/h0UzJORO8gNTIfgVw+9Romvdy/63gZhiPz cGFDupfZ08OELpVQNboVCDVQMF0je9w= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-0U_IHq6vOFa-__sabze4Fg-1; Fri, 03 Mar 2023 13:09:16 -0500 X-MC-Unique: 0U_IHq6vOFa-__sabze4Fg-1 Received: by mail-lf1-f69.google.com with SMTP id y9-20020a056512044900b004b4b8aabd0cso1299194lfk.16 for ; Fri, 03 Mar 2023 10:09:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+ijHpSEEjB/E+84KJfxbWrhr+iaCnBtdSA8evHrGOLA=; b=yih5Ct4NI9jcxq5ZQdtCLei/r3DwO/0uuCKQHca5dvWK7Gg3RJhc2RI9MzTVA/hmlf qXIbYCPoSWPQ+pzAm5FIxxKNJDmiVNPamMG0joE4nyFPzYZDujEb+8hsPTUopVMCZ9rH 6/3Vwn1kVtlmbX0mXMjSr9kZaF2bR8aB81LgSl/OzKEX0Eb9lZ6C8JevZVsMjX5ZL1fu meZ+fxFCva7eLnd+2y38OiZMPOa1ro8hITZDj3OweDEvXOtHMcmSSHVKHj2LXCBqvR9+ l60/C2qwcHABR8ral1UP8lU82RHrOO/h5eQ7SqZS0dj3+gpUHaRyz/hPMkKvQ6rQm009 d8Pg== X-Gm-Message-State: AO0yUKXO3B2dmDzntoxC5CB6RbBAY7fZZKGHl6i/EnR/1m5Ho+d4qBd9 ne0jnqzds280EJ2GUm7I1hssAaRXG5IZDmBaUHJl0Z9nUXvHqGiWWhzoGEoISIVuQetcniuYYrU 2j+5gqSZ8ATx1TcY72Z1VjVlSiBrBABczog== X-Received: by 2002:a05:651c:38d:b0:295:af0c:33aa with SMTP id e13-20020a05651c038d00b00295af0c33aamr829018ljp.7.1677866954835; Fri, 03 Mar 2023 10:09:14 -0800 (PST) X-Google-Smtp-Source: AK7set/XWq0n9R5wXWqwb2UdZQrnKzaOiaNYu+tkMuYAC2rSUHaNW4rgmen2bmd5oPHXruQpyyhFhUb5ZeUxEDYI2WU= X-Received: by 2002:a05:651c:38d:b0:295:af0c:33aa with SMTP id e13-20020a05651c038d00b00295af0c33aamr829008ljp.7.1677866954573; Fri, 03 Mar 2023 10:09:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Fri, 3 Mar 2023 18:09:03 +0000 Message-ID: Subject: Re: [PATCH] [libstdc++] [prettyprint] add local std::string use to more tests To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, tromey@adacore.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000cee12505f602d777" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000cee12505f602d777 Content-Type: text/plain; charset="UTF-8" On Fri, 3 Mar 2023 at 17:50, Alexandre Oliva via Libstdc++ < libstdc++@gcc.gnu.org> wrote: > > We're getting regressions after ugprading to GDB 13 in a few of the > libstdc++ pretty-printing tests. It might seem like a GDB regression, > but that update has a new symbol reader, and Tom Tromey says it > exposes a latent problem in the pretty-printer, namely, when a name is > not defined locally in the local translation unit, GDB will look for > it in other units, and if multiple different definitions are > available, there are no guarantees as to which one it will find. > > Since libstdc++ contains units in which std::string maps to different > types, in order to ensure the tests get the std::string definition we > expect, we need std::string to be present in the debug information for > the test itself, as we already do in other tests. > > Regstrapped on x86_64-linux-gnu. Ok to install? > OK, thanks. --000000000000cee12505f602d777--