From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 611453858D20 for ; Wed, 1 May 2024 13:38:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 611453858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 611453858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714570688; cv=none; b=R8ETXjPiGs+MlAxbgSOe3I+v35Rz/duxHJaYdKuDrC3b0F+S6U2eGCLrwe+m1htdZILitEan4s/cNeHdH4EzGOIIl6jmlAfCkOXAqAWjXonrR+fLcTPDg/SJIVH/oxgWRPe2v95G3TlT7mndSmMJWHJS++oLtMKGBuiJc9ZV2ww= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714570688; c=relaxed/simple; bh=CS7ll5VA5Lttlnb+M1+GaA5PxHwi07NlEZtKqlBD+hk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=eQK33o4QWe6S0kUl6Nwykligr/7DaoSOuLpn/is7zO73+iE95grdOacUS7X+4uD6UPy2dGOJxWfx57x7W/Mkhcvkor8DizrEwoIY1LRloF7gaFF/8Y1yrsciznDpyXfwUNA1r8E5a7UPM5FnAK9Vd0SQu08NxZISB69R3t7ws4I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714570685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pNGao3AI0c+XEHP8+wgCRjRTGFzhZc3t4KHg1aV/rp8=; b=iu+fQnBAOOM/7xSzwauxcZl1uBU/LSu09CyWuxizp5qSiWLnz2lNszW95hJbhMn9H4WqU9 wAZv9kJ9KGMsn6y/wywvVWdkBSAgSZ+h3WsrF+7LY3mWZbTTVKGtvW4ZiYXb9CLCIoEzoq mR/mNG/LttTvBms1YpXPTXN0fZ5W9/s= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-21-senMFOBGPASlK6LTRYsIXA-1; Wed, 01 May 2024 09:38:04 -0400 X-MC-Unique: senMFOBGPASlK6LTRYsIXA-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-61bd64c9eadso58156267b3.3 for ; Wed, 01 May 2024 06:38:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714570684; x=1715175484; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pNGao3AI0c+XEHP8+wgCRjRTGFzhZc3t4KHg1aV/rp8=; b=faiaUEcKY/sMouZW3piG3Jfix5Luu0eaN/Er9pRl/roiLZxg6e0tI+/wFenjOIBHzl HvUuk1V9glwKNGJO6sMHrwP4jaCUmvdAFq8jnKWaQIDRKMa9oXEZU7R1PDJdkYWSbnA2 /oQX/1QYc4cx4SO28sYiv6rtcWZ7JKIR1rnWMXLhwvJVjzdSYOLFbRQFFsMVSM2H8frW w29J9UZXGSb8/6XPdIAdXikbo2DErUyxhKaMWEcEf5OMMfJEe4493LohBn/a5jSBlcLk 7Q29i4nW1JyL/vDtI7DOBOEpWFE2ZOD01CCKiyAFril5hkBSHo71DEjrCiteeZwAT2o9 TxTw== X-Gm-Message-State: AOJu0YxsPOtBuUgakRWhzmmas96cqpmybw0nEkzzJHMgm6KRC+Dq3sAu PZLyWX3WO5KzgWSVsTDdkVWQkWb/d89UeGuPvgo5+3eN89wsxCxEtYQDqOpXo2pb/at+SFVgisJ JbcfxVhRO0u2Iuz48iTY47lh85q3wI0rkXBfwJBXqfsUPbcTouFhMTGcL2zYv+R/2i99Erl2LW8 k5td4GB2Ycq7nVuyn45Y/pEO6tqUJdHoJPvQSC3Q== X-Received: by 2002:a05:690c:4d43:b0:61b:1e81:4eb8 with SMTP id iy3-20020a05690c4d4300b0061b1e814eb8mr2941931ywb.9.1714570683859; Wed, 01 May 2024 06:38:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFp2qTX2rD5+90UVAxMiurjVv4HPV08Yqs2Up2snf1IBYKX0gBqy9zCdH0eNRHZkQR1gfQdxVRrPnmPcnbzZvg= X-Received: by 2002:a05:690c:4d43:b0:61b:1e81:4eb8 with SMTP id iy3-20020a05690c4d4300b0061b1e814eb8mr2941911ywb.9.1714570683431; Wed, 01 May 2024 06:38:03 -0700 (PDT) MIME-Version: 1.0 References: <20240422100454.1607124-1-jwakely@redhat.com> <7e983ffa-33db-428d-82f5-86409613091a@gjlay.de> In-Reply-To: <7e983ffa-33db-428d-82f5-86409613091a@gjlay.de> From: Jonathan Wakely Date: Wed, 1 May 2024 14:37:47 +0100 Message-ID: Subject: Re: [PATCH][wwwdocs] Improve grammar for AVR changes in GCC 14 To: Georg-Johann Lay Cc: gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 22 Apr 2024 at 12:35, Georg-Johann Lay wrote: > > Am 22.04.24 um 12:04 schrieb Jonathan Wakely: > > OK for wwwdocs? > > For me it's ok (I am not a native speaker though, > which is the reason the typos are there to begin with). I've pushed this now. > > Johann > > > htdocs/gcc-14/changes.html | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > > index 9509487c..21d33db8 100644 > > --- a/htdocs/gcc-14/changes.html > > +++ b/htdocs/gcc-14/changes.html > > @@ -696,13 +696,13 @@ a work-in-progress.

> >

AVR

> >
    > >
  • On AVR64* and AVR128* devices, read-only data is now located in program > > - memory per default and no more in RAM. > > + memory per default and no longer in RAM. > >
      > >
    • Only a 32 KiB block of program memory can be used to store > > and access .rodata in that way. Which block is used can be selected > > - by defining symbol __flmap. > > + by defining the symbol __flmap. > > As an alternative, the byte address of the block can be specified > > - by symbol __RODATA_FLASH_START__ which takes > > + by the symbol __RODATA_FLASH_START__ which takes > > precedence over __flmap. > > For example, linking with > > -Wl,--defsym,__RODATA_FLASH_START__=32k > > @@ -715,9 +715,9 @@ a work-in-progress.

      > > href="https://github.com/avrdudes/avr-libc/issues/931">#931 > > can be used. The latter initializes NVMCTRL_CTRLB.FLMAP > > in the startup code and according to the value > > - of __flmap resp. > > + of __flmap or > > __RODATA_FLASH_START__.
      • > > -
    • When AVR-LibC with #931 is used, then defining symbol > > +
    • When AVR-LibC with #931 is used, then defining the symbol > > __flmap_lock to a non-zero value will set bit > > NVMCTRL_CTRLB.FLMAPLOCK. This will protect > > NVMCTRL_CTRLB.FLMAP from any further changes — > > @@ -726,7 +726,7 @@ a work-in-progress.

      > > can be used:
      > >   __asm (".global __flmap_lock"  "\n\t"
> >          "__flmap_lock = 1");
      • > > -
    • When you do not want the code from #931, then define global > > +
    • When you do not want the code from #931, then define a global > > symbol __do_flmap_init and the linker will not pull in > > that code from libmcu.a any more.
      • > >
    • In order to return to the old placement of read-only data in RAM, > > @@ -736,7 +736,7 @@ __asm (".global __flmap_lock" "\n\t" > > functionality. > >
      • > >
    • Read-only data is located in output section .rodata, > > - wheras it is part of .text when located in RAM.
      • > > + whereas it is part of .text when located in RAM. > >
    • The feature is only available when the compiler is configured > > with a version of Binutils that implements > > PR31124, which is the > > @@ -784,7 +784,7 @@ __asm (".global __flmap_lock" "\n\t" > >
    • > > On the Reduced Tiny devices, > > the meaning of register constraint "w" has been changed. > > - It containts now the registers R24…R31 like it is the case for all > > + It now constrains the registers R24…R31 as is the case for all > > the other devices. > >
      • > >
    >