From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 441A83857835 for ; Fri, 11 Mar 2022 18:00:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 441A83857835 Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-zUPtNIXDO-2LSKAIivHKMg-1; Fri, 11 Mar 2022 13:00:06 -0500 X-MC-Unique: zUPtNIXDO-2LSKAIivHKMg-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-2d6914a097cso74553637b3.10 for ; Fri, 11 Mar 2022 10:00:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2bLN8BVcdmJOH//w27q/bJ+TOtU/QeRPvZRXeHd0qEI=; b=meS2HDFcilBXy2BgGbMQp2wNIWtK7CtLh51veNvLPgSjAAQugkYA4q2axD6w6LsIhc StkygMVR2+glOYab558htXgZbmo+IR0HWLUWdYTQzstQFZUzjjAZEVu+bEYD4IDJXXUY BhvFledpgvDq2CzpicWzK5SEgEZUaB+v+s+HNnaCnD6nTnjdB2j2mbOemO2+RwssegMO r+raJyTXm5WxLQ07u9oncjxnhMiYWAS3vKRRf0H0thVLxhi2264LNUcRpVc58k8njoEw 4VwDBURiiWAGRtoWPp98TJpv+yXJUDotGtvpkeGm8UWBFcae1TBOkXyCMiciZ02oTVVg /k1w== X-Gm-Message-State: AOAM530Cxors0hWcVwK6leGGv1KnxF9fHU0GpMAgu0y3XxrNx1ng6lNp aDvjc/OfUKEXvRZsLE70+6oFhjR50T4YcBBRynMev0BLE5i86v9WwJLyOApp9JcSX7m+zjXJJ7n BoDpDgLkBl4PDIiL4JeYMvYEmxUm7RM28pQ== X-Received: by 2002:a5b:988:0:b0:62c:22c0:3765 with SMTP id c8-20020a5b0988000000b0062c22c03765mr9500460ybq.216.1647021605542; Fri, 11 Mar 2022 10:00:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSPJxmkp50FSlrr2J/eS6VgMwvtTL7ETxifR0VKM+jJqcd1Lj3SEUGnTWmstYiARO4dTO10ll6b6VQ9qtROOE= X-Received: by 2002:a5b:988:0:b0:62c:22c0:3765 with SMTP id c8-20020a5b0988000000b0062c22c03765mr9500434ybq.216.1647021605265; Fri, 11 Mar 2022 10:00:05 -0800 (PST) MIME-Version: 1.0 References: <20220310211107.1757824-1-jwakely@redhat.com> <4b5afc64-39f6-db5a-c6ba-144af10c698a@vollmann.ch> In-Reply-To: From: Jonathan Wakely Date: Fri, 11 Mar 2022 17:59:54 +0000 Message-ID: Subject: Re: [committed] libstdc++: Move closing brace outside #endif [PR104866] To: Detlef Vollmann Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 18:00:14 -0000 On Fri, 11 Mar 2022 at 15:35, Detlef Vollmann wrote: > > On 3/11/22 16:12, Jonathan Wakely wrote: > > On Fri, 11 Mar 2022 at 14:28, Detlef Vollmann wrote: > >> With this and the other fix I was able to build the complete > >> libstdc++ for AVR based on AVR Libc 2.0 (plus some ad hoc > >> AVR header fixes) from git master 5e28be89. > > > > Nice. I finally figure out that I need to use --enable-libstdcxx *not* > > --enable-libstdc++-v3 to build for AVR, > Yes, I had the same problem. > A comment in the 'configure' script still says libstdc++-v3 Yes, I have a patch to fix that. > and in the configure docs at > > or > > there's neither :-( > > > and now I get errors due to > > EOVERFLOW being undefined. Is that what you fixed? > One of them. > > > We should make that work. Arguably, all values of std::errc should > > exist, even if the OS doesn't provide a constant. We could > > define the missing ones ourselves, choosing numbers > 1000 (and hope > > the OS uses small numbers for its own errno values). > I simply defined all that were required. > > I've attached a tarball with all my header fixes. Thanks. Now I'm getting a build failure because libtol wasn't created in the avr/libstdc++-v3 directory of the build tree, but I'll have to look into that next week. /bin/sh: ../libtool: No such file or directory > To get them picked up while compiling libstdc++ I had to > put them into ${prefix}/avr/lib/include. > > But these are really ad hoc, some of the problems I think should > be fixed in the libstdc++ sources. > E.g. I think it's wrong to expect that specific functions are > available if a respective header is available (e.g. close() > in unistd.h). Yes, that was me being lazy.