From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 909503858D39 for ; Sat, 11 Nov 2023 00:43:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 909503858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 909503858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699663396; cv=none; b=gOrPsvxTrHE77o/avh2dhaYQgFn1LQ08nQn2VEBVSq4vj3dLcarl2senri3VeKq1p7JqADEqgoSjk/Op70r01fdHE7qLNkFM6ashxcR60Xr4TpuEtSZcYB7D9EJFO9fDcsXfE2VywLy1tPePfjLsfyzWPZgfq9harwuqjqPQan8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699663396; c=relaxed/simple; bh=PxtiPIcVaEcaC4+RyNarSuWK3c0O+kTjkNKGLz12yro=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=SrANeJX3TnPiw7tV8PDO2dKdqnBmZheCB/ZFNmE7poAV+3BoTbl/ULy0Y6OToPUiHhafkHsVx33Yb5ylk4IXL1wyOaoxGXP177XTuzmgZUROIErrgSVAX78FA90fNxODLLHLL6qpLbvZ8/mBpZTD/DRaTyyNu09kii/Vp7YRBYs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699663393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PxtiPIcVaEcaC4+RyNarSuWK3c0O+kTjkNKGLz12yro=; b=T+UzhYZv5RUtUa5DLEruZzBYv39dsDX0mGies5KhxQOgHKY03Yg9hGt+Jgk0/DjkqppBHb SgPDV4GGGZgFeBLTa2nFHpFOJHXV+kZ7OZvPSWusJbH+a7xywoQ9Rc2KVQ29C5jkV4kj0E VUQzEa8RoYtK8smXJF4VzUPPeY2yj3I= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-bBn8BHS2N7-9zmPy66gaSA-1; Fri, 10 Nov 2023 19:43:11 -0500 X-MC-Unique: bBn8BHS2N7-9zmPy66gaSA-1 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-da040c021aeso3103392276.3 for ; Fri, 10 Nov 2023 16:43:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699663391; x=1700268191; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PxtiPIcVaEcaC4+RyNarSuWK3c0O+kTjkNKGLz12yro=; b=aKsWPZhy3jaI+tdU961r6l+Nv0Lm1UjAkruRfL0imDZultJuW2e+kAxqwwHihUQ7dk 82QNuemUmZVDyZ5NY2AMC5R3B2rusQSqe5QdBYsNe4B5lk30gF9ld2DzH3aowL4VokYe 7s6H7xkYml4ECW3tib2RITqgyVhXsiddK7V4ELAwx8VRFgTYzopNxXa9422Ck8L7vlsO rxW12OQvLZVparpfEA+Hkj195syKlTODQz+ShIaTjD7YN2zm3vl0J4200K/GXRXcpSI4 lCW+80dhntFbgRWUGMJ7JjWmdkddXtkGigy8WFN2LKzXSbzLbNY9378Q5HBCBxh6WeXB o1Sg== X-Gm-Message-State: AOJu0YzUVANJriu30rqR6Tdo9JnRc7dNNS6/WjeO9UIxP4hwnnbrUD1r WBnhvOjUdYaV1+GOCsv/Asu62rnEzaCEkerwrwx/KYQ62xYyR9/4QywQ8/1uoalQslYHyV1thx+ suz4zHcysSm2sy1V3G5wpLWbI8CFHZoda0w== X-Received: by 2002:a25:b28e:0:b0:da0:9735:b012 with SMTP id k14-20020a25b28e000000b00da09735b012mr630480ybj.11.1699663391130; Fri, 10 Nov 2023 16:43:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEiqEjlt4SH3juobKxBjlWEN7DAWtAsvQxVnPzvQwwgJpQPeNC6UJKXo28fAAottwM5YptbeZZZCtFpf23VjBg= X-Received: by 2002:a25:b28e:0:b0:da0:9735:b012 with SMTP id k14-20020a25b28e000000b00da09735b012mr630476ybj.11.1699663390907; Fri, 10 Nov 2023 16:43:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Sat, 11 Nov 2023 00:43:00 +0000 Message-ID: Subject: Re: [Ping][PATCH] libstdc++: Add missing functions to [PR79700] To: Nathaniel Shead Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I've finally convinced myself that this patch is OK, because we provide stub versions of all the functions being declared here. So if a target is missing them, we provide them anyway. That happens to be broken for the avr target, but that defaults to --disable-libstdcxx anyway. I've pushed the patch to trunk - thanks for the work on it! On Wed, 17 May 2023 at 11:07, Jonathan Wakely wrote: > > > > On Wed, 17 May 2023 at 10:38, Nathaniel Shead = wrote: >> >> On Wed, May 17, 2023 at 10:05:59AM +0100, Jonathan Wakely wrote: >> > On Wed, 17 May 2023 at 09:37, Nathaniel Shead wrote: >> > >> > > Now that GCC13.1 is released is it ok to merge? Thanks! >> > > >> > >> > Yes, I've been testing this locally, but I think it needs more work (s= orry!) >> > >> > Looking at it again, I'm not sure why I asked for the additional tests >> > because if they fail, it's a problem in libc, and there's nothing we c= an >> > actually do about it in libstdc++. We certainly do want std::expl(0.0L= ) to >> > return the same thing as std::exp(0.0L), but if it doesn't, we'll just= have >> > a libstdc++ test failure caused by a bug in libc. But you wrote the te= st >> > now, so let's keep it. If we get failures for the test it will allow u= s to >> > inform the relevant libc maintainers that they have a bug. >> >> Sounds good. >> >> > Also, since you're contributing this under the DCO terms the new test >> > should not have the FSF copyright header, unless it's a derived work o= f an >> > existing test with that header (and in that case it should retain the = dates >> > from the copied test). I don't actually bother putting the copyright a= nd >> > license header on new tests these days. There's nothing in that test t= hat >> > is novel or interesting, and I think it's arguably not useful or meani= ngful >> > to consider it copyrighted. >> >> Makes sense, I was just copying from other tests in the directory. I'll >> keep this in mind for the future, thanks! > > > Yeah, we have a mix of tests using the old conventions (with copyright an= d GPL headers) and new conventions (don't bother, they're not really meanin= gful on tests). > > We're unlikely to *remove* the copyright notices from the old tests, beca= use that would require all sorts of legal wrangling, and it's not clear tha= t the copyright holder (the FSF) would agree to it anyway. > > > > >> >> > Finally, and most importantly, the new using-declarations in a= re >> > not guarded by any autoconf macro. That will break targets without ful= l C99 >> > support, e.g. djgpp declares acosf but not acosl, so the new >> > "using acosl;" would be a hard error as soon as is included (a= nd >> > might even prevent GCC building on that target). So I think we need a = new >> > autoconf check for the existence of those functions. I'm in the proces= s of >> > reworking the autoconf macros for (due to PR 109818), which is= why >> > I didn't address it for this patch yet. >> >> Ah, I see; yes, that would be a problem. I'm not very familiar with >> autoconf, so thanks for working this out. Let me know when you've done >> that if there's anything else I should do for this patch. > > > I hope to have an updated patch by next week, so I'll let you know once t= hat's ready. Thanks for your patience and for pining the patch. > > >> >> > > >> > > On Tue, Apr 18, 2023 at 6:48=E2=80=AFPM Jonathan Wakely >> > > wrote: >> > > > >> > > > On Mon, 17 Apr 2023 at 09:11, Nathaniel Shead >> > > wrote: >> > > > > >> > > > > Hi, just checking whether there were any issues with this patch? >> > > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612386.h= tml >> > > > > >> > > > > Otherwise I assume it won't be in GCC13. >> > > > >> > > > That's right, it's too large and invasive a change to get into GCC= 13 >> > > > when only submitted in February, sorry. I'll merge it to trunk onc= e >> > > > GCC 13.1 is released though. >> > > > >> > > >> > > >>