From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CB3693858C2C for ; Fri, 18 Mar 2022 10:16:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB3693858C2C Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-597-J0kG2fkQOP-ntgjtATJpKA-1; Fri, 18 Mar 2022 06:16:37 -0400 X-MC-Unique: J0kG2fkQOP-ntgjtATJpKA-1 Received: by mail-yb1-f198.google.com with SMTP id k68-20020a252447000000b00633be107f28so790111ybk.4 for ; Fri, 18 Mar 2022 03:16:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GG/cPmA/AuF+V65krKDGK6Fnu6O8zhJrFVhZRpVa9tA=; b=M+5Uu+AhunB3/yG2iSiK2qzlbBpgaJoNRS0TxrkwBObCIGJn2D0zvtkFpuaUywcs+G oQfGVamfYj0Ak8OCA6mCRfdkC66ZEd5vJjnFpvHerX7ECfE8ddud5/cMLRW9blyZ5bl3 RL0oqIe05wSlp1rfkPXiuAggRN08nCzQw9hHJa5z+lRjh+oIyBiLR/syYy5mZncrhyfx yw7hLpy0gJbyw9mI+Nj/5mqW+Cs7lIUkiFbW+n2pcNnyH/M0dgjFaqAX4E9zhy9xcB54 K6fo7sDFQpuj4xUIqcVzeDfCdRJ9stJ75sZQBb1PccX+UXfRsQcxyI+PW+2enKJ4tK94 Vtkw== X-Gm-Message-State: AOAM530gBUPH66Jr/wpADElN5SwnyYhwyTf1csEZc6KHvS/MorlkUxjh GmqF/9Ihqo3ptpEfjdYWOayPZ1GeSUH3WQPXyKScNY+re+NpCSfS3Fo5+0rYd0eeNbCHDDEBp6p eSK+PC+WfQv2XVJssp6sSHocL2La8cBf8YA== X-Received: by 2002:a25:fe10:0:b0:625:262f:e792 with SMTP id k16-20020a25fe10000000b00625262fe792mr9062439ybe.365.1647598596621; Fri, 18 Mar 2022 03:16:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+GSTzSr9pkU/jlC6unzetBTuJsuTUv2RrlXs6ORqkTawI02eBcfh2+J/N/F7HB3IJON7U3B1zglSEiul0mGU= X-Received: by 2002:a25:fe10:0:b0:625:262f:e792 with SMTP id k16-20020a25fe10000000b00625262fe792mr9062426ybe.365.1647598596425; Fri, 18 Mar 2022 03:16:36 -0700 (PDT) MIME-Version: 1.0 References: <20220317190133.415743-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 18 Mar 2022 10:16:25 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Reduce header dependencies from PSTL headers [PR92546] To: Thomas Rodgers Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 10:16:39 -0000 On Thu, 17 Mar 2022 at 20:44, Thomas Rodgers wrote: > > Looks ok to me. I just am curious, does the change to src/c++17/fs_path.cc need to be part of this change (It's not obvious to me that it is related to the other changes in the patch). It's related. fs_path.cc uses std::array but was not including directly, it was accidentally relying on it being there via . After this change, doesn't include , so doesn't include and so fs_path.cc needs to be fixed.