From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6CFFC386D62F for ; Wed, 10 Jan 2024 21:22:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CFFC386D62F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CFFC386D62F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704921761; cv=none; b=QRRf32o2zSZOc/HDB2TzALfCwSLyR+dMCqLghRN5EbDuLlVQ452tZPRhPWhC9r6qA6WdBr89o6uwlfSesNcpCLVG9B+I/LdLXFrxwOnNlcXXsF578jaxn1FTJWRz9EAewI6yGGkgHm/YyNc/B/loOVs1EXodPM7JEJZ9BQKIbgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704921761; c=relaxed/simple; bh=diDpP+/sqtsytjrEwSzZIaWp/2vWA2S+ZWUUG2Y+b1U=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=dlsfwMlLLTmWLkB6V8OI05FCLnAa6xVh4mfVdV56+PxkwIQmXW9feayT+sTcTR6MrWObTExkVXEFPMTKpWyvGQrQqqbWeTuMZP8ExYVOgEe3EtTsnScymf2od7UKM3ZcdyqsLKVzvoxAtNxmDuJuHHLZiku8DzPREIq7h+1DbFQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704921760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1dt1QeD+8PGaec85YytKmi34ENhfwnsPuQ3MY1vdEwg=; b=iwe+187kFM8YX0EPfWcHexolwZ6bwk9ULGYj44ZsUgwCFrxrmdpEfex2raaUohfa8NGCmn hGVrYDxZmovk258zLzGX6B9HkdrvVyzC42YbJxU2v89mUUYgyZxY3fuvUB0c/CA9p4w4qz owQLzDSX7I/aqeV6h/eNnyktU0ZE/F4= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-dA51zmvUPXaIyeqDUrBjXQ-1; Wed, 10 Jan 2024 16:22:38 -0500 X-MC-Unique: dA51zmvUPXaIyeqDUrBjXQ-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5e9074bb7c5so68280717b3.0 for ; Wed, 10 Jan 2024 13:22:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704921757; x=1705526557; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1dt1QeD+8PGaec85YytKmi34ENhfwnsPuQ3MY1vdEwg=; b=KyISXXw/BaZf4Jw3qsGOoIwkyC9PjjXfPbKuTXvYV1mFLcITDXaZT4yhm5wayDQvq9 +aElgma3AmSrk7cS6aLwc+dWodlQ35DyKpXD4qN84M0qKnm5t2+U/zHPQm0HPuQDMWim 8lxYszy2bw/HmDjnjiUkCGsQXbMdJl7heKaYXsuD4Ay4PDBKCmJOHVpqE8XWbv97FiYG +n7D755LKuSaBdYj1tTvXXMM/s3ozqur3mqs7wct2VGUKlb/8oRyakLV6zPTwJHZLvx/ moJanaAeCBN1STjWsrC29tKP1cUOig5MZpBYVwqn72itfdeGhpqjGXS3EqzJNIV/Fugw s39w== X-Gm-Message-State: AOJu0Ywne1OCRs6idrJofS/PC5w75DHtBLv4Dt457qd4dL4FBcFgi8Xc Nbp7lRYArKfSMR1pmuPxSZ0Dgwe3mNinKqqQzQIo4J26obEEmneCfRLrZu2tilVeXOY1U3E4DvG TSft9YK/S6+nL4Y33H8Ggn/2jOlCZchEMTb2DyhmKWg== X-Received: by 2002:a05:690c:b89:b0:5d8:d93:f02f with SMTP id ck9-20020a05690c0b8900b005d80d93f02fmr246829ywb.87.1704921757180; Wed, 10 Jan 2024 13:22:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQsWRat1bs2wylFMIQb3uZ0gHw0eNkp5ttA8HqFf+eYeuMAYN8arpOU2yQYEiYYbJNjhxephIfvHet3lbK89M= X-Received: by 2002:a05:690c:b89:b0:5d8:d93:f02f with SMTP id ck9-20020a05690c0b8900b005d80d93f02fmr246823ywb.87.1704921756965; Wed, 10 Jan 2024 13:22:36 -0800 (PST) MIME-Version: 1.0 References: <20240110194031.2384005-1-kmatsui@gcc.gnu.org> <20240110194031.2384005-11-kmatsui@gcc.gnu.org> In-Reply-To: <20240110194031.2384005-11-kmatsui@gcc.gnu.org> From: Jonathan Wakely Date: Wed, 10 Jan 2024 21:22:21 +0000 Message-ID: Subject: Re: [PATCH 10/14] libstdc++: Optimize std::is_unsigned compilation performance To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-15.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 10 Jan 2024 at 19:41, Ken Matsui wrote: > > This patch optimizes the compilation performance of std::is_unsigned > by dispatching to the new __is_unsigned built-in trait. OK for trunk (if the new built-in is approved). > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_unsigned): Use __is_unsigned > built-in trait. > (is_unsigned_v): Likewise. > > Signed-off-by: Ken Matsui > --- > libstdc++-v3/include/std/type_traits | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 6294f5af533..4bcfb1389e3 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -987,10 +987,17 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > { }; > > /// is_unsigned > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_unsigned) > + template > + struct is_unsigned > + : public __bool_constant<__is_unsigned(_Tp)> > + { }; > +#else > template > struct is_unsigned > : public __and_, __not_>>::type > { }; > +#endif > > /// @cond undocumented > template > @@ -3413,8 +3420,14 @@ template > > template > inline constexpr bool is_signed_v = is_signed<_Tp>::value; > + > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_unsigned) > +template > + inline constexpr bool is_unsigned_v = __is_unsigned(_Tp); > +#else > template > inline constexpr bool is_unsigned_v = is_unsigned<_Tp>::value; > +#endif > > template > inline constexpr bool is_constructible_v = __is_constructible(_Tp, _Args...); > -- > 2.43.0 >