From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6322E3858002 for ; Fri, 3 Mar 2023 17:52:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6322E3858002 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677865959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xXEl9BxYjPO6qTrgaEG0Hu5vBG+FG7eIkML7+itW4Zo=; b=ZrjLxraBn3uRMkBhZZGQAto8GF7v7EjwIQXLwuvVFcrCc5An7gn7027/mDNg2o2FpxBJRg 2p0MbFA3JKBaU2q9jbZAuE5PW/I227FBshPuDbO1c+Zz1TDZ8wfnStwpdp/MxfSLzLMmg1 0Gn5KgtCgQo11OpS9XwWYbzsKXqe6eI= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-Jbk2PKroPx20Dua1S0o8Gw-1; Fri, 03 Mar 2023 12:52:36 -0500 X-MC-Unique: Jbk2PKroPx20Dua1S0o8Gw-1 Received: by mail-lj1-f197.google.com with SMTP id y8-20020a2e3208000000b002934f71de00so842464ljy.13 for ; Fri, 03 Mar 2023 09:52:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xXEl9BxYjPO6qTrgaEG0Hu5vBG+FG7eIkML7+itW4Zo=; b=0taNFiSlvarSyFO6JG4UbVumQ88B+6oSyn8b8i9qmszOYl9t6d40bP3pDS7bbv88Kl 3uLRJUHaZw458uvnvWPXz6KhAVNWzIHrOVMtzcLQ2t+r4knYoEaZI7DIem3Rt7ZAWE03 A8BZqa5Eav5iF/NmdE3xFNx8ZlwbpQlhqG+OI8wfbgcaBF4GWGDXTPqZSPGivuwS2hUg hjnYGUY/cHcd/JO8anntChFZ+Zit7Gfm7bmPgPDK5oVLeOUviuqUBEPgW4Qlb9bLj6QC RqWYGgKF5kkNAncAnDTjTeRrl5WpnpcI038HeI9Wtrt87R3iA2+zQole3R9Dfcy8jzcx uOJg== X-Gm-Message-State: AO0yUKWXP6F0BP7gfLn5jmYbOYXwAZbCU1U3c6Z60Y4jvdXLJMaqLBbB iP/UJWNmY2rrpafaBq83PTporZ7PWCCiARMQ/SHsjJRfK8efDy9QvB+87zrbTzX2DTogSxEgDZ9 gNiHa3SkVHar263awJtsGLbHDlLLgeR9e+A== X-Received: by 2002:a19:7404:0:b0:4db:173e:812a with SMTP id v4-20020a197404000000b004db173e812amr916828lfe.8.1677865955548; Fri, 03 Mar 2023 09:52:35 -0800 (PST) X-Google-Smtp-Source: AK7set/zp2/UTUsgmXqRECL2YDycIDOEPqB8VShExKa87wjVbdfQi6LigTxa0IE59uQxfvv0uojvX5PO3QbLNSq+a5I= X-Received: by 2002:a19:7404:0:b0:4db:173e:812a with SMTP id v4-20020a197404000000b004db173e812amr916824lfe.8.1677865955252; Fri, 03 Mar 2023 09:52:35 -0800 (PST) MIME-Version: 1.0 References: <20230303164439.1625702-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 3 Mar 2023 17:52:24 +0000 Message-ID: Subject: Re: [PATCH] gcc: Adjust gdbhooks.py VecPrinter for vec layout changes To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000003e69c205f6029ca5" X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003e69c205f6029ca5 Content-Type: text/plain; charset="UTF-8" On Fri, 3 Mar 2023 at 17:01, Jakub Jelinek wrote: > On Fri, Mar 03, 2023 at 05:45:59PM +0100, Jakub Jelinek via Gcc-patches > wrote: > > On Fri, Mar 03, 2023 at 04:44:39PM +0000, Jonathan Wakely via > Gcc-patches wrote: > > > OK for trunk? > > > > > > gcc/ChangeLog: > > > > > > > Please add > > PR middle-end/109006 > > here > > > * gdbhooks.py (VecPrinter): Adjust for new vec layout. > > > > Ok with that, thanks. > > Though, trying it on another vector it doesn't work in that case. > Testcase: > int > foo (void) > { > return 1; > } > gdb ./cc1 -quiet -O2 test.c > b pass_reassoc::execute > r > p debug_bb_n (2) > p $1->preds > (gdb) p $1->preds > $2 = 0x7fffea2d1f50 = { address 0x100000058>} > (gdb) p $1->succs > $3 = 0x7fffea3010a0 = {} > > But if I try to print it the hard way: > (gdb) p ((edge_def**)(&$1->preds.m_vecpfx+1))[0] > $4 = 2)> > (gdb) p ((edge_def**)(&$1->succs.m_vecpfx+1))[0] > $5 = EXIT)> > Here's a fix for that testcase: --- a/gcc/gdbhooks.py +++ b/gcc/gdbhooks.py @@ -462,10 +462,13 @@ class VecPrinter: m_vecpfx = self.gdbval['m_vecpfx'] m_num = m_vecpfx['m_num'] typ = self.gdbval.type + val = self.gdbval if typ.code == gdb.TYPE_CODE_PTR: typ = typ.target() + else: + val = val.address typ = typ.template_argument(0) # the type T - m_vecdata = (self.gdbval.address + 1).cast(typ.pointer()) + m_vecdata = (val + 1).cast(typ.pointer()) for i in range(m_num): yield ('[%d]' % i, m_vecdata[i]) --0000000000003e69c205f6029ca5--