public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH RFC] c++: use __cxa_call_terminate for MUST_NOT_THROW [PR97720]
Date: Thu, 8 Jun 2023 14:13:38 +0100	[thread overview]
Message-ID: <CACb0b4n-Zbs8qvKaTh-c6WD5Cry5APoRiZ3RXGrxE4v4pd_FRA@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4=DsAOO8DEqmprx8M6X1jRwKYektT4Jjcsc1+rbd5m-Gg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

On Fri, 26 May 2023 at 10:58, Jonathan Wakely wrote:

>
>
> On Wed, 24 May 2023 at 19:56, Jason Merrill via Libstdc++ <
> libstdc++@gcc.gnu.org> wrote:
>
>> Middle-end folks: any thoughts about how best to make the change
>> described in
>> the last paragraph below?
>>
>> Library folks: any thoughts on the changes to __cxa_call_terminate?
>>
>
> I see no harm in exporting it (with the adjusted signature). The "looks
> standard but isn't" name is a little unfortunate, but not a big deal.
>

Jason, do you have any objection to exporting __cxa_call_terminate for GCC
13.2 as well, even though the FE won't use it?

Currently both gcc-13 and trunk are at the same library version,
libstdc++.so.6.0.32

But with this addition to trunk we need to bump that .32 to .33, meaning
that gcc-13 and trunk diverge. If we want to backport any new symbols from
trunk to gcc-13 that gets trickier once they've diverged.

If we added __cxa_call_terminate to gcc-13, making it another new addition
to libstdc++.so.6.0.32, then it would simplify a few things.

In theory it could be a problem for distros already shipping gcc-13.1.1
with that new libstdc++.so.6.0.32 version, but since the
__cxa_call_terminate symbol won't actually be used by the gcc-13.1.1
compilers, I don't think it will be a problem.

  reply	other threads:[~2023-06-08 13:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 18:55 Jason Merrill
2023-05-26  9:58 ` Jonathan Wakely
2023-06-08 13:13   ` Jonathan Wakely [this message]
2023-06-08 14:03     ` Jason Merrill
2023-06-09  9:02     ` Richard Biener
2023-06-09  9:06       ` Jonathan Wakely
2023-06-09  9:09       ` Jakub Jelinek
2023-06-09 12:15         ` Jonathan Wakely
2023-06-02 16:56 ` PING Re: [PATCH RFA (tree-eh)] " Jason Merrill
2023-06-05  6:09   ` Richard Biener
2023-06-05 19:10     ` Jason Merrill
2023-06-03 14:33 ` [PATCH RFC] " Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACb0b4n-Zbs8qvKaTh-c6WD5Cry5APoRiZ3RXGrxE4v4pd_FRA@mail.gmail.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).