From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 486523857400 for ; Tue, 7 Mar 2023 21:54:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 486523857400 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678226063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8vGoR1NPpWwCqTwHpYLX77DREumdurJP1xE6HMWWiqw=; b=Y6pXTE7kPSkp/8bu0jNdGFRkCGskZZdlvShHWJerL8m5GKtf8XkWmDHAniF2yYW9ueafDv MiH6wHT5jCHBeXaZ/txKbv5qz2BGlkpxdKPRzoER7MdP1EmNOi9Mir0bWJZgxLfArwRjn6 Iydq8hgMIjoNhrx2reh7upB9pxK01bM= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-Tjt_T5wvM4W4VIOV2ziPHQ-1; Tue, 07 Mar 2023 16:54:21 -0500 X-MC-Unique: Tjt_T5wvM4W4VIOV2ziPHQ-1 Received: by mail-lj1-f199.google.com with SMTP id y15-20020a05651c220f00b00295c398ba39so4689549ljq.11 for ; Tue, 07 Mar 2023 13:54:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678226060; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8vGoR1NPpWwCqTwHpYLX77DREumdurJP1xE6HMWWiqw=; b=T0NtOP305tOKO28HEc/hTht92qyRxcpL+thRgPLKnzI7qSiwD1Pua4IOaYYr0P8vmp MNpTrLJV/NIejNgualeD6wA1kLvNTZTTV6rOJ5u6qnDY3b6nye2MA/kqAFJyeJCeFDRi zA3D64M8+fqoSZwClYOJyNzx7Gs4WBDn/9jm/GlxqhtuI3XLy69lFuieQ8vQ5suNUfem woZx5HDaAnK7PbSQ9CLRYmV2G30RvWWn+3wgAAX7mW7ep50nE6cLYcg5AGUNGR9NcXL6 B4dH0LhFddPkTTti6aBjp8OPAV7mjmR3R/+agPxqKG5YXtdmjIEeO+2wA+t8s1h32r9p XtqQ== X-Gm-Message-State: AO0yUKUwBNr+6ZYWO3HhCDAD7xwK66KVVCIBb+GRw1Yp1FjogxzmRxgg 5uliwirL9rn4Y317CPfgatGa/0DBLg6kbZCsdDhIk8gj93C/i09ejbx5pJO+xCcn6SlFuddQ2SC dWT5PAZl5898gnJjJTi9OWm63Ao8zkO68LA== X-Received: by 2002:ac2:4c13:0:b0:4dd:a4c5:2b42 with SMTP id t19-20020ac24c13000000b004dda4c52b42mr4862224lfq.8.1678226060133; Tue, 07 Mar 2023 13:54:20 -0800 (PST) X-Google-Smtp-Source: AK7set9KZymuGH8EUeewk4QSfr1TlhDtuTc9aPf723QBthaxjvKz3C+dbWON/2fFEajQGVuGHB+Oh/gCHWp0c0bXU1c= X-Received: by 2002:ac2:4c13:0:b0:4dd:a4c5:2b42 with SMTP id t19-20020ac24c13000000b004dda4c52b42mr4862218lfq.8.1678226059883; Tue, 07 Mar 2023 13:54:19 -0800 (PST) MIME-Version: 1.0 References: <20230306101121.3CFDA13A66@imap2.suse-dmz.suse.de> <758f3df6-7d0c-0712-fd79-b6e391cb402d@ispras.ru> In-Reply-To: From: Jonathan Wakely Date: Tue, 7 Mar 2023 21:54:08 +0000 Message-ID: Subject: Re: [PATCH] [RFC] RAII auto_mpfr and autp_mpz To: Alexander Monakov Cc: Richard Biener , gcc-patches@gcc.gnu.org, Jakub Jelinek X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 7 Mar 2023 at 21:52, Alexander Monakov wrote: > > > On Tue, 7 Mar 2023, Jonathan Wakely wrote: > > > > Shouldn't this use the idiom suggested in ansidecl.h, i.e. > > > > > > private: > > > DISABLE_COPY_AND_ASSIGN (auto_mpfr); > > > > > > Why? A macro like that (or a base class like boost::noncopyable) has > > some value in a code base that wants to work for both C++03 and C++11 > > (or later). But in GCC we know we have C++11 now, so we can just > > delete members. I don't see what the macro adds. > > Evidently it's possible to forget to delete one of the members, as > showcased in this very thread. But easily caught by review. > The idiom is also slightly easier to read. That's a matter of opinion, I prefer the idiomatic C++ code to a SHOUTY MACRO.