From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 41A2038582B0 for ; Mon, 4 Dec 2023 12:15:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41A2038582B0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41A2038582B0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701692136; cv=none; b=qMLXEQx7JOJhbMtM9D/VI92xVdIhpXblr0YY4n67eFNQi96ZMb1lnD0+b0Wnoe4lMWBhyIrU1fx89CzLcOa91q4TO9VdvPd3TFkYxzmzp9nIFRr7pZ//8XsVDtFamq+GQXTPU171ygp+iv3s7sJuZr/KWJ/nsv9kXIQfaZ79nz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701692136; c=relaxed/simple; bh=JElCiItRbkWFXSy99Uy0gigx8sgttKCIOU7RaN7NClI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=RmzpCwksc+lt2Ao7KtAdc/RaVdzHJs/LvDudn6rs38SmTF15sdb1NbGUTfAFSNvZhtUuKxbI7tWNGDU2ALw0TrWQR/54Ve+Ji6apgYbKpcMtIWl+kGkIS+kv2ZimZ1UOg0poRlBXmIJQbS8CjVKi+L71se4BFnVnpcjTRgRKPJ8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701692127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JElCiItRbkWFXSy99Uy0gigx8sgttKCIOU7RaN7NClI=; b=Vbvm+uv0/khYXSa+KFUgzOT1+j1ldVot0VSATvs5ztdTm0ltxoRjevlc86CTufjvpgZxPf 7qrLzQEalS16FS1zkpehIcBxJg2qh8//V41qW0CcOvTX5hp5IJL0vCoI+lsYoTls35iYFC i5iSkUHz5n02SeWexPNQ7NEhBEyTLdU= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-3C4I8p3INoukGF1o1Dggsw-1; Mon, 04 Dec 2023 07:15:26 -0500 X-MC-Unique: 3C4I8p3INoukGF1o1Dggsw-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5d351694be7so66293307b3.3 for ; Mon, 04 Dec 2023 04:15:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701692126; x=1702296926; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JElCiItRbkWFXSy99Uy0gigx8sgttKCIOU7RaN7NClI=; b=i0QMJ1MbKYwYwhSbVU2K+DRYQY1Z2O2LIVZks8RdqPptIWkSEQzFTr84N3rRsS603X oqZUeQJEVEaewuTinZx+qP7LAyR9TwptLgYG7HyLo2L6wOl4nOfOZb4HM25z52JL62jN qLCAJpTZDWx2DzzSXkljQBeTrqPm9WLlCgNUkl/JaoUvyHHitNQAQFxFIerTKUzyXnNV oxW145BZWXJUPX6FcPJUFXNg/0ZPVnfzq33iG14ZtOWbG/RG79DIjAPiQTmC5Qr1+GG5 I2WK2c/TKdI27FV8pCeSaLUOPDioxEyeaWcqYY3BJoEwKw8S2APV5TW3Rl1kdHF/rUD4 rexA== X-Gm-Message-State: AOJu0YxoHq7RIJfTOHAQWcOrKadFuJfrqdrZCObX4tTgZPxJOHgN8JiS TXIZv87X8z+WMqbxDGdl/6pC/1bU7W9nvya0aEGBWnwqplFDTXgzEitWmgfXTe1E6JCz7KEYhsT Cmqr8vdvp/yFQHsAztW+o2K3AxGK7VQ0Y9A== X-Received: by 2002:a81:a082:0:b0:5d7:1940:b396 with SMTP id x124-20020a81a082000000b005d71940b396mr3557038ywg.98.1701692126312; Mon, 04 Dec 2023 04:15:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEUjbWJvzxO7Mtxx5uS5KuJgiQGNerq5sBMM2drkoFNtlFlfOy94WA1pImNp99BlG5L1guQXoq+RCu50RHWoyg= X-Received: by 2002:a81:a082:0:b0:5d7:1940:b396 with SMTP id x124-20020a81a082000000b005d71940b396mr3557032ywg.98.1701692126140; Mon, 04 Dec 2023 04:15:26 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 4 Dec 2023 12:15:15 +0000 Message-ID: Subject: Re: [PATCH] driver: Fix memory leak. To: Costas Argyris Cc: gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 2 Dec 2023 at 21:24, Costas Argyris wrote: > > Use std::vector instead of malloc'd pointer > to get automatic freeing of memory. You can't include there. Instead you need to define INCLUDE_VECTOR before "system.h" Shouldn't you be using resize, not reserve? Otherwise mdswitches[i] is undefined.