From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4E4BB3858404 for ; Mon, 14 Nov 2022 10:29:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E4BB3858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668421763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1EQmo6tCdWuyvwGNULHoyvm+nHQbRE27L3eW0Q9lZBM=; b=LRvH7PobeTE8KUaBotgY5wVR3JYXFAviHHAxJiMVUxXcub+MRosKwEBYB1BjND8pWT/O5v VAcZSPbFZsTM4bxqHSjVQfUQynXLFKAH8U4491qHxI9tsXvZQyYazj0VzGUqux0RCG914P 2nYGU9THgE+Y6p5Yaj9G1GdAL9GpWcc= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-91-7HGXvoXMOG2dC46lB_yvLg-1; Mon, 14 Nov 2022 05:29:20 -0500 X-MC-Unique: 7HGXvoXMOG2dC46lB_yvLg-1 Received: by mail-ed1-f71.google.com with SMTP id x18-20020a05640226d200b00461e027f704so7907856edd.7 for ; Mon, 14 Nov 2022 02:29:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1EQmo6tCdWuyvwGNULHoyvm+nHQbRE27L3eW0Q9lZBM=; b=UaNvq2Zmu47T/7piT6b6McgyYZ6QgGY1eqyVj8x8TbN9HzQznXS8bw5jG+OYF04MGn oYh0LtneE5X9AbNJawNXacEb+xb1QwsmnbsZE+DkbbMrY/1N5rtpQJW+nQI+dPiMjV0m sjDcC4ZDsA34N3TfjC9dcJX2vS7JTq3KVvdUEA6zz2xUwer2qKbVRR3bQkVED679A0Gv TDqvtDeZViZ55xV0gU31oHUpOvzPaFIeeCkrbGjUR8bWa3NaeDf/8D6BrJhIkkEH4FrT snLjy5R2ZDltZ3cO7NQ0zUdb515I/uAfrXLFa1GBwYAPmVwWzeHGsyOG4RuZxaQNykHM /xTA== X-Gm-Message-State: ANoB5pnMRfK7CQM022SL1PNpqWzc4IUuEb7e2Jm2Ik1YlhPLCEGX7Hnc LvMCMJEvi2HdShPU4E1njBimjYmB8mZSg3TucIC2rf6+hN/XHNOV66oBthtt/iaNjkQxJ7Jo/ME Pc6PygqUZpAodpbZABSCvSMcDAN01eGozNA== X-Received: by 2002:aa7:d3c6:0:b0:463:c64e:bc75 with SMTP id o6-20020aa7d3c6000000b00463c64ebc75mr10689403edr.205.1668421758984; Mon, 14 Nov 2022 02:29:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ECFYKnKyc2ddnoPEPgZORtHerj3R1IQuRcA3W85J/D4BgYCSDrHtoxuFGPX1fwjJL3p0fc6ak56Uc+SJazSI= X-Received: by 2002:aa7:d3c6:0:b0:463:c64e:bc75 with SMTP id o6-20020aa7d3c6000000b00463c64ebc75mr10689374edr.205.1668421758723; Mon, 14 Nov 2022 02:29:18 -0800 (PST) MIME-Version: 1.0 References: <20221113180527.2907744-1-arsen@aarsen.me> In-Reply-To: <20221113180527.2907744-1-arsen@aarsen.me> From: Jonathan Wakely Date: Mon, 14 Nov 2022 10:29:07 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories To: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 13 Nov 2022 at 18:06, Arsen Arsenovi=C4=87 via Libstdc++ wrote: > > I'm unsure why this issue only started manifesting now with how old this > code is, but this should fix it. > > libstdc++-v3/ChangeLog: > > * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA > when installing gdb scripts. > * python/Makefile.in: Regenerate. This looks simple, and more consistent with what we already do. Does it solve your issue? commit d26dc9e37602314bf6922ac5667fff34f5559449 (HEAD -> master) Author: Jonathan Wakely Date: Mon Nov 14 10:27:15 2022 libstdc++: Add missing mkdirs for installing python files for debug lib libstdc++-v3/ChangeLog: * python/Makefile.am (intall-data-local): Use mkdirs_p for debug libdir. * python/Makefile.in: Regenerate. diff --git a/libstdc++-v3/python/Makefile.am b/libstdc++-v3/python/Makefile= .am index f523d3a44dc..d5d29b398b0 100644 --- a/libstdc++-v3/python/Makefile.am +++ b/libstdc++-v3/python/Makefile.am @@ -62,5 +62,6 @@ install-data-local: gdb.py $(INSTALL_DATA) gdb.py $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py = ; \ if [ -n "$(debug_gdb_py)" ]; then \ sed "/^libdir =3D /s;'$$;/debug';" gdb.py > debug-gdb.py ; \ + $(mkdir_p) $(DESTDIR)$(toolexeclibdir)/debug $(INSTALL_DATA) debug-gdb.py $(DESTDIR)$(toolexeclibdir)/debug/$$libname-gdb.py ; \ fi diff --git a/libstdc++-v3/python/Makefile.in b/libstdc++-v3/python/Makefile= .in index 05e79b5ac1e..cfec788b6e3 100644 --- a/libstdc++-v3/python/Makefile.in +++ b/libstdc++-v3/python/Makefile.in @@ -627,6 +627,7 @@ install-data-local: gdb.py $(INSTALL_DATA) gdb.py $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py = ; \ if [ -n "$(debug_gdb_py)" ]; then \ sed "/^libdir =3D /s;'$$;/debug';" gdb.py > debug-gdb.py ; \ + $(mkdir_p) $(DESTDIR)$(toolexeclibdir)/debug $(INSTALL_DATA) debug-gdb.py $(DESTDIR)$(toolexeclibdir)/debug/$$libname-gdb.py ; \ fi