From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id 55E013858C3A
 for <gcc-patches@gcc.gnu.org>; Wed, 20 Oct 2021 08:42:42 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55E013858C3A
Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com
 [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-328-iPH1u1i7O_O1_CIsxsY4YQ-1; Wed, 20 Oct 2021 04:42:40 -0400
X-MC-Unique: iPH1u1i7O_O1_CIsxsY4YQ-1
Received: by mail-ua1-f70.google.com with SMTP id
 k2-20020ab04302000000b002cae18c5454so1436085uak.15
 for <gcc-patches@gcc.gnu.org>; Wed, 20 Oct 2021 01:42:40 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=lapJeQIxAMHP7+Qm0ms9ASgLeByU7IyRk/jQcaYeDcw=;
 b=W0u0O5TEYq93nf79aF48LdZfiTzamPa80+eBrxwtBsNTGauSdZ3v6SSkWd3ikBODLA
 cgcd1y8tim0bdnBPmT2LmPiTNAjUD7CBILlScPtzWQ09DXEvdtWVg8zaP8tmU6JzTCxY
 NkMBa6lE6uH1TJniDVM0ZQR/05eG+Ff61z0DxYfFQVCKrNAhSmFC1ITp9nxlF8FLg8vY
 aGyMlknCpgG1Nm5r6mDprZyDdTcdXmY4nMQX37SFWcwwuNRtHXEwHzQyMe0gTk+djGpC
 RRUy1BbWQ4jJ7/hURs9ttyKWybjgycWqQhs5xgUD7jpkjG/TqLQ8aGQWQYCr3AF42PJl
 rkUQ==
X-Gm-Message-State: AOAM531pRDWKml4gD22zKz45AzaSpG8anTyHp71fXZAohJ9t1eeC+G5u
 BMzpdpsYA8rev1z0BNQ7LVdzB0srK40zfVfjmOkLarUJXSulj2Y2nCYj3DmuYKfEI+gRhVTAh8q
 8Zt5fW0VeuSmsxZpABUJQThl7ThpO5GKunQ==
X-Received: by 2002:a67:e0c2:: with SMTP id m2mr41385851vsl.2.1634719360405;
 Wed, 20 Oct 2021 01:42:40 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzRsPyBtuadAVFnjNYYeuJCtdFa7xSWF8cPFhseorVQcrRyQuW5nVJjggVMBpMu9J1rc79HFKVs3IkofVrK/A4=
X-Received: by 2002:a67:e0c2:: with SMTP id m2mr41385843vsl.2.1634719360230;
 Wed, 20 Oct 2021 01:42:40 -0700 (PDT)
MIME-Version: 1.0
References: <YW7P11bzNHMNjJP0@redhat.com>
 <CAPQZVxvq+fWAarSP3Z6j++-x+SrxtV6R7zKXVPymo3E9seX-4A@mail.gmail.com>
In-Reply-To: <CAPQZVxvq+fWAarSP3Z6j++-x+SrxtV6R7zKXVPymo3E9seX-4A@mail.gmail.com>
From: Jonathan Wakely <jwakely@redhat.com>
Date: Wed, 20 Oct 2021 09:42:29 +0100
Message-ID: <CACb0b4nBpiY9youtM40_TEHWQUjcqytomCQFWZC4hUTwSsm7cg@mail.gmail.com>
Subject: Re: [committed] libstdc++: Implement monadic operations for
 std::optional (P0798R8)
To: Tim Song <t.canens.cpp@gmail.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Oct 2021 08:42:43 -0000

On Wed, 20 Oct 2021 at 06:48, Tim Song wrote:
>
> On Tue, Oct 19, 2021 at 9:05 AM Jonathan Wakely via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> > +constexpr bool
> > +test_copy_elision()
> > +{
> > +  return true;
> > +}
> > +
> > +static_assert( test_copy_elision() );
> > +
>
> This isn't much of a test :)

The ultimate copy elision. The copies even get removed from the source code.

Thanks for spotting it. I meant to check we're constructing directly
into the union member without materializing the temporary early. I'll
add that today.