From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id 82EF1385780E for ; Thu, 21 Oct 2021 16:55:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 82EF1385780E Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-7TD-YwCmP32Ks8rNZnw-Ug-1; Thu, 21 Oct 2021 12:55:38 -0400 X-MC-Unique: 7TD-YwCmP32Ks8rNZnw-Ug-1 Received: by mail-vk1-f198.google.com with SMTP id n6-20020a1f2706000000b002a45b52f52dso131696vkn.22 for ; Thu, 21 Oct 2021 09:55:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4tTiVKcdZvASLa2aBDZzbGCZNH+e35xqUmEDSKcrxjI=; b=lJwfBGX6aXKxrwYIQTgXS8JEwdDQAqwVuMeS8V6ghrbQ7Kuq9+BqTCN8SBTpDYqy1D B8pcHE5+H0UEJi8nEoMwWLESghIzna09rAqVrEczPJ/FLdu1h46zb7YkrVEDJQCwN7Nc KP1dSGm5pxxc2tF/aTXNINdJlB3LsKsyyv4J8ewPqYJoOiE9AbAdg20IkQ18tawY/z0W hzB/01q0XBnW5cpwC8JA1lMm+OrmRqFb7YhBdpxvcS/6p4FtwXIOqSNU5derOGxvhiL4 apoD9gOTW5Mxfp03hAOBunoHwkogWKfGiAITF3g2Hb/AUblnTOca2Lbc9H9HhJuJ7ycC gI/Q== X-Gm-Message-State: AOAM531KXrd1mMkFQCoYYyD8gSvT49n6g0H5ulXrUclR9ajWhKFWCZkf Y5OseN759EDjduJGIIHIiYhI79qLUwnFTL35qaglkRBApBTCk5m016SrEaZOvKy6nL2v4iBWn67 3cWUfShYMMK+jKCvYjCVs43ojnzl8SL90lA== X-Received: by 2002:a05:6102:3049:: with SMTP id w9mr7623240vsa.4.1634835337949; Thu, 21 Oct 2021 09:55:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwV6A8m/zRdrD2teqbXYVvCgoYTJUe34MbM/b2CF+MD+JxyFdg3KVtoUWJ6qOlw2AD2LbYe74xbowPvkaB2HEM= X-Received: by 2002:a05:6102:3049:: with SMTP id w9mr7623192vsa.4.1634835337645; Thu, 21 Oct 2021 09:55:37 -0700 (PDT) MIME-Version: 1.0 References: <4eec3fb9-851e-3e4e-f9f4-1110db3af747@gmail.com> <6c349652-8b6f-2027-08c3-6ce58a765aeb@gmail.com> <04e376af-0819-d289-9990-fc42d5db8f6d@gmail.com> In-Reply-To: <04e376af-0819-d289-9990-fc42d5db8f6d@gmail.com> From: Jonathan Wakely Date: Thu, 21 Oct 2021 17:55:26 +0100 Message-ID: Subject: Re: [PATH][_GLIBCXX_DEBUG] Fix unordered container merge To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 16:55:42 -0000 On Thu, 21 Oct 2021 at 17:52, Fran=C3=A7ois Dumont w= rote: > I eventually would like to propose a different approach. > > I am adding a hook in normal implementation to let the _GLIBCXX_DEBUG cod= e > know when a node is being extracted. This way invalidation is only done b= y > comparing nodes, no need to compute hash code for this operation. > Ugh, this is horrible, I don't like the normal mode depending on the debug mode (even if it's just having to add hooks like this). The previous patch seemed fine to me. Already an improvement on what is on trunk now.