From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 129813858418 for ; Tue, 28 Sep 2021 20:26:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 129813858418 Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-sqm-cdouMf2TXkGFslruUg-1; Tue, 28 Sep 2021 16:26:39 -0400 X-MC-Unique: sqm-cdouMf2TXkGFslruUg-1 Received: by mail-vs1-f70.google.com with SMTP id a17-20020a67f7d1000000b002d530b0e501so114722vsp.9 for ; Tue, 28 Sep 2021 13:26:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HfaADEWuEK3kpNjqqWbykcrsFPoi/f0ChYEVGvlr8qo=; b=uo7DPxqkF3hySzwpg81E84GpJeB23NAT1J+OGkDdCLmyqTeTMLmj14fvXCJpWFUnUW 1vb4N1LVJXdcKsXN2KWiSy8hhZ37NGQY57j8KMPnrJcpqBJS9hI0XLI0rwPOSv9Mq12R r4NpSeOy0Yx5hrlJmcKCOLfAyY6iiMe4jYL3V5x3YGSlJI53ztf65vJ1oMFr9y8O1Qi7 uqB9vnCy5m4POF99Hz8jzB8qQ7B0o9ecG8SPsPbN/Fs2olQYCCTN9DC28xNHGexs2T6m 9illGiJsbC610Tq0IVK1LGdi8J8kis3ScVls8Yjx+gHi9T84oERdCqFscRpICGczDWWE e8/A== X-Gm-Message-State: AOAM5327RfmdvBGbWZtcIFVSzYIr2V3l0GH7hOPhfAhjl0HZ+Qadosxt fmtJ+kXmb18vvG3RrCzW6EziHSwdumL4dw8qJNwOjQ2xFe/0sKTwazsvZirOibYqTIIDY28g9Wj Aj8pycGLYE51+encqPiHzDNQGDubBXF4c8w== X-Received: by 2002:a67:fe4f:: with SMTP id m15mr7724455vsr.2.1632860798966; Tue, 28 Sep 2021 13:26:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9zGC/1gfWAvJDNvUy1Htl1ebWf4ChwlhRgqcodmjue+xCYMHnZ2ag8D4/s+86JnC7/FyyBjM4KFB3eQoUb9k= X-Received: by 2002:a67:fe4f:: with SMTP id m15mr7724432vsr.2.1632860798771; Tue, 28 Sep 2021 13:26:38 -0700 (PDT) MIME-Version: 1.0 References: <5e13b454-0722-01ef-8e62-e88654fe9021@gmail.com> <900f1af6-7bed-f78d-0601-e011ccc63d3a@gmail.com> In-Reply-To: <900f1af6-7bed-f78d-0601-e011ccc63d3a@gmail.com> From: Jonathan Wakely Date: Tue, 28 Sep 2021 21:26:27 +0100 Message-ID: Subject: Re: Fix 48631_neg test in _GLIBCXX_VERSION_NAMESPACE mode To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , "libstdc++@gcc.gnu.org" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 20:26:42 -0000 On Tue, 28 Sept 2021 at 21:21, Fran=C3=A7ois Dumont via Libstdc++ wrote: > > On 27/09/21 11:06 pm, Jonathan Wakely wrote: > > On Mon, 27 Sept 2021 at 21:26, Fran=C3=A7ois Dumont via Libstdc++ > > wrote: > >> Here is a small patch to fix a test which fails in > >> _GLIBCXX_VERSION_NAMESPACE mode. > >> > >> IMHO it would be better to avoid putting content in > >> versioned namespace, no ? > > No opinion on this, you prefer to use consistently the versioned namespac= e ? I haven't though about it in much detail, but I think it's safer to keep them in the versioned namespace. Can we be sure that we'd never need to make any incompatible changes to anything in that header? It seems likely, but I'm not entirely confident. > >> There is of course more work to do, so for now here is the simpler app= roach. > >> > >> Ok to commit ? > > Leaving the pattern ending with just "struct" isn't very useful. > > Wouldn't it be better to do: > > > > // { dg-prune-output "no type named 'type' in" } > > > > or just: > > > > // { dg-prune-output "enable_if" } > > > > ? > > > > Either of those is OK to commit. > > Done with "enable_if" Thanks.