From: Jonathan Wakely <jwakely@redhat.com>
To: Ken Matsui <kmatsui@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH v2 2/2] libstdc++: use new built-in trait __is_scalar for std::is_scalar
Date: Wed, 12 Jul 2023 10:50:29 +0100 [thread overview]
Message-ID: <CACb0b4nEQkxjLDDF9BgTCwuMg7Ew0nSnbPxsrtG7NKMtcT_QSA@mail.gmail.com> (raw)
In-Reply-To: <20230708044539.61276-2-kmatsui@gcc.gnu.org>
On Sat, 8 Jul 2023 at 05:47, Ken Matsui via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> This patch gets std::is_scalar to dispatch to new built-in trait
> __is_scalar.
>
> libstdc++-v3/ChangeLog:
>
> * include/std/type_traits (is_scalar): Use __is_scalar built-in
> trait.
> (is_scalar_v): Likewise.
OK for trunk (conditional on the front-end change being committed
first of course).
>
> Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
> ---
> libstdc++-v3/include/std/type_traits | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits
> index 0e7a9c9c7f3..bc90b2c61ca 100644
> --- a/libstdc++-v3/include/std/type_traits
> +++ b/libstdc++-v3/include/std/type_traits
> @@ -678,11 +678,18 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> struct is_member_pointer;
>
> /// is_scalar
> +#if __has_builtin(__is_scalar)
> + template<typename _Tp>
> + struct is_scalar
> + : public __bool_constant<__is_scalar(_Tp)>
> + { };
> +#else
> template<typename _Tp>
> struct is_scalar
> : public __or_<is_arithmetic<_Tp>, is_enum<_Tp>, is_pointer<_Tp>,
> is_member_pointer<_Tp>, is_null_pointer<_Tp>>::type
> { };
> +#endif
>
> /// is_compound
> template<typename _Tp>
> @@ -3204,8 +3211,15 @@ template <typename _Tp>
> inline constexpr bool is_fundamental_v = is_fundamental<_Tp>::value;
> template <typename _Tp>
> inline constexpr bool is_object_v = is_object<_Tp>::value;
> +
> +#if __has_builtin(__is_scalar)
> +template <typename _Tp>
> + inline constexpr bool is_scalar_v = __is_scalar(_Tp);
> +#else
> template <typename _Tp>
> inline constexpr bool is_scalar_v = is_scalar<_Tp>::value;
> +#endif
> +
> template <typename _Tp>
> inline constexpr bool is_compound_v = is_compound<_Tp>::value;
> template <typename _Tp>
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-07-12 9:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 9:13 [PATCH 1/2] c++, libstdc++: implement __is_scalar built-in trait Ken Matsui
2023-07-03 9:13 ` [PATCH 2/2] libstdc++: use new built-in trait __is_scalar for std::is_scalar Ken Matsui
2023-07-03 10:00 ` [PATCH 1/2] c++, libstdc++: implement __is_scalar built-in trait Ken Matsui
2023-07-08 4:45 ` [PATCH v2 " Ken Matsui
2023-07-08 4:45 ` [PATCH v2 2/2] libstdc++: use new built-in trait __is_scalar for std::is_scalar Ken Matsui
2023-07-12 9:50 ` Jonathan Wakely [this message]
2023-07-12 18:32 ` Ken Matsui
2023-07-12 18:56 ` Xi Ruoyao
2023-07-12 19:06 ` Ken Matsui
2023-07-12 19:23 ` Jonathan Wakely
2023-07-12 19:35 ` Ken Matsui
2023-09-04 15:00 ` [PING][PATCH v2 1/2] c++, libstdc++: implement __is_scalar built-in trait Ken Matsui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4nEQkxjLDDF9BgTCwuMg7Ew0nSnbPxsrtG7NKMtcT_QSA@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kmatsui@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).