From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id 8AEDC3856DFF
 for <gcc-patches@gcc.gnu.org>; Tue,  5 Jul 2022 18:02:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8AEDC3856DFF
Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com
 [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-452-8-NtaBGxOHq9ALcaiz1fSA-1; Tue, 05 Jul 2022 14:02:46 -0400
X-MC-Unique: 8-NtaBGxOHq9ALcaiz1fSA-1
Received: by mail-qt1-f199.google.com with SMTP id
 fz24-20020a05622a5a9800b0031d5de96774so5633396qtb.7
 for <gcc-patches@gcc.gnu.org>; Tue, 05 Jul 2022 11:02:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=WK0lqLP44YHNGQlL7+okCCkSfznddO/T3OjJjDvxBZk=;
 b=v2tZBJ1TbX1R26JZkbFKw7fFVNRiLmM8ofG8qOoNwFWTC9TMNSVy2Lr5LKIJIqLF14
 Yfaa0L79BeSIG89QMcUXABt2PKPq/H9tuf6bSRN+64IHrOrzVSLymhYE4qVLfdq7TduY
 FGYNlJVc0ucAT6NiQEpvYf5oCDoX393KG/rfBRmbep+JiRVyIaM/knCbXKGSMeFnQ1rw
 oE2+fZE4J/x8eGrxT4q9hEldvjZe9b/ZHr91Z7XQPPUH3aacW/6vSBdH+RA9r9nJTR9J
 uNSgfWdKRBgL9p3uhMDhSwBTa3te9Zc4HMHc+X/6dliXc+R0HJAfS60QJp/DAoPe8LHK
 fB9Q==
X-Gm-Message-State: AJIora8UzmYoOo5hVikkqZvz1V5w9Q8QuslI4wOPYWajXQ4AK3a90YBg
 irKzZ6vifnRfXm62xXjHWL6AyAw+7lfWbBTK5JxSsfPkn5ynzQRQ0kXKqdi282d43RFW00yV+aH
 5eY4ZJdO28bAKa1WUFR6p5hPRBwMo3W7tNA==
X-Received: by 2002:ac8:5cd3:0:b0:31d:3adc:bd00 with SMTP id
 s19-20020ac85cd3000000b0031d3adcbd00mr18355123qta.594.1657044165427; 
 Tue, 05 Jul 2022 11:02:45 -0700 (PDT)
X-Google-Smtp-Source: AGRyM1uWQp62erVJh+NAitrgUwryrZuYzHpdseayc/233RzoT/quuUaE8D2ZaegINUBKEbK+v8fue8ukOtlzbKrNF50=
X-Received: by 2002:ac8:5cd3:0:b0:31d:3adc:bd00 with SMTP id
 s19-20020ac85cd3000000b0031d3adcbd00mr18355087qta.594.1657044165183; Tue, 05
 Jul 2022 11:02:45 -0700 (PDT)
MIME-Version: 1.0
References: <orv8st9qt6.fsf@lxoliva.fsfla.org>
 <CACb0b4mTtAWt0LVqw88iuJ5teY0-6RyKAB6krHYRWKABPPSZ8Q@mail.gmail.com>
 <or5ykr4nj5.fsf@lxoliva.fsfla.org>
 <CACb0b4nWjuStDVMPjGGEOeej52QsG5Ubf7TwhASSne=zgq+j6Q@mail.gmail.com>
 <orr13azc3e.fsf@lxoliva.fsfla.org> <ory1x8orgh.fsf@lxoliva.fsfla.org>
 <CACb0b4n6n_aj_0_YUrZH51+6qFbVDesC_tGEVps9QYsmCOcyUQ@mail.gmail.com>
 <or4jzvpi5m.fsf@lxoliva.fsfla.org>
In-Reply-To: <or4jzvpi5m.fsf@lxoliva.fsfla.org>
From: Jonathan Wakely <jwakely@redhat.com>
Date: Tue, 5 Jul 2022 19:02:34 +0100
Message-ID: <CACb0b4nEVAs+pPr=DcuvPYLomc_+isYayQGWyfGj1jjNuxdWww@mail.gmail.com>
Subject: Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp
To: Alexandre Oliva <oliva@adacore.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>, gcc Patches <gcc-patches@gcc.gnu.org>,
 Joel Brobecker <brobecker@adacore.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2022 18:02:54 -0000

On Tue, 5 Jul 2022 at 18:46, Alexandre Oliva <oliva@adacore.com> wrote:
>
> On Jul  5, 2022, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> > The cast itself is fine, but I'd like a comment like "N.B. pid_t is a
> > pointer on vxworks" so I don't "simplify" it again.
>
>
> libstdc++: testsuite: why cast getpid result
>
> Add a comment next to the getpid call to explain why the typecast is
> needed.
>
> Regstrapped on x86_64-linux-gnu, will install later today if there's no
> objection.


Thanks.