From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/2] libstdc++: Increase timeouts for PSTL tests in debug mode [PR90276]
Date: Wed, 26 Jun 2024 21:13:20 +0100 [thread overview]
Message-ID: <CACb0b4nGYm56KSrp2hMd1tL-qA9no6MqsmBREi9Gza+THd2-Tg@mail.gmail.com> (raw)
In-Reply-To: <20240620153526.2024602-2-jwakely@redhat.com>
Pushed to trunk now.
On Thu, 20 Jun 2024 at 16:36, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> Tested x86_64-linux.
>
> -- >8 --
>
> These tests compile very slowly in debug mode.
>
> libstdc++-v3/ChangeLog:
>
> PR libstdc++/90276
> * testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc:
> Increase timeout for debug mode.
> * testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc:
> Likewise.
> * testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc:
> Likewise.
> * testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc:
> Likewise.
> * testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc:
> Likewise.
> * testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc:
> Likewise.
> ---
> .../25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc | 1 +
> .../pstl/alg_modifying_operations/transform_binary.cc | 1 +
> .../testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc | 1 +
> .../25_algorithms/pstl/alg_sorting/lexicographical_compare.cc | 1 +
> .../testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc | 1 +
> .../25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc
> index ea647c6c23a..1b788e1b7ee 100644
> --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc
> +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc
> @@ -2,6 +2,7 @@
> // { dg-options "-ltbb" }
> // { dg-do run { target c++17 } }
> // { dg-timeout-factor 3 }
> +// { dg-timeout-factor 5 { target debug_mode } }
> // { dg-require-effective-target tbb_backend }
>
> //===-- rotate_copy.pass.cpp ----------------------------------------------===//
> diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc
> index 1f5f239a94b..16b815c5d51 100644
> --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc
> +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc
> @@ -2,6 +2,7 @@
> // { dg-options "-ltbb" }
> // { dg-do run { target c++17 } }
> // { dg-timeout-factor 3 }
> +// { dg-timeout-factor 5 { target debug_mode } }
> // { dg-require-effective-target tbb_backend }
>
> //===-- transform_binary.pass.cpp -----------------------------------------===//
> diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc
> index 1173186f65c..441f5d1e378 100644
> --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc
> +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc
> @@ -2,6 +2,7 @@
> // { dg-options "-ltbb" }
> // { dg-do run { target c++17 } }
> // { dg-timeout-factor 3 }
> +// { dg-timeout-factor 5 { target debug_mode } }
> // { dg-require-effective-target tbb_backend }
>
> //===-- mismatch.pass.cpp -------------------------------------------------===//
> diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc
> index 924aa78652e..78edeb025d7 100644
> --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc
> +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc
> @@ -2,6 +2,7 @@
> // { dg-options "-ltbb" }
> // { dg-do run { target c++17 } }
> // { dg-timeout-factor 3 }
> +// { dg-timeout-factor 5 { target debug_mode } }
> // { dg-require-effective-target tbb_backend }
>
> //===-- lexicographical_compare.pass.cpp ----------------------------------===//
> diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc
> index 0a9f41ca179..e4bd435d192 100644
> --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc
> +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc
> @@ -2,6 +2,7 @@
> // { dg-options "-ltbb" }
> // { dg-do run { target c++17 } }
> // { dg-timeout-factor 3 }
> +// { dg-timeout-factor 5 { target debug_mode } }
> // { dg-require-effective-target tbb_backend }
>
> //===-- minmax_element.pass.cpp -------------------------------------------===//
> diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc
> index 1cc59856086..ad3befcb690 100644
> --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc
> +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc
> @@ -2,6 +2,7 @@
> // { dg-options "-ltbb" }
> // { dg-do run { target c++17 } }
> // { dg-timeout-factor 3 }
> +// { dg-timeout-factor 5 { target debug_mode } }
> // { dg-require-effective-target tbb_backend }
>
> //===-- set.pass.cpp ------------------------------------------------------===//
> --
> 2.45.2
>
next prev parent reply other threads:[~2024-06-26 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 15:35 [PATCH 1/2] libstdc++: Work around some PSTL test failures for " Jonathan Wakely
2024-06-20 15:35 ` [PATCH 2/2] libstdc++: Increase timeouts for PSTL tests in " Jonathan Wakely
2024-06-26 20:13 ` Jonathan Wakely [this message]
2024-06-26 20:13 ` [PATCH 1/2] libstdc++: Work around some PSTL test failures for " Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4nGYm56KSrp2hMd1tL-qA9no6MqsmBREi9Gza+THd2-Tg@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).