From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E56FC387540F for ; Wed, 26 Jun 2024 20:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E56FC387540F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E56FC387540F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719432822; cv=none; b=ExoGQj5DnkiweBkkm2XXLG4TstKn0qYAdXV8l01wMaETKxwf0wsCx5TzDgnnyuTpjLcRHb1Vg5TqnpnLsIP39LGu5EqdEt4r1pfjcmKDKYs+gHlYEY7i9Ea5LnsTR6LvryeTznKbdrMsnK61gcF9GgoZkm7AtvX4zricOqVFmCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719432822; c=relaxed/simple; bh=1+TjGSYBqEaFT5yAgIGWg57ImxFIMOGbe2Vx/fiBa38=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Mlq3HEuJUPumoNt7zYxV9/xoBs3g/kzmJNmZ6TtKaAAVywh4TmBgJGW3hPgHfG4CNcPNfLOE5aC3JjQDDm8N6FW1ckoxNwTvH1oLTe5MLPZzNXQP7mNeGIWBoU9qTaprSFAYgyp5hPdsrpi/+l9qfexWkR6vDgNsVAan/Iam9aM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719432819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pbG0GRk1e0q7U3yYROCHquPCLoU/NjuEV/qloaFDlhc=; b=MmyK6Iaokiaqon90H86pTeyZM5T9tjGSj0c1wYvnYd+d3cLZLoHtz26ezUhWJyYSTJfBDx CO25yvGK+EOkDiguToyLuqNBgfCQ6np0b+lgxlQVVCMan0cCbUaEBEkF4z2tSrKp5Jf1Jx vJ7/YKfByzROqUTDXt+LxYlVRK6CqJ0= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-VrIsJ2JiPfqFzsZ3Etd_oA-1; Wed, 26 Jun 2024 16:13:37 -0400 X-MC-Unique: VrIsJ2JiPfqFzsZ3Etd_oA-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-64530966cd7so73483767b3.3 for ; Wed, 26 Jun 2024 13:13:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719432816; x=1720037616; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pbG0GRk1e0q7U3yYROCHquPCLoU/NjuEV/qloaFDlhc=; b=Y37vHBpSZW7TEsKftivG6yvVg3C7DO2HM1mAbG4JKsKyyLbzbMT1XG3ELWkHplbaVZ Ygh43YEYNL1HV1pSo1Nb41MpbmMV7Xjzlb2A5Xenu4R4UjKoaxTmz0Cpuk9+Kv7tIK8/ yz9nvLWwH5nTTxHUYZW2SR1NWvwqky1ljm3CeEQRqlTUXvwYHvmckmZjNuqR6qnk+W/y g+45CR7r8GUg7tofJRpbIVcxmS0w75lxHDSVr7w3U9i8HFKCEQOBTiXMrE2qTeGzL4De owvlCWNizVu3WMr5HzzAVuGy9UZrgAYaYADjM840OZ8a8/8xnuQdfPRHPdXZsM+2N4Zn RWfw== X-Forwarded-Encrypted: i=1; AJvYcCX6fwYiGOiJ+A8b/CjikEMymCIWY/5ybUJlK3IkpHj9cTE38XusI1j0Zrua3HozjY4ADjbnFFG4/aLRNStrLOL8S+9VMm9FYw== X-Gm-Message-State: AOJu0YyBbz3Uxb3iRXbvsL99O7R5F1oZmHI7I8gUTYHP8+JoSFPD4Itz NHQ+klZyNr/0/WFP14BUjry36HvUyStEWBD6TkvllcwnIODqOaimgbgBZS5tw5kSXepQbQaj/Gv EdUAgEKiVZcEYADRl0Bc9Q+37gKVxKHT3Z5UhBbiyI8HVySxycfwsi4m5D9kBfW/o6BkwDb4ol/ 4apyP/4UqQWpPP3s0VEBLvgZ68f4xoKQ== X-Received: by 2002:a05:690c:6f10:b0:646:ebea:1da2 with SMTP id 00721157ae682-646ebea1e5dmr66916937b3.38.1719432816324; Wed, 26 Jun 2024 13:13:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0YB988KEjMrAq11iry3Y/Dk57U/4ZzREMj8E4zmS5KloNsZYoY1z/MX5mrBQi8Zku7qnzBJzC1zh84QmC52s= X-Received: by 2002:a05:690c:6f10:b0:646:ebea:1da2 with SMTP id 00721157ae682-646ebea1e5dmr66916777b3.38.1719432815957; Wed, 26 Jun 2024 13:13:35 -0700 (PDT) MIME-Version: 1.0 References: <20240620153526.2024602-1-jwakely@redhat.com> <20240620153526.2024602-2-jwakely@redhat.com> In-Reply-To: <20240620153526.2024602-2-jwakely@redhat.com> From: Jonathan Wakely Date: Wed, 26 Jun 2024 21:13:20 +0100 Message-ID: Subject: Re: [PATCH 2/2] libstdc++: Increase timeouts for PSTL tests in debug mode [PR90276] To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pushed to trunk now. On Thu, 20 Jun 2024 at 16:36, Jonathan Wakely wrote: > > Tested x86_64-linux. > > -- >8 -- > > These tests compile very slowly in debug mode. > > libstdc++-v3/ChangeLog: > > PR libstdc++/90276 > * testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc: > Increase timeout for debug mode. > * testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc: > Likewise. > * testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc: > Likewise. > * testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc: > Likewise. > * testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc: > Likewise. > * testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc: > Likewise. > --- > .../25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc | 1 + > .../pstl/alg_modifying_operations/transform_binary.cc | 1 + > .../testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc | 1 + > .../25_algorithms/pstl/alg_sorting/lexicographical_compare.cc | 1 + > .../testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc | 1 + > .../25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc > index ea647c6c23a..1b788e1b7ee 100644 > --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc > +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/rotate_copy.cc > @@ -2,6 +2,7 @@ > // { dg-options "-ltbb" } > // { dg-do run { target c++17 } } > // { dg-timeout-factor 3 } > +// { dg-timeout-factor 5 { target debug_mode } } > // { dg-require-effective-target tbb_backend } > > //===-- rotate_copy.pass.cpp ----------------------------------------------===// > diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc > index 1f5f239a94b..16b815c5d51 100644 > --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc > +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_modifying_operations/transform_binary.cc > @@ -2,6 +2,7 @@ > // { dg-options "-ltbb" } > // { dg-do run { target c++17 } } > // { dg-timeout-factor 3 } > +// { dg-timeout-factor 5 { target debug_mode } } > // { dg-require-effective-target tbb_backend } > > //===-- transform_binary.pass.cpp -----------------------------------------===// > diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc > index 1173186f65c..441f5d1e378 100644 > --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc > +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_nonmodifying/mismatch.cc > @@ -2,6 +2,7 @@ > // { dg-options "-ltbb" } > // { dg-do run { target c++17 } } > // { dg-timeout-factor 3 } > +// { dg-timeout-factor 5 { target debug_mode } } > // { dg-require-effective-target tbb_backend } > > //===-- mismatch.pass.cpp -------------------------------------------------===// > diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc > index 924aa78652e..78edeb025d7 100644 > --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc > +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/lexicographical_compare.cc > @@ -2,6 +2,7 @@ > // { dg-options "-ltbb" } > // { dg-do run { target c++17 } } > // { dg-timeout-factor 3 } > +// { dg-timeout-factor 5 { target debug_mode } } > // { dg-require-effective-target tbb_backend } > > //===-- lexicographical_compare.pass.cpp ----------------------------------===// > diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc > index 0a9f41ca179..e4bd435d192 100644 > --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc > +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/minmax_element.cc > @@ -2,6 +2,7 @@ > // { dg-options "-ltbb" } > // { dg-do run { target c++17 } } > // { dg-timeout-factor 3 } > +// { dg-timeout-factor 5 { target debug_mode } } > // { dg-require-effective-target tbb_backend } > > //===-- minmax_element.pass.cpp -------------------------------------------===// > diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc > index 1cc59856086..ad3befcb690 100644 > --- a/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc > +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/alg_sorting/set_symmetric_difference.cc > @@ -2,6 +2,7 @@ > // { dg-options "-ltbb" } > // { dg-do run { target c++17 } } > // { dg-timeout-factor 3 } > +// { dg-timeout-factor 5 { target debug_mode } } > // { dg-require-effective-target tbb_backend } > > //===-- set.pass.cpp ------------------------------------------------------===// > -- > 2.45.2 >