From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D0F6A3858C78 for ; Wed, 6 Sep 2023 22:30:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0F6A3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694039423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/okFKzNgBiuMqKrVglxT47O4WMqdEd6/5wqq7g6Yzhc=; b=bs8WIXJdWnHtE+eGxEMuPH04k9NdPJ/dsV8th6eAsckzZFyEk2pbYGr5Zc6cQKTawtMLZt jB5n19/eTV00DI0QYRf6iiELekbXa2bnoD2lLUyGaLVrWnTruzQ8i8CgY9VvM0c++pIioP epiG7t5tQqJidiIrLHAYxRhDroum9Nc= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-10D5gcdnPQyfZ5EpWD4Trg-1; Wed, 06 Sep 2023 18:30:22 -0400 X-MC-Unique: 10D5gcdnPQyfZ5EpWD4Trg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2b6ff15946fso3445511fa.2 for ; Wed, 06 Sep 2023 15:30:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694039421; x=1694644221; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/okFKzNgBiuMqKrVglxT47O4WMqdEd6/5wqq7g6Yzhc=; b=I6CmOd0V5ckCLdEcbA6SUEE78Z5ySyCzohN0m+tXak8FChFwPDEG8gZIE/bQEfsdDi 2BF4CYBpPUod9Lj7goC7Rr5U6GldlM7M7ZG8nNXanNAhybxD0ZUou4cLyFF0j0h0g/Ky PNRQbwKIxeZ/pc+8jvukzZUCqsQ2dD3PSZTgVJwzP7tTO8y7LBwbwFVrdGuPYPqU/IFB LypUKMDxt9zPPpjR/ao1SVRXCVexebTLdj2hMgUEncLZb/kOH3DhOk6YON4LS6xy9QEu 2PpWhUp0k3VMcuaxmNlZZQ4q1kCHvc7fTxF7FNxxXW7rMZlEXqHMeaM6JmbyttSR5HWS 5HDA== X-Gm-Message-State: AOJu0YwgX4iYgXDNbK0UiwMcmyjcigBmohu8DuAB0rObWDiOaAzsBBWz DGQR14TeK2eAx6yfe7vewO3Y1F1vFKcs5g69T881ifNOet2B889NXHD+swEhTk+wZzFWYqIIxOF y2rFFLMyiqA2+zlFxk06deqVi1sxskOhI7A== X-Received: by 2002:a2e:b0d8:0:b0:2bc:fa8f:83bf with SMTP id g24-20020a2eb0d8000000b002bcfa8f83bfmr3195696ljl.36.1694039420878; Wed, 06 Sep 2023 15:30:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5qshDhbhPq4YdjA/TEepmBwOPINvnNFGyDUjdY95g6dnioM2qcLJMlN1YDPzxTUQba6scBLUkuwIWzmdFmTA= X-Received: by 2002:a2e:b0d8:0:b0:2bc:fa8f:83bf with SMTP id g24-20020a2eb0d8000000b002bcfa8f83bfmr3195686ljl.36.1694039420552; Wed, 06 Sep 2023 15:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20230823160322.237140-1-jwakely@redhat.com> <20230904164617.F1DFA20427@pchp3.se.axis.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 6 Sep 2023 23:30:08 +0100 Message-ID: Subject: Re: [RFC] libstdc++: Make --enable-libstdcxx-backtrace=auto default to yes To: Jonathan Wakely Cc: Hans-Peter Nilsson , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 4 Sept 2023 at 17:49, Jonathan Wakely wrote: > > On Mon, 4 Sept 2023 at 17:47, Hans-Peter Nilsson via Libstdc++ > wrote: > > > > > Date: Fri, 1 Sep 2023 12:16:40 +0100 > > > Reply-To: Jonathan Wakely > > > > > > On Wed, 23 Aug 2023 at 17:03, Jonathan Wakely via Libstdc++ > > > wrote: > > > > > > > > Any objections to this? It's a C++23 feture, so should be enabled by > > > > default. > > > > > > I've pushed this to trunk, so let's see what breaks! > > > > > > > > > > > > > > -- >8 -- > > > > > > > > This causes libstdc++_libbacktrace.a to be built by default. This might > > > > fail on some targets, in which case we can make the 'auto' choice expand > > > > to either 'yes' or 'no' depending on the target. > > > > > > > > libstdc++-v3/ChangeLog: > > > > > > > > * acinclude.m4 (GLIBCXX_ENABLE_BACKTRACE): Default to yes. > > > > * configure: Regenerate. > > > > Incidentally, should check_effective_target_stacktrace in > > libstdc++.exp also be adjusted to match; removing the > > _GLIBCXX_HOSTED condition? > > No, it should still depend on is_hosted. The acinclude.m4 macro should > check that. Done in r14-3761-g6de5f5a4fe85bd